From patchwork Thu Aug 27 11:23:42 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Miaohe Lin X-Patchwork-Id: 1352504 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming-netdev@ozlabs.org Delivered-To: patchwork-incoming-netdev@ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org (client-ip=23.128.96.18; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=huawei.com Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by ozlabs.org (Postfix) with ESMTP id 4Bcgpw66LRz9sSJ for ; Thu, 27 Aug 2020 21:43:36 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728861AbgH0LnV (ORCPT ); Thu, 27 Aug 2020 07:43:21 -0400 Received: from szxga04-in.huawei.com ([45.249.212.190]:10331 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1728834AbgH0Lmz (ORCPT ); Thu, 27 Aug 2020 07:42:55 -0400 Received: from DGGEMS407-HUB.china.huawei.com (unknown [172.30.72.58]) by Forcepoint Email with ESMTP id B3045BEE75981B411CD0; Thu, 27 Aug 2020 19:25:01 +0800 (CST) Received: from huawei.com (10.175.104.175) by DGGEMS407-HUB.china.huawei.com (10.3.19.207) with Microsoft SMTP Server id 14.3.487.0; Thu, 27 Aug 2020 19:24:51 +0800 From: Miaohe Lin To: , , , , , , , , , , CC: , , Subject: [PATCH] net: exit immediately when off = 0 in skb_headers_offset_update() Date: Thu, 27 Aug 2020 07:23:42 -0400 Message-ID: <20200827112342.44526-1-linmiaohe@huawei.com> X-Mailer: git-send-email 2.19.1 MIME-Version: 1.0 X-Originating-IP: [10.175.104.175] X-CFilter-Loop: Reflected Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org In the case of off = 0, skb_headers_offset_update() do nothing indeed. Signed-off-by: Miaohe Lin --- net/core/skbuff.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/net/core/skbuff.c b/net/core/skbuff.c index 18ed56316e56..f67f0da20a5b 100644 --- a/net/core/skbuff.c +++ b/net/core/skbuff.c @@ -1459,6 +1459,8 @@ EXPORT_SYMBOL(skb_clone); void skb_headers_offset_update(struct sk_buff *skb, int off) { + if (unlikely(off == 0)) + return; /* Only adjust this if it actually is csum_start rather than csum */ if (skb->ip_summed == CHECKSUM_PARTIAL) skb->csum_start += off;