| Message ID | 20200823072346.17140-1-dinghao.liu@zju.edu.cn |
|---|---|
| State | Accepted |
| Delegated to: | David Miller |
| Headers | show |
| Series | NFC: st95hf: Fix memleak in st95hf_in_send_cmd | expand |
From: Dinghao Liu <dinghao.liu@zju.edu.cn> Date: Sun, 23 Aug 2020 15:23:43 +0800 > When down_killable() fails, skb_resp should be freed > just like when st95hf_spi_send() fails. > > Signed-off-by: Dinghao Liu <dinghao.liu@zju.edu.cn> Applied, thank you.
diff --git a/drivers/nfc/st95hf/core.c b/drivers/nfc/st95hf/core.c index 9642971e89ce..457854765983 100644 --- a/drivers/nfc/st95hf/core.c +++ b/drivers/nfc/st95hf/core.c @@ -966,7 +966,7 @@ static int st95hf_in_send_cmd(struct nfc_digital_dev *ddev, rc = down_killable(&stcontext->exchange_lock); if (rc) { WARN(1, "Semaphore is not found up in st95hf_in_send_cmd\n"); - return rc; + goto free_skb_resp; } rc = st95hf_spi_send(&stcontext->spicontext, skb->data,
When down_killable() fails, skb_resp should be freed just like when st95hf_spi_send() fails. Signed-off-by: Dinghao Liu <dinghao.liu@zju.edu.cn> --- drivers/nfc/st95hf/core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)