| Message ID | 20200820185204.652-10-irusskikh@marvell.com |
|---|---|
| State | Changes Requested |
| Delegated to: | David Miller |
| Headers | show |
| Series | qed: introduce devlink health support | expand |
Igor Russkikh wrote: > Fix indent on some of adjacent declarations. > > Signed-off-by: Igor Russkikh <irusskikh@marvell.com> > Signed-off-by: Alexander Lobakin <alobakin@marvell.com> > Signed-off-by: Michal Kalderon <michal.kalderon@marvell.com> > --- > include/linux/qed/qed_if.h | 10 +++++----- > 1 file changed, 5 insertions(+), 5 deletions(-) > > diff --git a/include/linux/qed/qed_if.h b/include/linux/qed/qed_if.h > index 1297726f2b25..b8fb80c9be80 100644 > --- a/include/linux/qed/qed_if.h > +++ b/include/linux/qed/qed_if.h > @@ -897,14 +897,14 @@ struct qed_common_ops { > > void (*simd_handler_clean)(struct qed_dev *cdev, > int index); > - int (*dbg_grc)(struct qed_dev *cdev, > - void *buffer, u32 *num_dumped_bytes); > + int (*dbg_grc)(struct qed_dev *cdev, > + void *buffer, u32 *num_dumped_bytes); > > - int (*dbg_grc_size)(struct qed_dev *cdev); > + int (*dbg_grc_size)(struct qed_dev *cdev); > > - int (*dbg_all_data) (struct qed_dev *cdev, void *buffer); > + int (*dbg_all_data)(struct qed_dev *cdev, void *buffer); > > - int (*dbg_all_data_size) (struct qed_dev *cdev); > + int (*dbg_all_data_size)(struct qed_dev *cdev); > > int (*report_fatal_error)(struct devlink *devlink, > enum qed_hw_err_type err_type); Was there a reason to do the indenting? I would just replace this patch with unindenting everything. In general over time the time indent thing is unmaintainable and just generates inconsistency over time.
diff --git a/include/linux/qed/qed_if.h b/include/linux/qed/qed_if.h index 1297726f2b25..b8fb80c9be80 100644 --- a/include/linux/qed/qed_if.h +++ b/include/linux/qed/qed_if.h @@ -897,14 +897,14 @@ struct qed_common_ops { void (*simd_handler_clean)(struct qed_dev *cdev, int index); - int (*dbg_grc)(struct qed_dev *cdev, - void *buffer, u32 *num_dumped_bytes); + int (*dbg_grc)(struct qed_dev *cdev, + void *buffer, u32 *num_dumped_bytes); - int (*dbg_grc_size)(struct qed_dev *cdev); + int (*dbg_grc_size)(struct qed_dev *cdev); - int (*dbg_all_data) (struct qed_dev *cdev, void *buffer); + int (*dbg_all_data)(struct qed_dev *cdev, void *buffer); - int (*dbg_all_data_size) (struct qed_dev *cdev); + int (*dbg_all_data_size)(struct qed_dev *cdev); int (*report_fatal_error)(struct devlink *devlink, enum qed_hw_err_type err_type);