From patchwork Wed Aug 19 07:23:47 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 1347557 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming-netdev@ozlabs.org Delivered-To: patchwork-incoming-netdev@ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org (client-ip=23.128.96.18; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256 header.s=google header.b=dxRVNmi7; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by ozlabs.org (Postfix) with ESMTP id 4BWfT41GKtz9sPf for ; Wed, 19 Aug 2020 17:25:44 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727979AbgHSHZc (ORCPT ); Wed, 19 Aug 2020 03:25:32 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40966 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727835AbgHSHYt (ORCPT ); Wed, 19 Aug 2020 03:24:49 -0400 Received: from mail-wr1-x443.google.com (mail-wr1-x443.google.com [IPv6:2a00:1450:4864:20::443]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9777AC061362 for ; Wed, 19 Aug 2020 00:24:22 -0700 (PDT) Received: by mail-wr1-x443.google.com with SMTP id l2so20443789wrc.7 for ; Wed, 19 Aug 2020 00:24:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=bfE7YUSssid0azom0g6vClz47uYcy21+hGTRmt0JTBI=; b=dxRVNmi7LtW/7lmGHRjFCjuxQP1F9s/8kvSh4etZPkfq8exwIAqqPNFL0aK3SmVfDB fHrTrRMVtzuGPBrfz4+XBqHTclM6+fKesqjtjlM2VmRdsOTqBfwh5E+hUcfV6zwLp92b fH2nmZpRtlLMovLVRE2Q9NvPh5Gm4KCpaSZpkxEVqoFQX8WhvR+uCaJn+AOy2H2IRgBE idK19g+Z6/PGsCXH8WA1yRYhKbziLejExH4d1tqRZ3+3G4i2NlG5KHwpM2tG4KFI77hR IcGyMdysPTTn9rGjtpo4ymfWtopmI6cAdfums19zH6QW4KngP6oO2kQIIXzJgAvGGYUb Tb2w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=bfE7YUSssid0azom0g6vClz47uYcy21+hGTRmt0JTBI=; b=AUV2hoIozJS+iAaHopTo2/2kWKLSxb/KEnl66EpVQ9QatTctY8KWdppmdT5EIhhwFq kv1wP/v0laerJ4DtJhPCkustznCCJr/OA6C8KpZSR0uH8JtTzQ6XjoKHrxV+pPHN3ln+ 8OFx4kA5idNBack4h56xi2xzUkdjFnMnLZqRACaVtb33kALEkfsRK6W+Ic3a8c+fgElP xqQpCnF/ZV2o7OlhrdTmxLSaJuk+O/E+Sb+aeTA2k7Xa+jOUkfiML26CfFz8FIZJKCiJ 1S7VhMwFW+MCeeyn/0IeDSNZ5zYqy2MamSHN17fVie+D4Scw2QrndCilorT4pNmExC6u RHYw== X-Gm-Message-State: AOAM531sejlo+8CFXiMRVtEzuVoWf5HpbCl2nAwlEgC7ECHpl91oe/ng R3T75KdzNllv5zH7wnOYZLCcyUaf5qYsVQ== X-Google-Smtp-Source: ABdhPJzRWBnbNFHIjAgUYgqM4NWDUtxLUBkI0z4KY8VqkEYCch07riiASN+lmqbrHFo7MFbLN2tOzA== X-Received: by 2002:a5d:6401:: with SMTP id z1mr23375743wru.272.1597821861337; Wed, 19 Aug 2020 00:24:21 -0700 (PDT) Received: from dell.default ([95.149.164.62]) by smtp.gmail.com with ESMTPSA id c145sm3795808wmd.7.2020.08.19.00.24.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 19 Aug 2020 00:24:20 -0700 (PDT) From: Lee Jones To: kvalo@codeaurora.org, davem@davemloft.net, kuba@kernel.org Cc: linux-kernel@vger.kernel.org, linux-wireless@vger.kernel.org, netdev@vger.kernel.org, Lee Jones , Solomon Peachy , Dmitry Tarnyagin Subject: [PATCH 13/28] wireless: st: cw1200: wsm: Remove 'dummy' variables Date: Wed, 19 Aug 2020 08:23:47 +0100 Message-Id: <20200819072402.3085022-14-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200819072402.3085022-1-lee.jones@linaro.org> References: <20200819072402.3085022-1-lee.jones@linaro.org> MIME-Version: 1.0 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org They're never read, so there is no reason for them to exist. They just cause the compiler to complain. Fixes the following W=1 kernel build warning(s): drivers/net/wireless/st/cw1200/wsm.c: In function ‘wsm_ba_timeout_indication’: drivers/net/wireless/st/cw1200/wsm.c:1033:5: warning: variable ‘dummy2’ set but not used [-Wunused-but-set-variable] drivers/net/wireless/st/cw1200/wsm.c:1031:6: warning: variable ‘dummy’ set but not used [-Wunused-but-set-variable] Cc: Solomon Peachy Cc: Kalle Valo Cc: "David S. Miller" Cc: Jakub Kicinski Cc: Dmitry Tarnyagin Cc: linux-wireless@vger.kernel.org Cc: netdev@vger.kernel.org Signed-off-by: Lee Jones --- drivers/net/wireless/st/cw1200/wsm.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/net/wireless/st/cw1200/wsm.c b/drivers/net/wireless/st/cw1200/wsm.c index c86f31dcc9817..d9b6147bbb528 100644 --- a/drivers/net/wireless/st/cw1200/wsm.c +++ b/drivers/net/wireless/st/cw1200/wsm.c @@ -1028,14 +1028,12 @@ static int wsm_find_complete_indication(struct cw1200_common *priv, static int wsm_ba_timeout_indication(struct cw1200_common *priv, struct wsm_buf *buf) { - u32 dummy; u8 tid; - u8 dummy2; u8 addr[ETH_ALEN]; - dummy = WSM_GET32(buf); + WSM_GET32(buf); tid = WSM_GET8(buf); - dummy2 = WSM_GET8(buf); + WSM_GET8(buf); WSM_GET(buf, addr, ETH_ALEN); pr_info("BlockACK timeout, tid %d, addr %pM\n",