Message ID | 20200729113846.1551-4-irusskikh@marvell.com |
---|---|
State | Changes Requested |
Delegated to: | David Miller |
Headers | show |
Series | qed: introduce devlink health support | expand |
Wed, Jul 29, 2020 at 01:38:38PM CEST, irusskikh@marvell.com wrote: >In theory that could lead to race condition Describe the problem, tell the codebase what to do. Plus, this looks like a -net material. Please consider pushing this separatelly with proper "fixes" tag. > >Signed-off-by: Igor Russkikh <irusskikh@marvell.com> >Signed-off-by: Alexander Lobakin <alobakin@marvell.com> >Signed-off-by: Michal Kalderon <michal.kalderon@marvell.com> >--- > drivers/net/ethernet/qlogic/qed/qed_devlink.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/drivers/net/ethernet/qlogic/qed/qed_devlink.c b/drivers/net/ethernet/qlogic/qed/qed_devlink.c >index a62c47c61edf..4e3316c6beb6 100644 >--- a/drivers/net/ethernet/qlogic/qed/qed_devlink.c >+++ b/drivers/net/ethernet/qlogic/qed/qed_devlink.c >@@ -75,8 +75,8 @@ struct devlink *qed_devlink_register(struct qed_dev *cdev) > QED_DEVLINK_PARAM_ID_IWARP_CMT, > value); > >- devlink_params_publish(dl); > cdev->iwarp_cmt = false; >+ devlink_params_publish(dl); > > return dl; > >-- >2.17.1 >
diff --git a/drivers/net/ethernet/qlogic/qed/qed_devlink.c b/drivers/net/ethernet/qlogic/qed/qed_devlink.c index a62c47c61edf..4e3316c6beb6 100644 --- a/drivers/net/ethernet/qlogic/qed/qed_devlink.c +++ b/drivers/net/ethernet/qlogic/qed/qed_devlink.c @@ -75,8 +75,8 @@ struct devlink *qed_devlink_register(struct qed_dev *cdev) QED_DEVLINK_PARAM_ID_IWARP_CMT, value); - devlink_params_publish(dl); cdev->iwarp_cmt = false; + devlink_params_publish(dl); return dl;