| Message ID | 20200727221952.6659-1-jacob.e.keller@intel.com |
|---|---|
| State | Superseded |
| Delegated to: | Michal Kubecek |
| Headers | show |
| Series | [ethtool] ethtool: use "Not reported" when no FEC modes are provided | expand |
diff --git a/netlink/settings.c b/netlink/settings.c index 29557653336e..5616cb2f7b6f 100644 --- a/netlink/settings.c +++ b/netlink/settings.c @@ -473,7 +473,7 @@ static int dump_peer_modes(struct nl_context *nlctx, const struct nlattr *attr) ret = dump_link_modes(nlctx, attr, true, LM_CLASS_FEC, "Link partner advertised FEC modes: ", - " ", "\n", "No"); + " ", "\n", "Not reported"); return ret; }
When displaying the FEC link modes advertised by the peer, we used the string "No" to indicate when nothing was provided. This does not match the IOCTL output which indicates "Not reported". It also doesn't match the local advertised FEC modes, which also used the "Not reported" string. This is especially confusing for FEC, because the FEC bits include a "None" bit which indicates that FEC is definitely not supported. Avoid this confusion and match both the local advertised settings display and the old IOCTL output by using "Not reported" when FEC settings aren't reported. Reported-by: Andrew Lunn <andrew@lunn.ch> Signed-off-by: Jacob Keller <jacob.e.keller@intel.com> --- netlink/settings.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)