diff mbox

[net-next,v7,0/6] ACPI support for dpaa2 MAC driver.

Message ID 20200725142404.30634-1-calvin.johnson@oss.nxp.com
State Changes Requested
Delegated to: David Miller
Headers show

Commit Message

Calvin Johnson July 25, 2020, 2:23 p.m. UTC 
This patch series provides ACPI support for dpaa2 MAC driver.
 This also introduces ACPI mechanism to get PHYs registered on a
 MDIO bus and provide them to be connected to MAC.

 Previous discussions on this patchset is available at:
 https://lore.kernel.org/linux-acpi/20200715090400.4733-1-calvin.johnson@oss.nxp.com/T/#t

 Patch "net: dpaa2-mac: Add ACPI support for DPAA2 MAC driver" depends on
 https://git.kernel.org/pub/scm/linux/kernel/git/lpieralisi/linux.git/commit/?h=acpi/for-next&id=c279c4cf5bcd3c55b4fb9709d9036cd1bfe3beb8
 Remaining patches are independent of the above patch and can be applied without
 any issues.

 Device Tree can be tested on LX2160A-RDB with the below change which is also
available in the above referenced patches:


Changes in v7:
- remove unnecessary -ve check for u32 var
- assign flags to phy_dev

Changes in v6:
- change device_mdiobus_register() parameter position
- improve documentation
- change device_mdiobus_register() parameter position
- clean up phylink_fwnode_phy_connect()

Changes in v5:
- add description
- clean up if else
- rename phy_find_by_fwnode() to phy_find_by_mdio_handle()
- add docment for phy_find_by_mdio_handle()
- error out DT in phy_find_by_mdio_handle()
- clean up err return
- return -EINVAL for invalid fwnode

Changes in v4:
- release fwnode_mdio after use
- return ERR_PTR instead of NULL
- introduce device_mdiobus_register()

Changes in v3:
- cleanup based on v2 comments
- Added description for more properties
- Added MDIO node DSDT entry
- introduce fwnode_mdio_find_bus()
- renamed and improved phy_find_by_fwnode()
- cleanup based on v2 comments
- move code into phylink_fwnode_phy_connect()

Changes in v2:
- clean up dpaa2_mac_get_node()
- introduce find_phy_device()
- use acpi_find_child_device()

Calvin Johnson (6):
  Documentation: ACPI: DSD: Document MDIO PHY
  net: phy: introduce device_mdiobus_register()
  net/fsl: use device_mdiobus_register()
  net: phy: introduce phy_find_by_mdio_handle()
  phylink: introduce phylink_fwnode_phy_connect()
  net: dpaa2-mac: Add ACPI support for DPAA2 MAC driver

 Documentation/firmware-guide/acpi/dsd/phy.rst | 90 +++++++++++++++++++
 .../net/ethernet/freescale/dpaa2/dpaa2-mac.c  | 70 ++++++++-------
 drivers/net/ethernet/freescale/xgmac_mdio.c   |  3 +-
 drivers/net/phy/mdio_bus.c                    | 51 +++++++++++
 drivers/net/phy/phy_device.c                  | 40 +++++++++
 drivers/net/phy/phylink.c                     | 32 +++++++
 include/linux/mdio.h                          |  1 +
 include/linux/phy.h                           |  2 +
 include/linux/phylink.h                       |  3 +
 9 files changed, 260 insertions(+), 32 deletions(-)
 create mode 100644 Documentation/firmware-guide/acpi/dsd/phy.rst

Comments

David Miller July 29, 2020, 12:39 a.m. UTC | #1 
From: Calvin Johnson <calvin.johnson@oss.nxp.com>
Date: Sat, 25 Jul 2020 19:53:58 +0530

>  This patch series provides ACPI support for dpaa2 MAC driver.
>  This also introduces ACPI mechanism to get PHYs registered on a
>  MDIO bus and provide them to be connected to MAC.
> 
>  Previous discussions on this patchset is available at:
>  https://lore.kernel.org/linux-acpi/20200715090400.4733-1-calvin.johnson@oss.nxp.com/T/#t
> 
>  Patch "net: dpaa2-mac: Add ACPI support for DPAA2 MAC driver" depends on
>  https://git.kernel.org/pub/scm/linux/kernel/git/lpieralisi/linux.git/commit/?h=acpi/for-next&id=c279c4cf5bcd3c55b4fb9709d9036cd1bfe3beb8
>  Remaining patches are independent of the above patch and can be applied without
>  any issues.

This really needs to be reviewed by phy/phylink people.

>  Device Tree can be tested on LX2160A-RDB with the below change which is also
> available in the above referenced patches:
> 
> --- a/drivers/bus/fsl-mc/fsl-mc-bus.c
> +++ b/drivers/bus/fsl-mc/fsl-mc-bus.c
> @@ -931,6 +931,7 @@ static int fsl_mc_bus_probe(struct platform_device *pdev)
>         if (error < 0)
>                 goto error_cleanup_mc_io;
> 
> +       mc_bus_dev->dev.fwnode = pdev->dev.fwnode;
>         mc->root_mc_bus_dev = mc_bus_dev;
>         return 0;

I don't know how you expect me to handle this dependency in the networking
tree.
Florian Fainelli July 29, 2020, 12:42 a.m. UTC | #2 
On 7/28/2020 5:39 PM, David Miller wrote:
> From: Calvin Johnson <calvin.johnson@oss.nxp.com>
> Date: Sat, 25 Jul 2020 19:53:58 +0530
> 
>>  This patch series provides ACPI support for dpaa2 MAC driver.
>>  This also introduces ACPI mechanism to get PHYs registered on a
>>  MDIO bus and provide them to be connected to MAC.
>>
>>  Previous discussions on this patchset is available at:
>>  https://lore.kernel.org/linux-acpi/20200715090400.4733-1-calvin.johnson@oss.nxp.com/T/#t
>>
>>  Patch "net: dpaa2-mac: Add ACPI support for DPAA2 MAC driver" depends on
>>  https://git.kernel.org/pub/scm/linux/kernel/git/lpieralisi/linux.git/commit/?h=acpi/for-next&id=c279c4cf5bcd3c55b4fb9709d9036cd1bfe3beb8
>>  Remaining patches are independent of the above patch and can be applied without
>>  any issues.
> 
> This really needs to be reviewed by phy/phylink people.

Oh it has been reviewed! We just have stalled for various reasons. There
is another email thread with the same subject which is still being
discussed:

https://lore.kernel.org/netdev/20200715090400.4733-1-calvin.johnson@oss.nxp.com/T/#t
diff mbox

Patch

--- a/drivers/bus/fsl-mc/fsl-mc-bus.c
+++ b/drivers/bus/fsl-mc/fsl-mc-bus.c
@@ -931,6 +931,7 @@  static int fsl_mc_bus_probe(struct platform_device *pdev)
        if (error < 0)
                goto error_cleanup_mc_io;

+       mc_bus_dev->dev.fwnode = pdev->dev.fwnode;
        mc->root_mc_bus_dev = mc_bus_dev;
        return 0;