| Message ID | 20200722113752.1218-1-vincent.ldev@duvert.net |
|---|---|
| State | Changes Requested |
| Delegated to: | David Miller |
| Headers | show |
| Series | [1/2] appletalk: Fix atalk_proc_init return path | expand |
From: Vincent Duvert <vincent.ldev@duvert.net> Date: Wed, 22 Jul 2020 13:37:51 +0200 > Add a missing return statement to atalk_proc_init so it doesn't return > -ENOMEM when successful. This allows the appletalk module to load > properly. > > Signed-off-by: Vincent Duvert <vincent.ldev@duvert.net> Need an appropriate "Fixes: " tag here, if the module hasn't loaded it means nobody has been using it at all.
diff --git a/net/appletalk/atalk_proc.c b/net/appletalk/atalk_proc.c index 550c6ca007cc..9c1241292d1d 100644 --- a/net/appletalk/atalk_proc.c +++ b/net/appletalk/atalk_proc.c @@ -229,6 +229,8 @@ int __init atalk_proc_init(void) sizeof(struct aarp_iter_state), NULL)) goto out; + return 0; + out: remove_proc_subtree("atalk", init_net.proc_net); return -ENOMEM;
Add a missing return statement to atalk_proc_init so it doesn't return -ENOMEM when successful. This allows the appletalk module to load properly. Signed-off-by: Vincent Duvert <vincent.ldev@duvert.net> --- net/appletalk/atalk_proc.c | 2 ++ 1 file changed, 2 insertions(+)