diff mbox series

[bpf-next] tools/bpftool: strip BPF .o files before skeleton generation

Message ID 20200722043804.2373298-1-andriin@fb.com
State Accepted
Delegated to: BPF Maintainers
Headers show
Series [bpf-next] tools/bpftool: strip BPF .o files before skeleton generation | expand

Commit Message

Andrii Nakryiko July 22, 2020, 4:38 a.m. UTC
Strip away DWARF info from .bpf.o files, before generating BPF skeletons.
This reduces bpftool binary size from 3.43MB to 2.58MB.

Signed-off-by: Andrii Nakryiko <andriin@fb.com>
---
 tools/bpf/bpftool/Makefile | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

Comments

Quentin Monnet July 22, 2020, 8:20 a.m. UTC | #1
On 22/07/2020 05:38, Andrii Nakryiko wrote:
> Strip away DWARF info from .bpf.o files, before generating BPF skeletons.
> This reduces bpftool binary size from 3.43MB to 2.58MB.
> 
> Signed-off-by: Andrii Nakryiko <andriin@fb.com>
Acked-by: Quentin Monnet <quentin@isovalent.com>
Alexei Starovoitov July 23, 2020, 5:10 a.m. UTC | #2
On Wed, Jul 22, 2020 at 1:21 AM Quentin Monnet <quentin@isovalent.com> wrote:
>
> On 22/07/2020 05:38, Andrii Nakryiko wrote:
> > Strip away DWARF info from .bpf.o files, before generating BPF skeletons.
> > This reduces bpftool binary size from 3.43MB to 2.58MB.
> >
> > Signed-off-by: Andrii Nakryiko <andriin@fb.com>
> Acked-by: Quentin Monnet <quentin@isovalent.com>

Applied. Thanks
diff mbox series

Patch

diff --git a/tools/bpf/bpftool/Makefile b/tools/bpf/bpftool/Makefile
index 51bd520ed437..8462690a039b 100644
--- a/tools/bpf/bpftool/Makefile
+++ b/tools/bpf/bpftool/Makefile
@@ -59,6 +59,7 @@  endif
 INSTALL ?= install
 RM ?= rm -f
 CLANG ?= clang
+LLVM_STRIP ?= llvm-strip
 
 FEATURE_USER = .bpftool
 FEATURE_TESTS = libbfd disassembler-four-args reallocarray zlib libcap \
@@ -147,7 +148,7 @@  $(OUTPUT)%.bpf.o: skeleton/%.bpf.c $(OUTPUT)vmlinux.h $(LIBBPF)
 		-I$(srctree)/tools/include/uapi/ \
 		-I$(LIBBPF_PATH) \
 		-I$(srctree)/tools/lib \
-		-g -O2 -target bpf -c $< -o $@
+		-g -O2 -target bpf -c $< -o $@ && $(LLVM_STRIP) -g $@
 
 $(OUTPUT)%.skel.h: $(OUTPUT)%.bpf.o $(BPFTOOL_BOOTSTRAP)
 	$(QUIET_GEN)$(BPFTOOL_BOOTSTRAP) gen skeleton $< > $@