diff mbox series

[16/29] l2tp: fix up incorrect comment in l2tp_recv_common

Message ID	20200721173221.4681-17-tparkin@katalix.com
State	Changes Requested
Delegated to:	David Miller
Headers	show Return-Path: <netdev-owner@vger.kernel.org> sender: tom) by mail.katalix.com (Postfix) with ESMTPSA id 8784393B00; Tue, 21 Jul 2020 18:33:01 +0100 (BST) From: Tom Parkin <tparkin@katalix.com> To: netdev@vger.kernel.org Cc: Tom Parkin <tparkin@katalix.com> Subject: [PATCH 16/29] l2tp: fix up incorrect comment in l2tp_recv_common Date: Tue, 21 Jul 2020 18:32:08 +0100 Message-Id: <20200721173221.4681-17-tparkin@katalix.com> In-Reply-To: <20200721173221.4681-1-tparkin@katalix.com> References: <20200721173221.4681-1-tparkin@katalix.com> Sender: netdev-owner@vger.kernel.org Precedence: bulk
Series	l2tp: cleanup checkpatch.pl warnings \| expand [net-next,00/29] l2tp: cleanup checkpatch.pl warnings [01/29] l2tp: cleanup whitespace around operators [02/29] l2tp: tweak comment style for consistency [03/29] l2tp: add a blank line following declarations [04/29] l2tp: cleanup excessive blank lines [05/29] l2tp: cleanup difficult-to-read line breaks [06/29] l2tp: cleanup wonky alignment of line-broken function calls [07/29] l2tp: cleanup suspect code indent [08/29] l2tp: add identifier name in function pointer prototype [09/29] l2tp: prefer using BIT macro [10/29] l2tp: cleanup comparisons to NULL [11/29] l2tp: cleanup unnecessary braces in if statements [12/29] l2tp: prefer seq_puts for unformatted output [13/29] l2tp: avoid multiple assignments [14/29] l2tp: line-break long function prototypes [15/29] l2tp: comment per net spinlock instances [16/29] l2tp: fix up incorrect comment in l2tp_recv_common [17/29] l2tp: avoid precidence issues in L2TP_SKB_CB macro [18/29] l2tp: WARN_ON rather than BUG_ON in l2tp_debugfs.c [19/29] l2tp: use a function to render tunnel address in l2tp_debugfs [20/29] l2tp: cleanup netlink send of tunnel address information [21/29] l2tp: cleanup netlink tunnel create address handling [22/29] l2tp: cleanup kzalloc calls [23/29] l2tp: remove BUG_ON in l2tp_session_queue_purge [24/29] l2tp: remove BUG_ON in l2tp_tunnel_closeall [25/29] l2tp: don't BUG_ON session magic checks in l2tp_ppp [26/29] l2tp: don't BUG_ON seqfile checks in l2tp_ppp [27/29] l2tp: WARN_ON rather than BUG_ON in l2tp_session_queue_purge [28/29] l2tp: remove BUG_ON refcount value in l2tp_session_free [29/29] l2tp: WARN_ON rather than BUG_ON in l2tp_session_free

Commit Message

Tom Parkin July 21, 2020, 5:32 p.m. UTC

RFC2661 section 5.4 states that:

"The LNS controls enabling and disabling of sequence numbers by sending a
data message with or without sequence numbers present at any time during
the life of a session."

l2tp handles this correctly in l2tp_recv_common, but the comment around
the code was incorrect and confusing.  Fix up the comment accordingly.

Signed-off-by: Tom Parkin <tparkin@katalix.com>
---
 net/l2tp/l2tp_core.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff mbox series

Patch

diff --git a/net/l2tp/l2tp_core.c b/net/l2tp/l2tp_core.c
index 182386ad20e2..177accb01993 100644
--- a/net/l2tp/l2tp_core.c
+++ b/net/l2tp/l2tp_core.c
@@ -678,7 +678,7 @@  void l2tp_recv_common(struct l2tp_session *session, struct sk_buff *skb,
 	}
 
 	if (L2TP_SKB_CB(skb)->has_seq) {
-		/* Received a packet with sequence numbers. If we're the LNS,
+		/* Received a packet with sequence numbers. If we're the LAC,
 		 * check if we sre sending sequence numbers and if not,
 		 * configure it so.
 		 */