| Message ID | 20200720014614.11951-1-huangguobin4@huawei.com |
|---|---|
| State | Accepted |
| Delegated to: | David Miller |
| Headers | show |
| Series | net: ag71xx: add missed clk_disable_unprepare in error path of probe | expand |
From: Huang Guobin <huangguobin4@huawei.com> Date: Sun, 19 Jul 2020 21:46:14 -0400 > The ag71xx_mdio_probe() forgets to call clk_disable_unprepare() when > of_reset_control_get_exclusive() failed. Add the missed call to fix it. > > Fixes: d51b6ce441d3 ("net: ethernet: add ag71xx driver") > Reported-by: Hulk Robot <hulkci@huawei.com> > Signed-off-by: Huang Guobin <huangguobin4@huawei.com> Applied, thanks.
diff --git a/drivers/net/ethernet/atheros/ag71xx.c b/drivers/net/ethernet/atheros/ag71xx.c index 112edbd30823..38cce66ef212 100644 --- a/drivers/net/ethernet/atheros/ag71xx.c +++ b/drivers/net/ethernet/atheros/ag71xx.c @@ -556,7 +556,8 @@ static int ag71xx_mdio_probe(struct ag71xx *ag) ag->mdio_reset = of_reset_control_get_exclusive(np, "mdio"); if (IS_ERR(ag->mdio_reset)) { netif_err(ag, probe, ndev, "Failed to get reset mdio.\n"); - return PTR_ERR(ag->mdio_reset); + err = PTR_ERR(ag->mdio_reset); + goto mdio_err_put_clk; } mii_bus->name = "ag71xx_mdio";
The ag71xx_mdio_probe() forgets to call clk_disable_unprepare() when of_reset_control_get_exclusive() failed. Add the missed call to fix it. Fixes: d51b6ce441d3 ("net: ethernet: add ag71xx driver") Reported-by: Hulk Robot <hulkci@huawei.com> Signed-off-by: Huang Guobin <huangguobin4@huawei.com> --- drivers/net/ethernet/atheros/ag71xx.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)