From patchwork Thu Jul 16 17:32:47 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bixuan Cui X-Patchwork-Id: 1330110 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming-netdev@ozlabs.org Delivered-To: patchwork-incoming-netdev@ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org (client-ip=23.128.96.18; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=huawei.com Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by ozlabs.org (Postfix) with ESMTP id 4B6psl4Vrsz9sRN for ; Thu, 16 Jul 2020 19:31:23 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727038AbgGPJbT (ORCPT ); Thu, 16 Jul 2020 05:31:19 -0400 Received: from szxga07-in.huawei.com ([45.249.212.35]:51958 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726769AbgGPJbS (ORCPT ); Thu, 16 Jul 2020 05:31:18 -0400 Received: from DGGEMS411-HUB.china.huawei.com (unknown [172.30.72.60]) by Forcepoint Email with ESMTP id 8601BF5814DDACD0A27C; Thu, 16 Jul 2020 17:31:15 +0800 (CST) Received: from huawei.com (10.174.28.241) by DGGEMS411-HUB.china.huawei.com (10.3.19.211) with Microsoft SMTP Server id 14.3.487.0; Thu, 16 Jul 2020 17:31:09 +0800 From: Bixuan Cui To: , , CC: , , , , Subject: [PATCH] net: neterion: vxge: reduce stack usage in VXGE_COMPLETE_VPATH_TX Date: Thu, 16 Jul 2020 17:32:47 +0000 Message-ID: <20200716173247.78912-1-cuibixuan@huawei.com> X-Mailer: git-send-email 2.17.1 MIME-Version: 1.0 X-Originating-IP: [10.174.28.241] X-CFilter-Loop: Reflected Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Fix the warning: [-Werror=-Wframe-larger-than=] drivers/net/ethernet/neterion/vxge/vxge-main.c: In function'VXGE_COMPLETE_VPATH_TX.isra.37': drivers/net/ethernet/neterion/vxge/vxge-main.c:119:1: warning: the frame size of 1056 bytes is larger than 1024 bytes Signed-off-by: Bixuan Cui Reported-by: kernel test robot Reported-by: kernel test robot --- drivers/net/ethernet/neterion/vxge/vxge-main.c | 8 ++++++++ 1 file changed, 8 insertions(+) -- 2.17.1 diff --git a/drivers/net/ethernet/neterion/vxge/vxge-main.c b/drivers/net/ethernet/neterion/vxge/vxge-main.c index b0faa737b817..97ddfc9debd4 100644 --- a/drivers/net/ethernet/neterion/vxge/vxge-main.c +++ b/drivers/net/ethernet/neterion/vxge/vxge-main.c @@ -100,8 +100,14 @@ static inline void VXGE_COMPLETE_VPATH_TX(struct vxge_fifo *fifo) struct sk_buff **temp; #define NR_SKB_COMPLETED 128 struct sk_buff *completed[NR_SKB_COMPLETED]; + struct sk_buff **completed; int more; + completed = kcalloc(NR_SKB_COMPLETED, sizeof(*completed), + GFP_KERNEL); + if (!completed) + return; + do { more = 0; skb_ptr = completed; @@ -116,6 +122,8 @@ static inline void VXGE_COMPLETE_VPATH_TX(struct vxge_fifo *fifo) for (temp = completed; temp != skb_ptr; temp++) dev_consume_skb_irq(*temp); } while (more); + + free(completed); } static inline void VXGE_COMPLETE_ALL_TX(struct vxgedev *vdev)