From patchwork Tue Jul 14 19:41:17 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Suraj Upadhyay X-Patchwork-Id: 1329073 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming-netdev@ozlabs.org Delivered-To: patchwork-incoming-netdev@ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org (client-ip=23.128.96.18; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20161025 header.b=U4GSwduR; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by ozlabs.org (Postfix) with ESMTP id 4B5rVj5q9Mz9sRf for ; Wed, 15 Jul 2020 05:41:33 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730136AbgGNTlc (ORCPT ); Tue, 14 Jul 2020 15:41:32 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46994 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729465AbgGNTlb (ORCPT ); Tue, 14 Jul 2020 15:41:31 -0400 Received: from mail-pl1-x642.google.com (mail-pl1-x642.google.com [IPv6:2607:f8b0:4864:20::642]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 98BFCC061755; Tue, 14 Jul 2020 12:41:30 -0700 (PDT) Received: by mail-pl1-x642.google.com with SMTP id k5so7428106plk.13; Tue, 14 Jul 2020 12:41:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:mime-version:content-disposition :user-agent; bh=niAIjn+Een/amQTg5fN18KJRwMOstxeUEV0t203OE2I=; b=U4GSwduRBIN/yTj+kSe1e3FhlYu/eU+cNd3YvmhAgwNpYObKc0ECpYaCaH/2CfjvbC IpqBWb44SwRTcVaIf1U3pUOENQcwd2PTZYbEDJTHLSpmuY0BGenZJkq4l2PIrR89ANoB KbkmGpnvSUb4wdeuAZQFz0x/z6xk61MwIgK+JTRIyzEYluvVUM7IaXpHFL2F17LFh1/s npt0w4UMgdTBr3F3ba5j6MX2kRR8wzeANYFiwaXeHBQjb1+62g/LcMhLNBdJcZI0CVby DwwZcRJTa6pQoanI2h7/ji6UxrcUQ7/VHgftXOKvybMx/C5wwtuPZGGddVHWEolYWzsl Gupw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:mime-version :content-disposition:user-agent; bh=niAIjn+Een/amQTg5fN18KJRwMOstxeUEV0t203OE2I=; b=SUnl8mtgfjIHzPTeWNe0BFJF8+7V6wqJduFqwd1pWlXgBSCDv7U78dxxodJ/d5eILY 9JZus02DTRizUdUBgeuUFDTU/4CtxP5oBnSg0oSkwzohJ2VgGKlCQjHNVcCjHaIsOdpG IT0ZSrwVoAJapSzzQAv3kkjsWIkypFxQFmBpnnezQgTvOEjbljZZvEkfrXqBqrK6se45 s8TxSo2wJp7fDiC7bWnvwMNVA1iHYj7iQ86uvHd0E8N9aX9MXrVMEO5XS6i+uEmCyy2w mG3+ogD3UfW+3RRsTPrc/fD2D1gO9M90TyMvw5UKngNI+eCC8Jqdat49O3ykQ1ygDHWP 7scg== X-Gm-Message-State: AOAM531XZN5jn0j20THUqq76qL8o48LI6gcOyNQAI3sM1UABGpI02sJ5 MNizwmRgmFRKvjMFSPOMLKk= X-Google-Smtp-Source: ABdhPJxnqN8nrX9Fqfy1W5R/qQtza/2Q/DP10I0i1HHBCyZOqj/LDHNKzVdELgVVBxO9fEp/MDav7g== X-Received: by 2002:a17:90a:72c7:: with SMTP id l7mr6645940pjk.34.1594755690151; Tue, 14 Jul 2020 12:41:30 -0700 (PDT) Received: from blackclown ([103.88.82.145]) by smtp.gmail.com with ESMTPSA id r204sm9234pfc.134.2020.07.14.12.41.27 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Tue, 14 Jul 2020 12:41:29 -0700 (PDT) Date: Wed, 15 Jul 2020 01:11:17 +0530 From: Suraj Upadhyay To: jeffrey.t.kirsher@intel.com, davem@davemloft.net, kuba@kernel.org Cc: intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: [PATCH 2/4] e1000e/ethtool.c : Remove unnecessary usages of memset. Message-ID: <20200714194117.GA21460@blackclown> MIME-Version: 1.0 Content-Disposition: inline User-Agent: Mutt/1.9.4 (2018-02-28) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Replace memsets of 1 byte with simple assignments. Issue found with checkpatch.pl Signed-off-by: Suraj Upadhyay Tested-by: Aaron Brown --- drivers/net/ethernet/intel/e1000e/ethtool.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/intel/e1000e/ethtool.c b/drivers/net/ethernet/intel/e1000e/ethtool.c index 64f684dc6c7a..a8fc9208382c 100644 --- a/drivers/net/ethernet/intel/e1000e/ethtool.c +++ b/drivers/net/ethernet/intel/e1000e/ethtool.c @@ -1608,8 +1608,8 @@ static void e1000_create_lbtest_frame(struct sk_buff *skb, memset(skb->data, 0xFF, frame_size); frame_size &= ~1; memset(&skb->data[frame_size / 2], 0xAA, frame_size / 2 - 1); - memset(&skb->data[frame_size / 2 + 10], 0xBE, 1); - memset(&skb->data[frame_size / 2 + 12], 0xAF, 1); + skb->data[frame_size / 2 + 10] = 0xBE; + skb->data[frame_size / 2 + 12] = 0xAF; } static int e1000_check_lbtest_frame(struct sk_buff *skb,