From patchwork Fri Jul 10 10:48:51 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Michael S. Tsirkin" X-Patchwork-Id: 1326666 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming-netdev@ozlabs.org Delivered-To: patchwork-incoming-netdev@ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org (client-ip=23.128.96.18; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=Q37RqgVc; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by ozlabs.org (Postfix) with ESMTP id 4B38t74R1vz9sRf for ; Fri, 10 Jul 2020 20:49:03 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727972AbgGJKtB (ORCPT ); Fri, 10 Jul 2020 06:49:01 -0400 Received: from us-smtp-1.mimecast.com ([205.139.110.61]:58565 "EHLO us-smtp-delivery-1.mimecast.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1727844AbgGJKs7 (ORCPT ); Fri, 10 Jul 2020 06:48:59 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1594378138; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type; bh=zH+SoJc9FA+IxVxr5cux+vmHnM4kK2aczPlNcB2fA0g=; b=Q37RqgVcmwwRjMj8YY6e242GmgmvfcC0qz4RP+3xfdiupWGOX2Hy3GL4O4FhIxJGNFfyL3 4yU1aiMCrrCy3SBQ4GIgg0uajasKvfDM1toF4uwJrK36gJCt1jgWPPeZzkDq6Z6JkbBSCk f9fW9aKl714PM4yysr1SWkBF6VGFsA4= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-434-v9DqpnYsMwK0n7rn9QvFMw-1; Fri, 10 Jul 2020 06:48:55 -0400 X-MC-Unique: v9DqpnYsMwK0n7rn9QvFMw-1 Received: by mail-wm1-f71.google.com with SMTP id b13so6331691wme.9 for ; Fri, 10 Jul 2020 03:48:55 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:mime-version :content-disposition; bh=zH+SoJc9FA+IxVxr5cux+vmHnM4kK2aczPlNcB2fA0g=; b=YMAh7/2whAC6lNlqZBvIhp2qik1gkZHWAV/God/2luhZXz4gBo+DnRHCrdeteVU8ze UDo0EdjBGkdifcgiyDxLas6zA60AMsCdrKwkJAg4fPkYaqCt2E/SoSx7tSSC27rYhNvB auU7WCR6Iiw5RxwcYb3Blx5CwOuP2vK2j4Q2Kh/hZipDHvvwseXgk8djqoX3aNDzoxeH vf8TF6jNS13akSSiXytYlsH5tduJB8nm+ixcCiSSLmlFuSL0HSgWhJINq7jj/2t+BX0P yPo6Y/AlDAw5snEe7r33ohIm2X7fk57dxrSxvVXrs8zpn71K8/RRdmUIep+8pKLz8wvv Em+g== X-Gm-Message-State: AOAM531OsvqzOvUXVcni0mfUGNs9tPabV8qMnjYg1sBqCCX2cTmhjb1G DRc4WynhwdInc3v0mYqvj+3HXa7nPfL36uK8BvNz1CqFXQq1YnMwGhU9i5QLDYWhk+dFHutQvDy NjIX3Kz9pwL4wAZEX X-Received: by 2002:a05:6000:1143:: with SMTP id d3mr55214239wrx.235.1594378134132; Fri, 10 Jul 2020 03:48:54 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyw4fIgUrx6Lb8RIpTWJ39EeNc2fRHHzE0+AdkrVCaNR8Aj75HUF42WJR8yehI/TNv6QqsbOQ== X-Received: by 2002:a05:6000:1143:: with SMTP id d3mr55214221wrx.235.1594378133933; Fri, 10 Jul 2020 03:48:53 -0700 (PDT) Received: from redhat.com (bzq-79-182-31-92.red.bezeqint.net. [79.182.31.92]) by smtp.gmail.com with ESMTPSA id 68sm8898710wmz.40.2020.07.10.03.48.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 10 Jul 2020 03:48:53 -0700 (PDT) Date: Fri, 10 Jul 2020 06:48:51 -0400 From: "Michael S. Tsirkin" To: linux-kernel@vger.kernel.org Cc: stable@vger.kernel.org, Jason Wang , Paolo Bonzini , Stefan Hajnoczi , virtualization@lists.linux-foundation.org, kvm@vger.kernel.org, netdev@vger.kernel.org Subject: [PATCH] vhost/scsi: fix up req type endian-ness Message-ID: <20200710104849.406023-1-mst@redhat.com> MIME-Version: 1.0 Content-Disposition: inline X-Mailer: git-send-email 2.27.0.106.g8ac3dc51b1 X-Mutt-Fcc: =sent Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org vhost/scsi doesn't handle type conversion correctly for request type when using virtio 1.0 and up for BE, or cross-endian platforms. Fix it up using vhost_32_to_cpu. Cc: stable@vger.kernel.org Signed-off-by: Michael S. Tsirkin Acked-by: Jason Wang Reviewed-by: Stefan Hajnoczi --- drivers/vhost/scsi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/vhost/scsi.c b/drivers/vhost/scsi.c index 6fb4d7ecfa19..b22adf03f584 100644 --- a/drivers/vhost/scsi.c +++ b/drivers/vhost/scsi.c @@ -1215,7 +1215,7 @@ vhost_scsi_ctl_handle_vq(struct vhost_scsi *vs, struct vhost_virtqueue *vq) continue; } - switch (v_req.type) { + switch (vhost32_to_cpu(vq, v_req.type)) { case VIRTIO_SCSI_T_TMF: vc.req = &v_req.tmf; vc.req_size = sizeof(struct virtio_scsi_ctrl_tmf_req);