| Message ID | 20200708072401.169150-3-joyce.ooi@intel.com |
|---|---|
| State | Changes Requested |
| Delegated to: | David Miller |
| Headers | show |
| Series | net: eth: altera: tse: Add PTP and mSGDMA prefetcher | expand |
On 7/8/20 2:23 AM, Ooi, Joyce wrote: > From: Dalon Westergreen <dalon.westergreen@intel.com> > > It is more appropriate to set the rx and tx ring size before calling > the init function for the dma. > > Signed-off-by: Dalon Westergreen <dalon.westergreen@intel.com> > Signed-off-by: Joyce Ooi <joyce.ooi@intel.com> > --- > v2: no change > v3: no change > v4: no change > --- > drivers/net/ethernet/altera/altera_tse_main.c | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/drivers/net/ethernet/altera/altera_tse_main.c b/drivers/net/ethernet/altera/altera_tse_main.c > index ec2b36e05c3f..a3749ffdcac9 100644 > --- a/drivers/net/ethernet/altera/altera_tse_main.c > +++ b/drivers/net/ethernet/altera/altera_tse_main.c > @@ -1154,6 +1154,10 @@ static int tse_open(struct net_device *dev) > int i; > unsigned long int flags; > > + /* set tx and rx ring size */ > + priv->rx_ring_size = dma_rx_num; > + priv->tx_ring_size = dma_tx_num; > + > /* Reset and configure TSE MAC and probe associated PHY */ > ret = priv->dmaops->init_dma(priv); > if (ret != 0) { > @@ -1196,8 +1200,6 @@ static int tse_open(struct net_device *dev) > priv->dmaops->reset_dma(priv); > > /* Create and initialize the TX/RX descriptors chains. */ > - priv->rx_ring_size = dma_rx_num; > - priv->tx_ring_size = dma_tx_num; > ret = alloc_init_skbufs(priv); > if (ret) { > netdev_err(dev, "DMA descriptors initialization failed\n"); > Reviewed-by: Thor Thayer <thor.thayer@linux.intel.com>
diff --git a/drivers/net/ethernet/altera/altera_tse_main.c b/drivers/net/ethernet/altera/altera_tse_main.c index ec2b36e05c3f..a3749ffdcac9 100644 --- a/drivers/net/ethernet/altera/altera_tse_main.c +++ b/drivers/net/ethernet/altera/altera_tse_main.c @@ -1154,6 +1154,10 @@ static int tse_open(struct net_device *dev) int i; unsigned long int flags; + /* set tx and rx ring size */ + priv->rx_ring_size = dma_rx_num; + priv->tx_ring_size = dma_tx_num; + /* Reset and configure TSE MAC and probe associated PHY */ ret = priv->dmaops->init_dma(priv); if (ret != 0) { @@ -1196,8 +1200,6 @@ static int tse_open(struct net_device *dev) priv->dmaops->reset_dma(priv); /* Create and initialize the TX/RX descriptors chains. */ - priv->rx_ring_size = dma_rx_num; - priv->tx_ring_size = dma_tx_num; ret = alloc_init_skbufs(priv); if (ret) { netdev_err(dev, "DMA descriptors initialization failed\n");