| Message ID | 20200703164432.qp6pkukrbua3yyhl@linutronix.de |
|---|---|
| State | Accepted |
| Delegated to: | David Miller |
| Headers | show |
| Series | [net] net/mlx5e: Do not include rwlock.h directly | expand |
On Fri, Jul 03, 2020 at 06:44:32PM +0200, Sebastian Andrzej Siewior wrote: > rwlock.h should not be included directly. Instead linux/splinlock.h > should be included. Including it directly will break the RT build. > > Fixes: 549c243e4e010 ("net/mlx5e: Extract neigh-specific code from en_rep.c to rep/neigh.c") > Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de> > --- > It would be nice if this could get into v5.8 since this include has been > added in v5.8-rc1. > > drivers/net/ethernet/mellanox/mlx5/core/en/rep/neigh.c | 1 - > 1 file changed, 1 deletion(-) > Thanks, Reviewed-by: Leon Romanovsky <leonro@mellanox.com>
On Fri, 2020-07-03 at 18:44 +0200, Sebastian Andrzej Siewior wrote: > rwlock.h should not be included directly. Instead linux/splinlock.h > should be included. Including it directly will break the RT build. > > Fixes: 549c243e4e010 ("net/mlx5e: Extract neigh-specific code from > en_rep.c to rep/neigh.c") > Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de> > --- > It would be nice if this could get into v5.8 since this include has > been > added in v5.8-rc1. > I don't mind applying this to net. Acked-by: Saeed Mahameed <saeedm@mellanox.com>
From: Sebastian Andrzej Siewior <bigeasy@linutronix.de> Date: Fri, 3 Jul 2020 18:44:32 +0200 > rwlock.h should not be included directly. Instead linux/splinlock.h > should be included. Including it directly will break the RT build. > > Fixes: 549c243e4e010 ("net/mlx5e: Extract neigh-specific code from en_rep.c to rep/neigh.c") > Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de> > --- > It would be nice if this could get into v5.8 since this include has been > added in v5.8-rc1. Applied, thanks.
diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en/rep/neigh.c b/drivers/net/ethernet/mellanox/mlx5/core/en/rep/neigh.c index baa162432e75e..c3d167fa944c7 100644 --- a/drivers/net/ethernet/mellanox/mlx5/core/en/rep/neigh.c +++ b/drivers/net/ethernet/mellanox/mlx5/core/en/rep/neigh.c @@ -6,7 +6,6 @@ #include <linux/rculist.h> #include <linux/rtnetlink.h> #include <linux/workqueue.h> -#include <linux/rwlock.h> #include <linux/spinlock.h> #include <linux/notifier.h> #include <net/netevent.h>
rwlock.h should not be included directly. Instead linux/splinlock.h should be included. Including it directly will break the RT build. Fixes: 549c243e4e010 ("net/mlx5e: Extract neigh-specific code from en_rep.c to rep/neigh.c") Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de> --- It would be nice if this could get into v5.8 since this include has been added in v5.8-rc1. drivers/net/ethernet/mellanox/mlx5/core/en/rep/neigh.c | 1 - 1 file changed, 1 deletion(-)