Message ID | 20200703133359.22723-1-trix@redhat.com |
---|---|
State | Accepted |
Delegated to: | David Miller |
Headers | show |
Series | net: sky2: initialize return of gm_phy_read | expand |
On Fri, Jul 03, 2020 at 06:33:59AM -0700, trix@redhat.com wrote: > From: Tom Rix <trix@redhat.com> > > clang static analysis flags this garbage return > > drivers/net/ethernet/marvell/sky2.c:208:2: warning: Undefined or garbage value returned to caller [core.uninitialized.UndefReturn] > return v; > ^~~~~~~~ > > static inline u16 gm_phy_read( ... > { > u16 v; > __gm_phy_read(hw, port, reg, &v); > return v; > } > > __gm_phy_read can return without setting v. > > So handle similar to skge.c's gm_phy_read, initialize v. > > Signed-off-by: Tom Rix <trix@redhat.com> Reviewed-by: Andrew Lunn <andrew@lunn.ch> Andrew
From: trix@redhat.com Date: Fri, 3 Jul 2020 06:33:59 -0700 > From: Tom Rix <trix@redhat.com> > > clang static analysis flags this garbage return > > drivers/net/ethernet/marvell/sky2.c:208:2: warning: Undefined or garbage value returned to caller [core.uninitialized.UndefReturn] > return v; > ^~~~~~~~ > > static inline u16 gm_phy_read( ... > { > u16 v; > __gm_phy_read(hw, port, reg, &v); > return v; > } > > __gm_phy_read can return without setting v. > > So handle similar to skge.c's gm_phy_read, initialize v. > > Signed-off-by: Tom Rix <trix@redhat.com> Applied, thank you.
diff --git a/drivers/net/ethernet/marvell/sky2.c b/drivers/net/ethernet/marvell/sky2.c index 241f00716979..fe54764caea9 100644 --- a/drivers/net/ethernet/marvell/sky2.c +++ b/drivers/net/ethernet/marvell/sky2.c @@ -203,7 +203,7 @@ static int __gm_phy_read(struct sky2_hw *hw, unsigned port, u16 reg, u16 *val) static inline u16 gm_phy_read(struct sky2_hw *hw, unsigned port, u16 reg) { - u16 v; + u16 v = 0; __gm_phy_read(hw, port, reg, &v); return v; }