From patchwork Wed Jul 1 15:06:59 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?b?SsOpcsO0bWUgUG91aWxsZXI=?= X-Patchwork-Id: 1320615 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming-netdev@ozlabs.org Delivered-To: patchwork-incoming-netdev@ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org (client-ip=23.128.96.18; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=silabs.com Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=silabs.onmicrosoft.com header.i=@silabs.onmicrosoft.com header.a=rsa-sha256 header.s=selector2-silabs-onmicrosoft-com header.b=kNaaxRXW; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by ozlabs.org (Postfix) with ESMTP id 49xl5974zyz9sTg for ; Thu, 2 Jul 2020 01:09:49 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731992AbgGAPJs (ORCPT ); Wed, 1 Jul 2020 11:09:48 -0400 Received: from mail-bn8nam12on2072.outbound.protection.outlook.com ([40.107.237.72]:60865 "EHLO NAM12-BN8-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1731733AbgGAPIV (ORCPT ); Wed, 1 Jul 2020 11:08:21 -0400 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=FWehFp4clvN3xOP1vh6nmytlDvSn8nUxuniNzu9FQWxBU9olxcYMt7Hr/JioFwF79jekroQiJDJUxbSKzIIRPCBPlu3dAKbWvre5FWOKdGBzogKYXx/aAXgmZkyGak7i8/uC+96/0zbli3sJrKuSsu22D2aMYZymwzeMiV9xj/1Tdt8+FMI1/gRASp8Yk5l1kuA8A82P960/luL5Z8OCsyMHojaCbpXeyHv2V4LBkM/wr+pbLLnfyKcUmPTtsiLWAQT1fWJqOuCbSFKjZCtYORZixTLX13ciMFrhmR4ee+C4vJ/GCx0d9iIPYQoYlWadeMQ0wdOTzO7mnzlLymmeWg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=aXpNpMygO/KPLne8WsJxsDwp8Ia385m8ResSG8rBl5Q=; b=AOUI3c7PPRKmf8uEtY1YpufTcJvEPn2nl05VAMchvvnHTLaYzR3VKczs+B5fTXkRBRWRccBDIjiZbtWL6jk9NXNElAOUmcCp2hrp9hRRutbLd5o86Z5aJHbNZVEjwMhgfChJ2cJKIR+XMJSIwS14e6ZbFOpg8yW3ml9g/Ng0zGekCiDnjXX22T7kFZXfnrxuczYDD9lCtkvCFiVbA1RVHqmpkg7HtxodEvHfy4OkUOKcjhCinJ1H6moPxpoZuSIa6oyhEPt3QWqek55++KFUFQcAdMYUdxX1juMcVy7U8eNzECHhJfh5Kn+bc9dHUHNvQugUkYgNRYvoVmPTViO6kg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=silabs.com; dmarc=pass action=none header.from=silabs.com; dkim=pass header.d=silabs.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=silabs.onmicrosoft.com; s=selector2-silabs-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=aXpNpMygO/KPLne8WsJxsDwp8Ia385m8ResSG8rBl5Q=; b=kNaaxRXWLdKwJqRcbW/Ly6LPZ4c45zlT+i0cZswiaWopCNxmCHCtb2mbYBw7giI9sBaYnasIDLSwRVgwplyY1BUjHIoA1ZaXBIHYrwCPmlLJHfXeHNI1JtH1UCPv1urMv1Jsc+W33AtpYNK7fCslYyNXPR0Pyygt4CA7RbA/+Kc= Authentication-Results: driverdev.osuosl.org; dkim=none (message not signed) header.d=none;driverdev.osuosl.org; dmarc=none action=none header.from=silabs.com; Received: from SN6PR11MB2718.namprd11.prod.outlook.com (2603:10b6:805:63::18) by SA0PR11MB4736.namprd11.prod.outlook.com (2603:10b6:806:9f::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3153.22; Wed, 1 Jul 2020 15:08:10 +0000 Received: from SN6PR11MB2718.namprd11.prod.outlook.com ([fe80::c504:2d66:a8f7:2336]) by SN6PR11MB2718.namprd11.prod.outlook.com ([fe80::c504:2d66:a8f7:2336%7]) with mapi id 15.20.3131.033; Wed, 1 Jul 2020 15:08:10 +0000 From: Jerome Pouiller To: devel@driverdev.osuosl.org, linux-wireless@vger.kernel.org Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Greg Kroah-Hartman , Kalle Valo , "David S . Miller" , =?utf-8?b?SsOpcsO0bWUgUG91aWxsZXI=?= Subject: [PATCH 05/13] staging: wfx: load the firmware faster Date: Wed, 1 Jul 2020 17:06:59 +0200 Message-Id: <20200701150707.222985-6-Jerome.Pouiller@silabs.com> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20200701150707.222985-1-Jerome.Pouiller@silabs.com> References: <20200701150707.222985-1-Jerome.Pouiller@silabs.com> X-ClientProxiedBy: DM5PR07CA0143.namprd07.prod.outlook.com (2603:10b6:3:13e::33) To SN6PR11MB2718.namprd11.prod.outlook.com (2603:10b6:805:63::18) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from pc-42.silabs.com (2a01:e35:2435:66a0:544b:f17b:7ae8:fb7) by DM5PR07CA0143.namprd07.prod.outlook.com (2603:10b6:3:13e::33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3153.21 via Frontend Transport; Wed, 1 Jul 2020 15:08:08 +0000 X-Mailer: git-send-email 2.27.0 X-Originating-IP: [2a01:e35:2435:66a0:544b:f17b:7ae8:fb7] X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: f42951af-6a5d-401d-bbe8-08d81dd09164 X-MS-TrafficTypeDiagnostic: SA0PR11MB4736: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:4125; X-Forefront-PRVS: 04519BA941 X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: sBZWOlsYLJSqTfRR5g1qT8KUPqM6LKt9VKnjsKUVIkoZlZZwX1y5zeyFl8xUBGLRSGR5zOGycdTflFI/36QI06pwGlaTxL9OCp0ABYI98dzLSDYBWZHiKTUEoDjPui5s9WzxWXHSiRiTFnW3AmCv3I+1KBDbMrv+bCQ5FuK+NCSGsatLkdAdeO7mYaKFSlZKoElKXmyIdQEG2/zK5Fk92h25wD02ZYIfUVvfvSItta41bIQeiMqp7NqNgY49rEyza7rxYJ2CWUDskPB2sKvkUf86roRarA/i1uLuDsSMNqhgkuNRMLyqu0/9mDyvGvkWrgTtT579gKFm1Uw3sjwItg== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SN6PR11MB2718.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFTY:;SFS:(39850400004)(366004)(346002)(376002)(396003)(136003)(5660300002)(6486002)(86362001)(6666004)(66574015)(36756003)(2906002)(186003)(83380400001)(16526019)(8936002)(66556008)(66476007)(107886003)(4326008)(8676002)(2616005)(1076003)(478600001)(316002)(54906003)(66946007)(52116002)(7696005);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData: 3bWFuyGlUSW2/tGfgR1l8YLSFNc9PEN3jY7pNrVq1utUvIz1lQuefYCuwKPnDUea7WOBy2VwR8B+QqedHCZ0cqgf3x8tgAT9ylmzASaxaqUOwREdxE7Ry7T/Sdhq3AHPh8QU1bX37qpL06wWvc7sV7nlKa7gn/DABoXCpvAmXGMk7dGmzS8AjFv+vPE4dq4ZW+6ENRGopl8SiOCE3ZCgqUCi0/gmIokfE2vlHH923oLMyN1Z8bsN7qkEsjVj9DDtOdP4SoxycidY34i5xaBa7XCxppq0RRctNydnPO4dlP/aAIjeQhp6JiGCngiA2KyUTBGe8i503lya7MDuOmpp2Ej/Y3ZDDw3pLTejobmS0zirmhYJQnoSlVC1SWg85aqIEjoN3pD+590qu6KgU6IvaCqnlpfWqBADhFJaF1ZLsfSj1AzFArc6hElDdcIZ4llfM+HJRrIDV70vjzjpX8LTdH/hdDsl7KcuMdsiWQQuU7BAnMMK4wmJYGvpi1ouQbq0nhGp9k6wgQW5aX8VESNFUU4/m+c4PJ/9e72uAcYTgPI= X-OriginatorOrg: silabs.com X-MS-Exchange-CrossTenant-Network-Message-Id: f42951af-6a5d-401d-bbe8-08d81dd09164 X-MS-Exchange-CrossTenant-AuthSource: SN6PR11MB2718.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Jul 2020 15:08:10.6234 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 54dbd822-5231-4b20-944d-6f4abcd541fb X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: DQUaFbVTZ3Nakx6JSo3Zr38I/Vwo7ASBvB9/tOg84r3tK4Zvjh3KcA+Vyn+W16O4i/UILinXbP/XOhzNIrJVSA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA0PR11MB4736 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Jérôme Pouiller During the loading of the firmware, the WFX_DCA_GET register provide the number available bytes in the receiving buffer. It is not necessary to access to the WFX_DCA_GET after sent of each firmware fragment. This patch allows to send the firmware: - in 64ms instead of 130ms using SDIO bus - in 78ms instead of 115ms using SPI bus Signed-off-by: Jérôme Pouiller --- drivers/staging/wfx/fwio.c | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/drivers/staging/wfx/fwio.c b/drivers/staging/wfx/fwio.c index 72bb3d2a96138..d9a886f3e64be 100644 --- a/drivers/staging/wfx/fwio.c +++ b/drivers/staging/wfx/fwio.c @@ -188,15 +188,14 @@ static int upload_firmware(struct wfx_dev *wdev, const u8 *data, size_t len) while (offs < len) { start = ktime_get(); for (;;) { - ret = sram_reg_read(wdev, WFX_DCA_GET, &bytes_done); - if (ret < 0) - return ret; now = ktime_get(); - if (offs + - DNLD_BLOCK_SIZE - bytes_done < DNLD_FIFO_SIZE) + if (offs + DNLD_BLOCK_SIZE - bytes_done < DNLD_FIFO_SIZE) break; if (ktime_after(now, ktime_add_ms(start, DCA_TIMEOUT))) return -ETIMEDOUT; + ret = sram_reg_read(wdev, WFX_DCA_GET, &bytes_done); + if (ret < 0) + return ret; } if (ktime_compare(now, start)) dev_dbg(wdev->dev, "answer after %lldus\n",