diff mbox series

libbpf: Install headers as part of make install

Message ID 20200526174612.5447-1-nborisov@suse.com
State Accepted
Delegated to: BPF Maintainers
Headers show
Series libbpf: Install headers as part of make install | expand

Commit Message

Nikolay Borisov May 26, 2020, 5:46 p.m. UTC
Current 'make install' results in only pkg-config and library binaries
being installed. For consistency also install headers as part of
"make install"

Signed-off-by: Nikolay Borisov <nborisov@suse.com>
---
 tools/lib/bpf/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Andrii Nakryiko May 26, 2020, 5:58 p.m. UTC | #1
On Tue, May 26, 2020 at 10:49 AM Nikolay Borisov <nborisov@suse.com> wrote:
>
> Current 'make install' results in only pkg-config and library binaries
> being installed. For consistency also install headers as part of
> "make install"
>
> Signed-off-by: Nikolay Borisov <nborisov@suse.com>
> ---

Github Makefile already does that, curiously :)

Acked-by: Andrii Nakryiko <andriin@fb.com>


>  tools/lib/bpf/Makefile | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/lib/bpf/Makefile b/tools/lib/bpf/Makefile
> index aee7f1a83c77..d02c4d910aad 100644
> --- a/tools/lib/bpf/Makefile
> +++ b/tools/lib/bpf/Makefile
> @@ -264,7 +264,7 @@ install_pkgconfig: $(PC_FILE)
>         $(call QUIET_INSTALL, $(PC_FILE)) \
>                 $(call do_install,$(PC_FILE),$(libdir_SQ)/pkgconfig,644)
>
> -install: install_lib install_pkgconfig
> +install: install_lib install_pkgconfig install_headers
>
>  ### Cleaning rules
>
> --
> 2.17.1
>
Daniel Borkmann May 26, 2020, 9:14 p.m. UTC | #2
On Tue, May 26, 2020 at 08:46:12PM +0300, Nikolay Borisov wrote:
> Current 'make install' results in only pkg-config and library binaries
> being installed. For consistency also install headers as part of
> "make install"
> 
> Signed-off-by: Nikolay Borisov <nborisov@suse.com>

Applied, thanks!
diff mbox series

Patch

diff --git a/tools/lib/bpf/Makefile b/tools/lib/bpf/Makefile
index aee7f1a83c77..d02c4d910aad 100644
--- a/tools/lib/bpf/Makefile
+++ b/tools/lib/bpf/Makefile
@@ -264,7 +264,7 @@  install_pkgconfig: $(PC_FILE)
 	$(call QUIET_INSTALL, $(PC_FILE)) \
 		$(call do_install,$(PC_FILE),$(libdir_SQ)/pkgconfig,644)
 
-install: install_lib install_pkgconfig
+install: install_lib install_pkgconfig install_headers
 
 ### Cleaning rules