From patchwork Fri May 15 08:33:08 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?b?SsOpcsO0bWUgUG91aWxsZXI=?= X-Patchwork-Id: 1290954 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming-netdev@ozlabs.org Delivered-To: patchwork-incoming-netdev@ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org (client-ip=23.128.96.18; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=silabs.com Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=silabs.onmicrosoft.com header.i=@silabs.onmicrosoft.com header.a=rsa-sha256 header.s=selector2-silabs-onmicrosoft-com header.b=E81EuKE6; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by ozlabs.org (Postfix) with ESMTP id 49NhZV52zjz9sT6 for ; Fri, 15 May 2020 18:36:02 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728040AbgEOIeC (ORCPT ); Fri, 15 May 2020 04:34:02 -0400 Received: from mail-dm6nam11on2086.outbound.protection.outlook.com ([40.107.223.86]:6138 "EHLO NAM11-DM6-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726694AbgEOId6 (ORCPT ); Fri, 15 May 2020 04:33:58 -0400 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Iwdp4y1+v3QNTmUxnqjL4NX6zQWdolVkd1kveTa7wRpLaCy7ayPFlxi2ZDrHbUvEnTa77NJuil6d6r7J31LG/GdIEzwDKcFVXJaC8ev9G67c1BGyRLl+LpXoJKwreAYZqw6M0Md0f6TWRoUG914mQlRPeDNSgQTXmmuLHdKsGqggk1ERTgqgnNhMW397gRGEC1vgYKVnssDCI0vJDeipbV6kJnYQRTr+3txkdv3m0nf/hfAmcp0WgGAUTtzYUzSlnGQlr8uT+zvbMKbL44AK4p4/yLx92uD3jnPCj5+rpjnMHqfDe8QEPLnPGAUM+fT6igKvz0lggDg+nOzS/slrXQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=6oXBrPW3S//L2OALwR/pytKdvvtjmRL+t3R7MNyjUhA=; b=aEcq0A1L0LN3N8prHwpq20ITwOTEtRj5glj4zOL8JHP0wHYXA3ppwINOMcM7yfKEBbOZrA+FoGqPsd3ecHs9Wwo1tzslSiCAcNYAwLoczm41tKu3n7aHxD/mK1xpEJieUp8fJsP0yU2mOiFmfM6DBGxgaGaj5GtLft/0X0GR/QyqVqH/5nhc/W0/fCe4oAvYjAGKc+j7ZG6WLcr80Y3XLMJZIKh02V8EOXj93lENG5iZhGWSkz1a6Y1ZLqkx6ljjJ+ypriB5ax3QywGhWe9hyVF9AiWP31TSfRtC0acDMQmHzMrx/m3I7wIuRCsnaDyw2cP8xGtXkxuWfnUt9ieTdA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=silabs.com; dmarc=pass action=none header.from=silabs.com; dkim=pass header.d=silabs.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=silabs.onmicrosoft.com; s=selector2-silabs-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=6oXBrPW3S//L2OALwR/pytKdvvtjmRL+t3R7MNyjUhA=; b=E81EuKE6r8wNTp+W/Eta1whyDhs9qVf7S4T9xEGeSqgsXwJ1zQv+uXCtssK3s/N5MdSQ/8Hq/x6xEu0mzCC272FvA7hJpa6RCbaqzZ/KncdxEaZzOu7LJkdMRGcZivzkkZ+binBOy9c07BVt4b12+T78l2TLDngtamHbMELr+nA= Authentication-Results: driverdev.osuosl.org; dkim=none (message not signed) header.d=none;driverdev.osuosl.org; dmarc=none action=none header.from=silabs.com; Received: from MWHPR11MB1775.namprd11.prod.outlook.com (2603:10b6:300:10e::14) by MWHPR11MB1310.namprd11.prod.outlook.com (2603:10b6:300:28::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2979.26; Fri, 15 May 2020 08:33:52 +0000 Received: from MWHPR11MB1775.namprd11.prod.outlook.com ([fe80::e055:3e6d:ff4:56da]) by MWHPR11MB1775.namprd11.prod.outlook.com ([fe80::e055:3e6d:ff4:56da%5]) with mapi id 15.20.3000.022; Fri, 15 May 2020 08:33:52 +0000 From: Jerome Pouiller To: devel@driverdev.osuosl.org, linux-wireless@vger.kernel.org Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Greg Kroah-Hartman , Kalle Valo , "David S . Miller" , =?utf-8?b?SsOpcsO0bWUgUG91aWxsZXI=?= Subject: [PATCH 02/19] staging: wfx: apply 80-columns rule to strings Date: Fri, 15 May 2020 10:33:08 +0200 Message-Id: <20200515083325.378539-3-Jerome.Pouiller@silabs.com> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20200515083325.378539-1-Jerome.Pouiller@silabs.com> References: <20200515083325.378539-1-Jerome.Pouiller@silabs.com> X-ClientProxiedBy: PR0P264CA0076.FRAP264.PROD.OUTLOOK.COM (2603:10a6:100:18::16) To MWHPR11MB1775.namprd11.prod.outlook.com (2603:10b6:300:10e::14) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from pc-42.home (82.67.86.106) by PR0P264CA0076.FRAP264.PROD.OUTLOOK.COM (2603:10a6:100:18::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3000.24 via Frontend Transport; Fri, 15 May 2020 08:33:50 +0000 X-Mailer: git-send-email 2.26.2 X-Originating-IP: [82.67.86.106] X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: d353eaff-de35-49f9-5913-08d7f8aab287 X-MS-TrafficTypeDiagnostic: MWHPR11MB1310: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:1332; X-Forefront-PRVS: 04041A2886 X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: FUSK5ptxs6D9GEypE4rF/3ps/fbEPjQC7JtGFbltIW3a6VGlSAA+nPDEPiEPTQMdZ9sWmBReRUso4MZ8wMtTDSQLhOULd4jwwlVQTN18vp8DmD5in8YOjZrQUmCqxpc9eqgQC1cTuss2Au8Z2h8BlWFkdPIzKw1WoXjcGwg/BgzvnUP3vjzwmnZGrnaziwbLZBO8na76yvsPHPnz0J/NqFuPhtQCcupTagfihRWY43Y3G1b31OHNMnnLtpWOgmv1qyhwlRKZ39LcO9Zm+DE0WK1bR5W7jofQp7CYPbwqRgA7WB9Dy18HeUW9aBC8+3OKBzjxi76T2zADNkJAevXsgZFcN0rWZocGvT1rFMPmzcM4EnKbDqI05xgJBwO/UCveao8o+s1lPXKVzX7t9N8ZSSdfB2qSzLzgdtBNUL3/EuF5ITduLV5XqkFlmn7VDsmQ X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MWHPR11MB1775.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFTY:;SFS:(346002)(136003)(376002)(366004)(39850400004)(396003)(8886007)(66556008)(186003)(6512007)(66946007)(6506007)(36756003)(316002)(66476007)(26005)(52116002)(16526019)(6666004)(54906003)(2906002)(2616005)(478600001)(66574014)(107886003)(956004)(8936002)(86362001)(8676002)(6486002)(5660300002)(4326008)(1076003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData: Vj53rCYcGNNyW4sRtcub5n3HKLeH5LVG+RTA0/2GEl54ja3mDLfqP2FVj0EQqwX8FOepAxJw1hSJ3bAlpe3U9AJPUgWzgEV7I35rGnwKHaYgIlGywjcw6lv9SgUGAVO4AxZq7P1HZqa1BleYiAoDeIlzrVu6YcZl7xqmU9ReZtf6y+RN7ufOcN9ok/qQPXE6hHaAVfRRkBdgFlWgwYUZoqQ1mFg2tCEd1JKOqcFw2AnKY+3e9W8dV08sGqVXt2C9BjCfUDALnna1I8VjFF8Q6kajDLPMEbVgczOSBPhqTXCuwGrQKXtzHK/piP2NhI7Xx1/SzGupam7wBa37qsYXB1wSyW6rAsMGERVxZMQI4ly86561D5YSf4/xyt8gb7wSOnTky/94U/ESQIJwNEhlTXccxv6zxyQiWqqnW5nhTLcTJFFMF7Hu1v/Y/tnHjQ9XojTLwD9M/gYpIee4OUd2WxKiczg6KfuumTQp4y45MVY= X-OriginatorOrg: silabs.com X-MS-Exchange-CrossTenant-Network-Message-Id: d353eaff-de35-49f9-5913-08d7f8aab287 X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 May 2020 08:33:52.1017 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 54dbd822-5231-4b20-944d-6f4abcd541fb X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: +KqJ1fR9ClzgX8YnpGAW9VOlwO/VeC+AMWKxOiFqoXM797z4qmlstrM+vKD7q/SojONoU0wCAUYmR/NxA4YPjA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR11MB1310 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Jérôme Pouiller Strings are allowed to exceed 80 columns but, in this case, the format arguments should be placed on a new line. Apply this rule to the whole code of the driver. Signed-off-by: Jérôme Pouiller --- drivers/staging/wfx/bus_sdio.c | 3 ++- drivers/staging/wfx/data_tx.c | 4 ++-- drivers/staging/wfx/fwio.c | 8 ++++---- drivers/staging/wfx/hif_tx.c | 4 ++-- drivers/staging/wfx/main.c | 17 ++++++++++------- 5 files changed, 20 insertions(+), 16 deletions(-) diff --git a/drivers/staging/wfx/bus_sdio.c b/drivers/staging/wfx/bus_sdio.c index 6464b2c508e4..496bfc8bbacc 100644 --- a/drivers/staging/wfx/bus_sdio.c +++ b/drivers/staging/wfx/bus_sdio.c @@ -180,7 +180,8 @@ static int wfx_sdio_probe(struct sdio_func *func, int ret; if (func->num != 1) { - dev_err(&func->dev, "SDIO function number is %d while it should always be 1 (unsupported chip?)\n", func->num); + dev_err(&func->dev, "SDIO function number is %d while it should always be 1 (unsupported chip?)\n", + func->num); return -ENODEV; } diff --git a/drivers/staging/wfx/data_tx.c b/drivers/staging/wfx/data_tx.c index 4a2910897b6f..cac8c9ecbc34 100644 --- a/drivers/staging/wfx/data_tx.c +++ b/drivers/staging/wfx/data_tx.c @@ -550,8 +550,8 @@ void wfx_tx_confirm_cb(struct wfx_vif *wvif, const struct hif_cnf_tx *arg) } } if (tx_count) - dev_dbg(wvif->wdev->dev, - "%d more retries than expected\n", tx_count); + dev_dbg(wvif->wdev->dev, "%d more retries than expected\n", + tx_count); skb_trim(skb, skb->len - wfx_tx_get_icv_len(tx_priv->hw_key)); // From now, you can touch to tx_info->status, but do not touch to diff --git a/drivers/staging/wfx/fwio.c b/drivers/staging/wfx/fwio.c index 85b6a916a7d0..72bb3d2a9613 100644 --- a/drivers/staging/wfx/fwio.c +++ b/drivers/staging/wfx/fwio.c @@ -107,8 +107,8 @@ static int get_firmware(struct wfx_dev *wdev, u32 keyset_chip, const char *data; int ret; - snprintf(filename, sizeof(filename), "%s_%02X.sec", wdev->pdata.file_fw, - keyset_chip); + snprintf(filename, sizeof(filename), "%s_%02X.sec", + wdev->pdata.file_fw, keyset_chip); ret = firmware_request_nowarn(fw, filename, wdev->dev); if (ret) { dev_info(wdev->dev, "can't load %s, falling back to %s.sec\n", @@ -325,8 +325,8 @@ static int init_gpr(struct wfx_dev *wdev) gpr_init[i].value); if (ret < 0) return ret; - dev_dbg(wdev->dev, " index %02x: %08x\n", gpr_init[i].index, - gpr_init[i].value); + dev_dbg(wdev->dev, " index %02x: %08x\n", + gpr_init[i].index, gpr_init[i].value); } return 0; } diff --git a/drivers/staging/wfx/hif_tx.c b/drivers/staging/wfx/hif_tx.c index 3e5d9111e855..58adfaf8066d 100644 --- a/drivers/staging/wfx/hif_tx.c +++ b/drivers/staging/wfx/hif_tx.c @@ -192,8 +192,8 @@ int hif_read_mib(struct wfx_dev *wdev, int vif_id, u16 mib_id, ret = wfx_cmd_send(wdev, hif, reply, buf_len, false); if (!ret && mib_id != le16_to_cpu(reply->mib_id)) { - dev_warn(wdev->dev, - "%s: confirmation mismatch request\n", __func__); + dev_warn(wdev->dev, "%s: confirmation mismatch request\n", + __func__); ret = -EIO; } if (ret == -ENOMEM) diff --git a/drivers/staging/wfx/main.c b/drivers/staging/wfx/main.c index d4e69c663f5a..ae23a56f50e0 100644 --- a/drivers/staging/wfx/main.c +++ b/drivers/staging/wfx/main.c @@ -192,12 +192,12 @@ struct gpio_desc *wfx_get_gpio(struct device *dev, if (!ret || PTR_ERR(ret) == -ENOENT) dev_warn(dev, "gpio %s is not defined\n", label); else - dev_warn(dev, - "error while requesting gpio %s\n", label); + dev_warn(dev, "error while requesting gpio %s\n", + label); ret = NULL; } else { - dev_dbg(dev, - "using gpio %d for %s\n", desc_to_gpio(ret), label); + dev_dbg(dev, "using gpio %d for %s\n", + desc_to_gpio(ret), label); } return ret; } @@ -230,15 +230,18 @@ int wfx_send_pds(struct wfx_dev *wdev, u8 *buf, size_t len) ret = hif_configuration(wdev, buf + start, i - start + 1); if (ret > 0) { - dev_err(wdev->dev, "PDS bytes %d to %d: invalid data (unsupported options?)\n", start, i); + dev_err(wdev->dev, "PDS bytes %d to %d: invalid data (unsupported options?)\n", + start, i); return -EINVAL; } if (ret == -ETIMEDOUT) { - dev_err(wdev->dev, "PDS bytes %d to %d: chip didn't reply (corrupted file?)\n", start, i); + dev_err(wdev->dev, "PDS bytes %d to %d: chip didn't reply (corrupted file?)\n", + start, i); return ret; } if (ret) { - dev_err(wdev->dev, "PDS bytes %d to %d: chip returned an unknown error\n", start, i); + dev_err(wdev->dev, "PDS bytes %d to %d: chip returned an unknown error\n", + start, i); return -EIO; } buf[i] = ',';