From patchwork Fri May 15 08:33:25 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?b?SsOpcsO0bWUgUG91aWxsZXI=?= X-Patchwork-Id: 1290942 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming-netdev@ozlabs.org Delivered-To: patchwork-incoming-netdev@ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org (client-ip=23.128.96.18; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=silabs.com Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=silabs.onmicrosoft.com header.i=@silabs.onmicrosoft.com header.a=rsa-sha256 header.s=selector2-silabs-onmicrosoft-com header.b=KyPr5+Eb; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by ozlabs.org (Postfix) with ESMTP id 49NhY20Zm8z9sTc for ; Fri, 15 May 2020 18:34:46 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728402AbgEOIeo (ORCPT ); Fri, 15 May 2020 04:34:44 -0400 Received: from mail-dm6nam11on2086.outbound.protection.outlook.com ([40.107.223.86]:6138 "EHLO NAM11-DM6-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1728305AbgEOIek (ORCPT ); Fri, 15 May 2020 04:34:40 -0400 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=dN0uEAiJ+AFyi7SNEb6yH/0LGVsHyi8/A65N9Mz6jKJ3XiWqHdoj0fCkMCTlNRKHg/30W7NwizRd/SITPbUOT5Uaoj8QyYlmVsCwkyoddatuvrqFH99YigiNlszILLnCE5OfFHVImDIQocLYX9t7fkVRVcNoWiWEuYxMB2ggCIs3k5lOnedw3fVtzv03CyTkRQE9DADH+Vo+9QVedXRLlan5xser40gzvLsVsK34RzuKeGSn5Ru7ILzzsxiQLsr5LcK8rjrZCf4kgXPANgOgx9iFHMQvujoR0oXSmqg3y1m5mnKN8KGdVts9CMHCNpmFgWylsZWhqTE8c8hDdB38xg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=HiN9WqBvuXb/S5iY+mscQrScVRKkiyxt6itUyF7ulLk=; b=lAgjcxPs3ls95LJO4rDxADmTMGC/phEpccOlsx8cxMWUIV84rNdKySmQ7x+WR9N42dCQ7J94sZz59n5Xg6aDbIBU8k83B3grPT1OSVFFPw7PCx5gyPKsBXX73gAPvlvU57M0dbM5+NGk8legaZIrfv2Kknw3VwuqlYAng86uNqI8Fv1eeuSB8gPPA2kCjIWTu3Ndhje8jFCUmXb4WXffTh3zFv7Fntecq9vxgyohSPqzeCMj6Mor/sonUWt/w8Gjcwkn4wTHCutlZzKK3gwtq6sGh7uacQyqFv/J+jNa2PeqtFIMCh3PDF+B24yYcWjXAefH1rOnlfYWhY3XX3JokQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=silabs.com; dmarc=pass action=none header.from=silabs.com; dkim=pass header.d=silabs.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=silabs.onmicrosoft.com; s=selector2-silabs-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=HiN9WqBvuXb/S5iY+mscQrScVRKkiyxt6itUyF7ulLk=; b=KyPr5+EbEwMTxL/c0JdjnQal3c9T3umvMnCP35XkAARbepAq1dh6DtmwVnQCJ8uGdWkTw5dJhtsmdRuVo4or3qMQ4How/x9nCEC/Kodn9gRKm/Ki2s0VcbDp6F5KiLf0lEQU5zcdU5LmwjUthLA904ODM1wk18jnWm4nF2DI4KM= Authentication-Results: driverdev.osuosl.org; dkim=none (message not signed) header.d=none;driverdev.osuosl.org; dmarc=none action=none header.from=silabs.com; Received: from MWHPR11MB1775.namprd11.prod.outlook.com (2603:10b6:300:10e::14) by MWHPR11MB1310.namprd11.prod.outlook.com (2603:10b6:300:28::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2979.26; Fri, 15 May 2020 08:34:24 +0000 Received: from MWHPR11MB1775.namprd11.prod.outlook.com ([fe80::e055:3e6d:ff4:56da]) by MWHPR11MB1775.namprd11.prod.outlook.com ([fe80::e055:3e6d:ff4:56da%5]) with mapi id 15.20.3000.022; Fri, 15 May 2020 08:34:24 +0000 From: Jerome Pouiller To: devel@driverdev.osuosl.org, linux-wireless@vger.kernel.org Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Greg Kroah-Hartman , Kalle Valo , "David S . Miller" , =?utf-8?b?SsOpcsO0bWUgUG91aWxsZXI=?= Subject: [PATCH 19/19] staging: wfx: remove false positive warning Date: Fri, 15 May 2020 10:33:25 +0200 Message-Id: <20200515083325.378539-20-Jerome.Pouiller@silabs.com> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20200515083325.378539-1-Jerome.Pouiller@silabs.com> References: <20200515083325.378539-1-Jerome.Pouiller@silabs.com> X-ClientProxiedBy: PR0P264CA0076.FRAP264.PROD.OUTLOOK.COM (2603:10a6:100:18::16) To MWHPR11MB1775.namprd11.prod.outlook.com (2603:10b6:300:10e::14) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from pc-42.home (82.67.86.106) by PR0P264CA0076.FRAP264.PROD.OUTLOOK.COM (2603:10a6:100:18::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3000.24 via Frontend Transport; Fri, 15 May 2020 08:34:22 +0000 X-Mailer: git-send-email 2.26.2 X-Originating-IP: [82.67.86.106] X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 8d091337-e80d-4f96-bd4c-08d7f8aac5e2 X-MS-TrafficTypeDiagnostic: MWHPR11MB1310: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:49; X-Forefront-PRVS: 04041A2886 X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: QGf/ub8g2yeGcCyJAZTcAemvIsLz3nSSRPKRRAQrevK09oUrmeC9xBqlok0r09wE/RXL1KhhdJs6f4glJpQSvzdpOcSEwF5DkWvGxgG+6s/tOr6grnjB75j6mmmZlTNs7oXqePtdCPnvzPOxrf3kn2qw2vGacAy5EBHV5i4ud3VQGytWvBU4l8joideGDVfaswgf5Nxpg9QwgN22kHssnejlCEC3QYsAiwJhBadsJkPaYXhRGJtJU4VWAGHBIxnL5O+UsKTHQS6iSDkL498IOeLG6iXwHgeVALo9y2XRnTN7vBFBFUtEIBdppTqxTXF1rCJUgrSmtcUUyOjTl9ZL8RHJT/5ojDZzM3D1eF5q9boeubj+BylgqsjaOShzLHARBmjyDk9B1lxznLG06Lc39uWm/+fNyVR8GQOAC4B6lya/s2DQYpTZPHusoquAwciZqvsWdQQlimYeFOcS4TteLzBI9/15AlcWuUbfc/NptFQ1xZppxopq7OFLXzgkMEH7TU0lb+2XM8hRCbpPiEoO1w== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MWHPR11MB1775.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFTY:;SFS:(346002)(136003)(376002)(366004)(39850400004)(396003)(8886007)(66556008)(186003)(6512007)(66946007)(966005)(6506007)(36756003)(316002)(66476007)(26005)(52116002)(16526019)(54906003)(2906002)(2616005)(478600001)(66574014)(107886003)(956004)(8936002)(86362001)(8676002)(6486002)(5660300002)(4326008)(1076003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData: inATRghY4H5F+9Uql+MFY9jp0zrfEjwg5vqDQX2REFya+vuBcJaRBdTb3STcsxs3DpQI9GqDeTm54b472G0xVcp6F2riKUW5kvv7sZ5ViBBXTqDcUMURTvvS58B80Qd8fNN6ajaLykmYwPV2/bUPwtI4C/LFOgnGGvEdDIAzZxfWp99x/f6kXTTvlox4b6TCeQQwYD6lwWuNaBa2LNc3rwzprTTb/JYkiSOQ5qnw6iostwy820SMk43VbfJgelyuoJ5hTuaxh/lu4Oa1ycSYgSO4FkoEFZyF+0b/WPtgS0gXygZ0zavLrgN9qYJpLDdViFGcp7J3dRddnvSGfbXB6+5yUEGGJ/3GVfOlItc87yneRuuCCGJk4UkT8w//TSr7D450EEYr++3oggr78pXSuaLrbe0mjwIm7W01qRs1/gdOhsgAfX85nsc452eyCokpjSgI6cHAOBn/4Vv6JFqZKgiOUIKRNrVCUOiDwAeWgpw= X-OriginatorOrg: silabs.com X-MS-Exchange-CrossTenant-Network-Message-Id: 8d091337-e80d-4f96-bd4c-08d7f8aac5e2 X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 May 2020 08:34:24.5324 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 54dbd822-5231-4b20-944d-6f4abcd541fb X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: iu7dcBhK39srP+ZAcb6AqKAL9M7vfKlQ2yyZ29kLU4QRMkcJ3KwVZ83ZdZBx+VT/qUt5HEVQ4MTwwpyfScsoaQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR11MB1310 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Jérôme Pouiller When a station is removed, the driver check that all the Tx frames were correctly sent. However, the station can be removed before all the Tx frames were acknowledged and a false positive warning can be emitted. The previous commit has added a trace when driver received an acknowledge for a non-existent station. It appear that these events are perfectly correlated and there is no leak. Now, the subject is perfectly understood. Remove the warning. Just keep a debug trace in case we have any doubt in the future. In the past, the subject has already been discussed here: https://lore.kernel.org/driverdev-devel/6287924.ghGFUMk3OD@pc-42/ Fixes: 4bbc6a3e7ad0 ("staging: wfx: make warning about pending frame less scary") Signed-off-by: Jérôme Pouiller --- drivers/staging/wfx/sta.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/staging/wfx/sta.c b/drivers/staging/wfx/sta.c index f448957c1a92..6015cd2c4d8a 100644 --- a/drivers/staging/wfx/sta.c +++ b/drivers/staging/wfx/sta.c @@ -441,8 +441,10 @@ int wfx_sta_remove(struct ieee80211_hw *hw, struct ieee80211_vif *vif, for (i = 0; i < ARRAY_SIZE(sta_priv->buffered); i++) if (sta_priv->buffered[i]) - dev_warn(wvif->wdev->dev, "release station while %d pending frame on queue %d", - sta_priv->buffered[i], i); + // Not an error if paired with trace in + // wfx_tx_update_sta() + dev_dbg(wvif->wdev->dev, "release station while %d pending frame on queue %d", + sta_priv->buffered[i], i); // See note in wfx_sta_add() if (!sta_priv->link_id) return 0;