From patchwork Fri May 15 08:33:07 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?b?SsOpcsO0bWUgUG91aWxsZXI=?= X-Patchwork-Id: 1290936 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming-netdev@ozlabs.org Delivered-To: patchwork-incoming-netdev@ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org (client-ip=23.128.96.18; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=silabs.com Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=silabs.onmicrosoft.com header.i=@silabs.onmicrosoft.com header.a=rsa-sha256 header.s=selector2-silabs-onmicrosoft-com header.b=kggP9jr2; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by ozlabs.org (Postfix) with ESMTP id 49NhX83f8Qz9sT6 for ; Fri, 15 May 2020 18:34:00 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728004AbgEOId5 (ORCPT ); Fri, 15 May 2020 04:33:57 -0400 Received: from mail-dm6nam11on2086.outbound.protection.outlook.com ([40.107.223.86]:6138 "EHLO NAM11-DM6-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1727111AbgEOIdz (ORCPT ); Fri, 15 May 2020 04:33:55 -0400 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=aCEcVZYspVBIRYQmskx6yxL12+L9X4daI+vR6vKZ4HviR/9gZWw3SlWeQbEHJw5yoTgWgCCl/0J/jyG+j7oTaBTREg6ZhPayGo5j0GVqDxpXrEip2lobir70R6L7fpXxUX//bl4gCsXHkvFy4ZtNniPYxNgzZQzmwposlgEk+GzxCjE4OzO6+Xz/xpWrxzY09N7DJE196W6O710sptSrYNobaQ/OYjVvZmba48qJqMaXJcoLgZXBVllo2tbBgM2BckiZZTOHV8K5LYM5o+O7nh5WsaMzv9IxyoWHCUvfekHiN4LJwTBGAiYpsT6RZ1h5RarHdZ2nVF+0Lrbj06WnLw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=GPHeT3iF5URE4a5rzKNup6vkQuIqCgzIbDR7ClMOUBA=; b=oNaNvgogRU6YBC09OowPdjqIqbZgc9n9G3knYSpGZ094P6V/xmpclWHyniJJI3LZanpLKqOlJQEm0iA6KvWEu/dLYgM+DyMNqSyRjdPVtRTeyowjUQvvcilJtfQcPFmSGlpzl9LUh4tInY48bfasVcNcXXbbE19DtyIne6KPLAVP9ztzKdkJ257QH6fEA1emgTKxdLMRMbNjJr9922oTpWZkf3U93M1bYKzYHTpAjdxB+YTU9DKOelUDrB48T2vy0v38J3LbCPN9TFddzZcH9/4TkELU19FT1pBCYRz7i7ncLBvG1Meb52ok9Zv0GU1L5DgOEGh+vYcckT7fYDr0lA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=silabs.com; dmarc=pass action=none header.from=silabs.com; dkim=pass header.d=silabs.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=silabs.onmicrosoft.com; s=selector2-silabs-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=GPHeT3iF5URE4a5rzKNup6vkQuIqCgzIbDR7ClMOUBA=; b=kggP9jr25qPMcdXFZG4gbzal+QkaYnl04Fz90lC8i92BGeFySUR3VjcWV/Qgh/Hp4dxj4lRNKlc6g+7LRGitsTxoN/8+QlbTVGJljqY3aTrb8Lr3cAf/xNia0yG1duwJtzgh/7URs0t/RxSbvpBtF7ghGSWOiVWXWNulPFXZQJE= Authentication-Results: driverdev.osuosl.org; dkim=none (message not signed) header.d=none;driverdev.osuosl.org; dmarc=none action=none header.from=silabs.com; Received: from MWHPR11MB1775.namprd11.prod.outlook.com (2603:10b6:300:10e::14) by MWHPR11MB1310.namprd11.prod.outlook.com (2603:10b6:300:28::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2979.26; Fri, 15 May 2020 08:33:50 +0000 Received: from MWHPR11MB1775.namprd11.prod.outlook.com ([fe80::e055:3e6d:ff4:56da]) by MWHPR11MB1775.namprd11.prod.outlook.com ([fe80::e055:3e6d:ff4:56da%5]) with mapi id 15.20.3000.022; Fri, 15 May 2020 08:33:50 +0000 From: Jerome Pouiller To: devel@driverdev.osuosl.org, linux-wireless@vger.kernel.org Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Greg Kroah-Hartman , Kalle Valo , "David S . Miller" , =?utf-8?b?SsOpcsO0bWUgUG91aWxsZXI=?= Subject: [PATCH 01/19] staging: wfx: fix warning when unregister a frozen device Date: Fri, 15 May 2020 10:33:07 +0200 Message-Id: <20200515083325.378539-2-Jerome.Pouiller@silabs.com> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20200515083325.378539-1-Jerome.Pouiller@silabs.com> References: <20200515083325.378539-1-Jerome.Pouiller@silabs.com> X-ClientProxiedBy: PR0P264CA0076.FRAP264.PROD.OUTLOOK.COM (2603:10a6:100:18::16) To MWHPR11MB1775.namprd11.prod.outlook.com (2603:10b6:300:10e::14) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from pc-42.home (82.67.86.106) by PR0P264CA0076.FRAP264.PROD.OUTLOOK.COM (2603:10a6:100:18::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3000.24 via Frontend Transport; Fri, 15 May 2020 08:33:48 +0000 X-Mailer: git-send-email 2.26.2 X-Originating-IP: [82.67.86.106] X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 9643eb0a-ba91-4af7-0cb6-08d7f8aab16b X-MS-TrafficTypeDiagnostic: MWHPR11MB1310: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:84; X-Forefront-PRVS: 04041A2886 X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: awRHL4g7Xo1o4WChvmfJCMWNaZdZE0B51JsmDsH7zxhgAGkYbuW/0N7wFZ3GQh0W2afwAW+lpKzLcATcTFyVKBuDmb4hCjDYxiUl51UJI74xuQL10/waALG1GiiaCTnA5OlA7pHfF0JoO2Ki6aHPse2Cyc8x3Y4XKeiGbgR7gtj7MD/qkquTu4DcFOZ2cKUz9f1TAsSp4JNBHQwYrZ9fzVTjGuhNXZnhcBGgX3Y6yvSHBU/adpYyHKfuk0fDdph5wmyF0nectG7dG8KzL31i+4+hu9pnUWDZjsbYUcItWWsJ1akOOvRAXrvW4fSmQ1o6N81t/7hqOd5Pv8bn+G/0sCdQQPD8LbsK80N91kIiKaF2MWtj7WScYV1R1Abl87JKlGdUTZA1jqoLMXhE0BUCrMuNZzVGf56Ko/L1W+c5Qcwk/6sGwj4aieKQLtuPWeCL X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MWHPR11MB1775.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFTY:;SFS:(346002)(136003)(376002)(366004)(39850400004)(396003)(8886007)(66556008)(186003)(6512007)(66946007)(6506007)(36756003)(316002)(66476007)(26005)(52116002)(16526019)(6666004)(54906003)(2906002)(2616005)(478600001)(66574014)(107886003)(956004)(8936002)(86362001)(8676002)(6486002)(5660300002)(4326008)(1076003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData: 2ilmVstfWeOgvHRJBI7+MukrZReU5ubfpk0aDooN1sWCVY8O67TlzNHg1udZgIbmSnM3rxXHk0wCsKqY7kdZEWF6fSMMHBM9Zm++4vVEhM+xKTlTdd9bq+tQGC8rTwBKIJtSSgnlL2FLAd6pKsB3HNI5n2aiNhjnuCGZRV7xhWG1y/wa0m3kbC1KXqs2Zlx/YlVJdLaMd2gM+EOmrQ+IhCOiAzps6W+jqOMj8Q7AteTWXxtzn9/AYYTY8B/tJTRUFTDs4eENtVdxVg5ijSN2g5egp8XPmfQhb171RtvxkDNeZt4CVOiuwIGbX44mc2ZAfU1MXKFyZvYoL4XwYgTpFp3Ke/fV8IbpkgTYRAPYaX67RO6K+oMQP9nj0O+eHiRSLrYB905a+GBbqBhFZHGz6GjvrafGK954Szck58sxIU+AuwC1uxzdPeEd1DKpn1x5Qvh7pdd59Nyo3IHeVmT6HTbAWyNyyGuB1A2JAOZ08mA= X-OriginatorOrg: silabs.com X-MS-Exchange-CrossTenant-Network-Message-Id: 9643eb0a-ba91-4af7-0cb6-08d7f8aab16b X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 May 2020 08:33:50.2475 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 54dbd822-5231-4b20-944d-6f4abcd541fb X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: nHL7nNbfCOy6ES8ITUtt+rqkWg00JmXKZ+hyzI7F22R2LNThvPFhOe4B891aykJ1ILJuV7+PeVi7aKAa8iG4jw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR11MB1310 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Jérôme Pouiller The device does not answer to the command hif_shutdown. Therefore, hif_shutdown() is a bit special. It bypasses some of work normally made by wfx_cmd_send(). In particularly, it unlock hif_cmd.lock and hif_cmd.key_renew_lock. However, if the driver notice that the device is frozen, wfx_cmd_send() stops to send data and doesn't lock the mutexes. Then, it produced a warning when hif_shutdown() tried to unlock these mutexes. Signed-off-by: Jérôme Pouiller --- drivers/staging/wfx/hif_tx.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/staging/wfx/hif_tx.c b/drivers/staging/wfx/hif_tx.c index 7f459719e7b4..3e5d9111e855 100644 --- a/drivers/staging/wfx/hif_tx.c +++ b/drivers/staging/wfx/hif_tx.c @@ -131,6 +131,8 @@ int hif_shutdown(struct wfx_dev *wdev) int ret; struct hif_msg *hif; + if (wdev->chip_frozen) + return 0; wfx_alloc_hif(0, &hif); wfx_fill_header(hif, -1, HIF_REQ_ID_SHUT_DOWN, 0); ret = wfx_cmd_send(wdev, hif, NULL, 0, true);