From patchwork Tue May 12 15:04:05 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?b?SsOpcsO0bWUgUG91aWxsZXI=?= X-Patchwork-Id: 1288524 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming-netdev@ozlabs.org Delivered-To: patchwork-incoming-netdev@ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org (client-ip=23.128.96.18; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=silabs.com Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=silabs.onmicrosoft.com header.i=@silabs.onmicrosoft.com header.a=rsa-sha256 header.s=selector2-silabs-onmicrosoft-com header.b=RHa5HFYd; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by ozlabs.org (Postfix) with ESMTP id 49M1Ln65J0z9sTF for ; Wed, 13 May 2020 01:05:05 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730703AbgELPFA (ORCPT ); Tue, 12 May 2020 11:05:00 -0400 Received: from mail-eopbgr770072.outbound.protection.outlook.com ([40.107.77.72]:30085 "EHLO NAM02-SN1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1730672AbgELPE6 (ORCPT ); Tue, 12 May 2020 11:04:58 -0400 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=a6tzswBd6T8k4XdzBRkY4RiK86VpUMuOjqihNiQnVccAB/L+tte8KBSjuZXPrvTV86ksICtv/d15GAyjZQVMcnlm64xqvqvUyzV2dAoax3cmPCleYiKg7Sx+PAXX73ca1bD5XesN24WbYxiczjiMN/7Oqu0NVwtSiy3xPrW+Kt9HJGxIiSixy4tFOyat5ASzn2ceRnhmLsoNCWOyNxfd3Fs1of2bMMDMTomFkeZ6LvKlY30/YMajKub88kwxg4xkJACAZuJSez09T6h5E+/hwhWnIu2ZcEqoH6vuzGwDzljmHYmOCvBLkwSi6szrcCC6oZomSac92O5cvAlHixWfoA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=BLoy7SPr/nnlx+NwszrJ2bm7GNP4HsvqH3meQhmDzEc=; b=eGOqe5oMX0Zr4rFJRvOzl2fm4j8Q5W8qoNuYgi2d2iPC2/A8AMJC2FNtJ+biyqo43FRvKMwEjUDyeaDJ++OiVV2nevj6WUT/Z3b67lnLOxiibsNMKDC4kNsPoyUnRHzUyIOBasEya9IzSFch3RrJ21N3cNlncRyWpFuE2E69Xej8WJ7tEZiWxbZ5M9CYo44ATZiUaol2PbznDzHlLmPGLaa0uLCfcOhzPgANqGTRorZoOI8FcEvhLhAM4doJ++CAt/vGLT5mmvCBS6VBadZnNOVT1ifN2Ay4nn0E/O0WTkd+WvEeWgfqAJ8kEkDNX+qDn4lbd2lqA4HaD5mj5HjMbw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=silabs.com; dmarc=pass action=none header.from=silabs.com; dkim=pass header.d=silabs.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=silabs.onmicrosoft.com; s=selector2-silabs-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=BLoy7SPr/nnlx+NwszrJ2bm7GNP4HsvqH3meQhmDzEc=; b=RHa5HFYdNuVJyKVFtzcULzGBuwCUc/Z+1lLuqDPexobfb8LeoghgfLZvoAIyLUI6b1l1RkXF9aeTZ45dyH23Cw82CiT0p6TcIV+hol8pp1uLKDcZCDl+rlqMak53T0kvaLDi5U3xWTI0qGRvrsH3JXBp0TQdz+sZqo6pEzS4eZM= Authentication-Results: driverdev.osuosl.org; dkim=none (message not signed) header.d=none;driverdev.osuosl.org; dmarc=none action=none header.from=silabs.com; Received: from MWHPR11MB1775.namprd11.prod.outlook.com (2603:10b6:300:10e::14) by MWHPR11MB1741.namprd11.prod.outlook.com (2603:10b6:300:10d::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2979.34; Tue, 12 May 2020 15:04:45 +0000 Received: from MWHPR11MB1775.namprd11.prod.outlook.com ([fe80::e055:3e6d:ff4:56da]) by MWHPR11MB1775.namprd11.prod.outlook.com ([fe80::e055:3e6d:ff4:56da%5]) with mapi id 15.20.2979.033; Tue, 12 May 2020 15:04:45 +0000 From: Jerome Pouiller To: devel@driverdev.osuosl.org, linux-wireless@vger.kernel.org Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Greg Kroah-Hartman , Kalle Valo , "David S . Miller" , =?utf-8?b?SsOpcsO0bWUgUG91aWxsZXI=?= Subject: [PATCH v2 08/17] staging: wfx: fix access to le32 attribute 'ps_mode_error' Date: Tue, 12 May 2020 17:04:05 +0200 Message-Id: <20200512150414.267198-9-Jerome.Pouiller@silabs.com> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20200512150414.267198-1-Jerome.Pouiller@silabs.com> References: <20200512150414.267198-1-Jerome.Pouiller@silabs.com> X-ClientProxiedBy: DM5PR1101CA0003.namprd11.prod.outlook.com (2603:10b6:4:4c::13) To MWHPR11MB1775.namprd11.prod.outlook.com (2603:10b6:300:10e::14) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from pc-42.silabs.com (82.67.86.106) by DM5PR1101CA0003.namprd11.prod.outlook.com (2603:10b6:4:4c::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3000.20 via Frontend Transport; Tue, 12 May 2020 15:04:44 +0000 X-Mailer: git-send-email 2.26.2 X-Originating-IP: [82.67.86.106] X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: d832b7a0-71f1-48ee-9984-08d7f685ceba X-MS-TrafficTypeDiagnostic: MWHPR11MB1741: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:6108; X-Forefront-PRVS: 0401647B7F X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: zIc3LJ26YuJMdah/yPwd0myYlPLwoIh4hk+inL7FV+6Xz5J22VNOPVnFqpsUAbPF/ygxJ+i9TpDeMGDQcewrhtdMKfqt5scJ9F+7D2Kys6nIAkQVC1xuJXxOWKqIM4AVYWKLcfniLx6kCtmhXdLorQ6obwRiPUGEPknuuwmi1Yf+3crKG7UELkoeKlpuMNsNXEh+aV3cizgG2VHeFMj1McxtYktvJi/yz33EPEiVTAH+ufbJPScuUsUOZYEnGNM3jxIXWEzlpXObLXxn1utSJT8j5aDj6hnUvWKD9agLMRp1dCpiQSKsvFN3vo9s5e6IIs+PK/LqXYBXtuLrTDU+nOsRDCx4qmoVMhec5qudgjCBSRKKUw0mTEK3jYXRAlaNllOIlYH7iQlS9kaX0TUpnpD7B4q0Rv+pGZvrld3eB2G5/V1+BLJVnXogIEn6nlLZjgkyB0S5x5FaN/Sy4h3xrGpTI06vDQvqaYEXAB33k/PmxGvdyfqH5dzNkrGtr6dS3GkVRR7NkAp2I4b6XRdc6w== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MWHPR11MB1775.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFTY:;SFS:(396003)(366004)(376002)(39860400002)(346002)(136003)(33430700001)(54906003)(107886003)(478600001)(8676002)(5660300002)(316002)(1076003)(956004)(8936002)(2616005)(186003)(2906002)(7696005)(86362001)(4326008)(52116002)(6666004)(6486002)(66476007)(66574014)(26005)(66946007)(66556008)(33440700001)(16526019)(36756003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData: v2O4/zCuSXAlJ5oUGRhzZ2kSb7igwn2H32ZXXMhDpU7vtHVH9mFsab2Ku/YyZ0mZrZkpph1crGLKd07nJFqNs7RTRssuRvsR2u9hvv4EXB31N1HIju01CiTHOiX3THmbXyFmM80Dg9866Wd0GuVJl5aMurSkkkX3EB9VnItB5sR52HVsVvVeq3FTuRH6ifV2KCl03djvwxC8TQA/qHkIOneTasOj04RInH3cAGOmtvbRM2yV1Q0QDIZzb2HO8JT9GS8X416F+WKVlY7PWL+vdkNQcFEbhPVlu9m7tpKq1lpkNjc935k0dR1gkwKSYsu2nSS05n9KQyekC5yL+KsQdToRcWAqr8p67ZfYNv42TizGuapMoXrEcbMv+Z31cFC/lTa4lZ3ZWHjT3AlPLqnqectibRTmYIbe3QDUyNvy17LfJHObMdDxrLA0Yp4EZWMOFotsNWLmNeUsfOz3Tot3Ln2k/uXVTqxUlslQ7mavYyE= X-OriginatorOrg: silabs.com X-MS-Exchange-CrossTenant-Network-Message-Id: d832b7a0-71f1-48ee-9984-08d7f685ceba X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 May 2020 15:04:45.7772 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 54dbd822-5231-4b20-944d-6f4abcd541fb X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: E73iJc2s7XrX9FxxcqFjzOqauCer3FUqsCTL8R/8VHBTZFtpfSG2HsVUdhyB9qNG03iWxEzDJ23ESOCZD6ThXg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR11MB1741 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Jérôme Pouiller The attribute ps_mode_error is little-endian. We have to take to the endianness when we access it. Signed-off-by: Jérôme Pouiller --- drivers/staging/wfx/hif_rx.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/staging/wfx/hif_rx.c b/drivers/staging/wfx/hif_rx.c index 83c3fdbb10fa..87d5107a7757 100644 --- a/drivers/staging/wfx/hif_rx.c +++ b/drivers/staging/wfx/hif_rx.c @@ -158,6 +158,7 @@ static int hif_event_indication(struct wfx_dev *wdev, { struct wfx_vif *wvif = wdev_to_wvif(wdev, hif->interface); const struct hif_ind_event *body = buf; + int cause; if (!wvif) { dev_warn(wdev->dev, "received event for non-existent vif\n"); @@ -176,10 +177,10 @@ static int hif_event_indication(struct wfx_dev *wdev, dev_dbg(wdev->dev, "ignore BSSREGAINED indication\n"); break; case HIF_EVENT_IND_PS_MODE_ERROR: + cause = le32_to_cpu(body->event_data.ps_mode_error); dev_warn(wdev->dev, "error while processing power save request: %d\n", - body->event_data.ps_mode_error); - if (body->event_data.ps_mode_error == - HIF_PS_ERROR_AP_NOT_RESP_TO_POLL) { + cause); + if (cause == HIF_PS_ERROR_AP_NOT_RESP_TO_POLL) { wvif->bss_not_support_ps_poll = true; schedule_work(&wvif->update_pm_work); }