From patchwork Tue May 12 15:04:01 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?b?SsOpcsO0bWUgUG91aWxsZXI=?= X-Patchwork-Id: 1288520 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming-netdev@ozlabs.org Delivered-To: patchwork-incoming-netdev@ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org (client-ip=23.128.96.18; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=silabs.com Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=silabs.onmicrosoft.com header.i=@silabs.onmicrosoft.com header.a=rsa-sha256 header.s=selector2-silabs-onmicrosoft-com header.b=k5rGYxww; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by ozlabs.org (Postfix) with ESMTP id 49M1LV2MN8z9sT5 for ; Wed, 13 May 2020 01:04:50 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730591AbgELPEr (ORCPT ); Tue, 12 May 2020 11:04:47 -0400 Received: from mail-bn8nam12on2076.outbound.protection.outlook.com ([40.107.237.76]:45896 "EHLO NAM12-BN8-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726055AbgELPEp (ORCPT ); Tue, 12 May 2020 11:04:45 -0400 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Vf/tPX7GGR1Kex8J6fktffhE8mGBUJd+6sdcuzYuJTixlRPIGMa+6FdvI5+jp78KQGWVAgoHu+cycEa0YCcWXe05h3tG2N7mprag/V0i3nRsoq6m15QsC7tzbQmZ6u+Qgzc/uxAlJjQ6iMK5lS1T/iIy2btR3r0T4ps2tekqvPe0LZFr8yJXkKsffS/aAT0O440AqJxXVGk3Ez9mlvtkT3dLpeAjh6CRpqXmTdi4CbF/Hm9bBwsirNsbZ7EFGlxlla/5fepwU2K3Rd4oBpm09yn9JFq6QR7xAtSfSnmpa/Eag2OWaHAg+ml24P1PUocXQVqHIehxHN0uDi4A2UtOlg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=rPxBtvqIwHnq/ZQoTtQPNlMQH3kPLlBXxz1s9sW4W/0=; b=MYIo/K1wbQN3wGXMunR5QYn1abqsRHwwWTMQYdi+D4rqEZiyOI5bIeywPvmq9j5mpmp51HWJoLIcwz7Ui7xy0q9OxDUQAEG7y56sVpt+spqMeo/JvCi7RGqTa+530MGI5g3NmymlkPutKvateOs1o61/xfaYlsBtCslxRtr7FZR930WTUuNy9uNICSbTq/wd1zxto9yplzJlHU31P3/ZDpy02FYuNkcB+38l8G0oqLDBOQ3CzPc5y6N63uRlYB394d3++fxQbIchK2sWc1rFFsXiL59WKMTvwkN1aLJejqoXhOgWxO7y9DG7CH+Qn6c1TW9xuO6/Cv2zvKua3qovIg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=silabs.com; dmarc=pass action=none header.from=silabs.com; dkim=pass header.d=silabs.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=silabs.onmicrosoft.com; s=selector2-silabs-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=rPxBtvqIwHnq/ZQoTtQPNlMQH3kPLlBXxz1s9sW4W/0=; b=k5rGYxww8M6aCZLzK4Jdde3JXDLHOjmbRNYF5hQcTX+ncslGV/5siphoxFqoLSBUbZwrH4u4s5eobt2L2ymQS2dKhI9KzuPgM8cqKEDuUpraVLRqm62HPlD87u71ZycGzMBTXz+iyl5f7at+H//uZKuoJNBnm3epC1IivofuBsI= Authentication-Results: driverdev.osuosl.org; dkim=none (message not signed) header.d=none;driverdev.osuosl.org; dmarc=none action=none header.from=silabs.com; Received: from MWHPR11MB1775.namprd11.prod.outlook.com (2603:10b6:300:10e::14) by MWHPR11MB1741.namprd11.prod.outlook.com (2603:10b6:300:10d::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2979.34; Tue, 12 May 2020 15:04:38 +0000 Received: from MWHPR11MB1775.namprd11.prod.outlook.com ([fe80::e055:3e6d:ff4:56da]) by MWHPR11MB1775.namprd11.prod.outlook.com ([fe80::e055:3e6d:ff4:56da%5]) with mapi id 15.20.2979.033; Tue, 12 May 2020 15:04:38 +0000 From: Jerome Pouiller To: devel@driverdev.osuosl.org, linux-wireless@vger.kernel.org Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Greg Kroah-Hartman , Kalle Valo , "David S . Miller" , =?utf-8?b?SsOpcsO0bWUgUG91aWxsZXI=?= Subject: [PATCH v2 04/17] staging: wfx: fix wrong bytes order Date: Tue, 12 May 2020 17:04:01 +0200 Message-Id: <20200512150414.267198-5-Jerome.Pouiller@silabs.com> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20200512150414.267198-1-Jerome.Pouiller@silabs.com> References: <20200512150414.267198-1-Jerome.Pouiller@silabs.com> X-ClientProxiedBy: DM5PR1101CA0003.namprd11.prod.outlook.com (2603:10b6:4:4c::13) To MWHPR11MB1775.namprd11.prod.outlook.com (2603:10b6:300:10e::14) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from pc-42.silabs.com (82.67.86.106) by DM5PR1101CA0003.namprd11.prod.outlook.com (2603:10b6:4:4c::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3000.20 via Frontend Transport; Tue, 12 May 2020 15:04:36 +0000 X-Mailer: git-send-email 2.26.2 X-Originating-IP: [82.67.86.106] X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: d9666882-58e7-4a94-921e-08d7f685ca0a X-MS-TrafficTypeDiagnostic: MWHPR11MB1741: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:1227; X-Forefront-PRVS: 0401647B7F X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: c051FrqUjQOXwMiHEp9ZMlSCkxOayoAUlfqsNgaWbdb5iwzy1OtEI3Mgo2ZTxkxb3Qb+wSQ3rh4/3LZLRM4VrW0EoWiGgRHHlKlEeYeNPA9dUVp2yjYNbkakMsW0evUCfedtd/mRI8p+FaoSWhYcdn8p3cFREtSecbA5dDTs+Yn40tv1GHvwlVOQ84JVC1sUmn+QpWzEvTHFq/tdUxf2+M0DorZFHhgt+XZvHIA7+ivDp2V/gy9iUF2dBUxYueocKu+SNRDnYZ69wigxn67AXgPP+P5iH0uQtZ/TNv5VD2hjBzTjD/LQWbgCYC/ZyxlKfY/+G6uzaivwJqxg2FT2VievSuCfdrie+BTCFDR+7CXOCjtP4hvdc5mEBV8v8ZhR2v1PBPlF6+yfFJSOs+bL/fThY598yqIKfZg3MxcXzS9DSnwovAVsmrL56sX6k0kNtWt4uVq79UiZc592tAJ3jf5HwOeCHMLaA/pUspeDXTBhmYIlJmyHF6EzEkcrdNnnjWLdxBvACgQ7eCrqbV2q0A== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MWHPR11MB1775.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFTY:;SFS:(396003)(366004)(376002)(39860400002)(346002)(136003)(33430700001)(54906003)(107886003)(4744005)(478600001)(8676002)(5660300002)(316002)(1076003)(956004)(8936002)(2616005)(186003)(2906002)(7696005)(86362001)(4326008)(52116002)(6666004)(6486002)(66476007)(66574014)(26005)(66946007)(66556008)(33440700001)(16526019)(36756003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData: 9pssZ5870fsn3O9xYJv9DnkuE5L2kR+DF+Owt6fJZyF4ROORMEL/+gG5XcsvfeVN3AGpT8dyaTwBfTmmsyozGsv0TswGRTPZqV12AhRjRqM06lIUk/lSWO6tsCPuK69cUKAhYeanm1shwZAk9FUPg4U0epRTE2x3xkuCGbbRLQKRllqTo86yzlICrKXZhg95WooW9ADDXZlvRp5iFd12rc/vZgau/QRt8RKWZo6Ircvfw6xk3f27+0oa6vYj6aPIOYdMLhROe4Vjc5i9O1t+U/AYUJY2aC0+hxxStTWlrPywKb4yPIipCpUhtOd6h6u/S5BMX9zz82K0M0TFzfjw3PXPEXOzO6a7KwGf4f26PGbx/UjAkClh3BN9XsrOUkC//lRbrC+w6W83v95AQuXhGtswEElpWTFHY3tJZ107JIgMN3jkkFsb6MkjTbjbBFbz9O2sGutHjRonnQkihTZ39TxATPt25Q8nFBfNSpfWoN4= X-OriginatorOrg: silabs.com X-MS-Exchange-CrossTenant-Network-Message-Id: d9666882-58e7-4a94-921e-08d7f685ca0a X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 May 2020 15:04:37.9117 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 54dbd822-5231-4b20-944d-6f4abcd541fb X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: F4JyeNt7PofbLdFfmM0lc17xpDM2M4nAQnfNFWZNgVQU112T6LW5TZrkIMKZPSGNoB9MAH6lY/721F66uZg0NA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR11MB1741 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Jérôme Pouiller The field wakeup_period_max from struct hif_mib_beacon_wake_up_period is a u8. So, assigning it a __le16 produces a nasty bug on big-endian architectures. Signed-off-by: Jérôme Pouiller --- drivers/staging/wfx/hif_tx_mib.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/wfx/hif_tx_mib.c b/drivers/staging/wfx/hif_tx_mib.c index 65381b22437e..567c61d1fe2e 100644 --- a/drivers/staging/wfx/hif_tx_mib.c +++ b/drivers/staging/wfx/hif_tx_mib.c @@ -32,7 +32,7 @@ int hif_set_beacon_wakeup_period(struct wfx_vif *wvif, struct hif_mib_beacon_wake_up_period val = { .wakeup_period_min = dtim_interval, .receive_dtim = 0, - .wakeup_period_max = cpu_to_le16(listen_interval), + .wakeup_period_max = listen_interval, }; if (dtim_interval > 0xFF || listen_interval > 0xFFFF)