From patchwork Tue May 12 15:04:12 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?b?SsOpcsO0bWUgUG91aWxsZXI=?= X-Patchwork-Id: 1288529 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming-netdev@ozlabs.org Delivered-To: patchwork-incoming-netdev@ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org (client-ip=23.128.96.18; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=silabs.com Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=silabs.onmicrosoft.com header.i=@silabs.onmicrosoft.com header.a=rsa-sha256 header.s=selector2-silabs-onmicrosoft-com header.b=GiDa4RAH; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by ozlabs.org (Postfix) with ESMTP id 49M1M96qYJz9sTK for ; Wed, 13 May 2020 01:05:25 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730823AbgELPFS (ORCPT ); Tue, 12 May 2020 11:05:18 -0400 Received: from mail-eopbgr770070.outbound.protection.outlook.com ([40.107.77.70]:42722 "EHLO NAM02-SN1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1730801AbgELPFL (ORCPT ); Tue, 12 May 2020 11:05:11 -0400 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=mTQ+VSRA7NCDNemq4TMRRiF2vDQTvVq/HrJz+385vX+hSvsqU1HFAv4W9DJJiRGPYd9myQNpv6JfPoNprzz2f18/wvqfEvVUcUq5FKwTNpilQJmL4UtrhdaWueoQ8moHcDegEIWSsbfISAx39whTmYdfiJQV8bQAHfnr0GpCwDMXj6U6C/o55PMonNnRdq3a2rqo9QAx4AFo0qw5EzEnRAkc9AmA0RyQ4R6ieWjy43d1xdOPj0O5qy+QP77GXthnzbykFQxOM/5cAEPE0+e/+3ICJbEw3rYO3msd/VY36ZHiT49CY7WKy/I4kdx2faJUnWXMP1T54l5OOAMWy9XTQg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=pFy/vniKhrpxtq/YSZf0zFvIVPUCYROviEhpqdga+Vg=; b=S2ZIFcSHdNRAYzmnX/UayItW5Ktj4AVwYI7j5uNlgEjEuJSO1CPIjHg0apoigj5FqBDTSMf2fr4SgBJt5RX8cJmW6CbRyPkHdXVTIl8GeRoYdBKn+JDGajkS9vz17OSdiOuWXEnI7NiUU7tnIrMz0JlyoCRvWhrDAWpmvqoyxJJrgxdPAOyfv+uXpA2uHyqAHG1N2O/RjVdpamIPEBQ6YGQ6xMlKnzKQzj++Fx1YKAqqNudoaeDRU5VxTqr1LJP2CF74iV7VyeSR+0F3Dvtm5Nt7EsIreKTk8ZZuANYk3gSVKly4oio9XaV7aAyObBKpJFFR5m05nGcRNw6Fd7jntw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=silabs.com; dmarc=pass action=none header.from=silabs.com; dkim=pass header.d=silabs.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=silabs.onmicrosoft.com; s=selector2-silabs-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=pFy/vniKhrpxtq/YSZf0zFvIVPUCYROviEhpqdga+Vg=; b=GiDa4RAHlN4KvRMYJ7NOhmaXI0faXX+qkrADPxbfvufXSfmnICubywr6GIGxC+tzYJjG8n1J0Hs21+Qj0bIsHW7YO+yRT8YmGYrDTH5TNwbRmWAQDYiPJsV8+M6wGFEWKVu4pQMVgsyLtHgqDrFwf5JxMsc4VMjAQpFNJOLrMt8= Authentication-Results: driverdev.osuosl.org; dkim=none (message not signed) header.d=none;driverdev.osuosl.org; dmarc=none action=none header.from=silabs.com; Received: from MWHPR11MB1775.namprd11.prod.outlook.com (2603:10b6:300:10e::14) by MWHPR11MB1741.namprd11.prod.outlook.com (2603:10b6:300:10d::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2979.34; Tue, 12 May 2020 15:05:00 +0000 Received: from MWHPR11MB1775.namprd11.prod.outlook.com ([fe80::e055:3e6d:ff4:56da]) by MWHPR11MB1775.namprd11.prod.outlook.com ([fe80::e055:3e6d:ff4:56da%5]) with mapi id 15.20.2979.033; Tue, 12 May 2020 15:05:00 +0000 From: Jerome Pouiller To: devel@driverdev.osuosl.org, linux-wireless@vger.kernel.org Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Greg Kroah-Hartman , Kalle Valo , "David S . Miller" , =?utf-8?b?SsOpcsO0bWUgUG91aWxsZXI=?= Subject: [PATCH v2 15/17] staging: wfx: fix endianness of the field 'num_tx_confs' Date: Tue, 12 May 2020 17:04:12 +0200 Message-Id: <20200512150414.267198-16-Jerome.Pouiller@silabs.com> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20200512150414.267198-1-Jerome.Pouiller@silabs.com> References: <20200512150414.267198-1-Jerome.Pouiller@silabs.com> X-ClientProxiedBy: DM5PR1101CA0003.namprd11.prod.outlook.com (2603:10b6:4:4c::13) To MWHPR11MB1775.namprd11.prod.outlook.com (2603:10b6:300:10e::14) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from pc-42.silabs.com (82.67.86.106) by DM5PR1101CA0003.namprd11.prod.outlook.com (2603:10b6:4:4c::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3000.20 via Frontend Transport; Tue, 12 May 2020 15:04:58 +0000 X-Mailer: git-send-email 2.26.2 X-Originating-IP: [82.67.86.106] X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 864b8fe5-38eb-4b56-8637-08d7f685d720 X-MS-TrafficTypeDiagnostic: MWHPR11MB1741: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:4125; X-Forefront-PRVS: 0401647B7F X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: RzI0REGWeXkaqz72sghLZsSqEeuf7YOhctLA7/iiIXi+HaWX5YKMwinCs8xhte/osk80MSVnij7FqvJvjd5pMGS/K1vjBEV802JDS2PmNI8Ip/lzmjuWoaVq182lAqCJd53NRJRkP71AgI6Wt+Ma9dt3CimGAquLgkq/XP+LzG007tQA6tmLIOH7KlWZERUjJuu42DX4wLODSUDPC4yKc30Fmjuu/H+kj8wg9DwUaBM4dAEFfFhm+EcozIhgA71C+cXj5f3RBeRwOR0NZmsqjtNZl3CdC/8cvc76h3eQK1NnG/K4CaH07o2nBG3YWRDA0JUTkQo4XVfUfgyXWEvoNY/EnS0sEgJqcNg0BXumdZK6CAuv/UNq2sQkcjYnDzyV8fugHqnE4s1s6jjFx7on4HeB036+xzGO/C67J+3/POt1ScTX6VBwsAWZYOQJooiVhngrjxoAwFijebUTuH610E+MP42ShF4Zy9+T7DgwG5+mY+9UNc/D2VqAeck59IzlKhqcoVFOBwUqdU/ObVICGw== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MWHPR11MB1775.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFTY:;SFS:(396003)(366004)(376002)(39860400002)(346002)(136003)(33430700001)(54906003)(107886003)(478600001)(8676002)(5660300002)(316002)(1076003)(956004)(8936002)(2616005)(186003)(2906002)(7696005)(86362001)(4326008)(52116002)(6666004)(6486002)(66476007)(66574014)(26005)(66946007)(66556008)(33440700001)(16526019)(36756003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData: YrVOBUfyVjsL+2CdBucnCal0dzs3j2B3YjjtRSNsZRBXrW+q/IT/hVkqfX3UUH2wWITzHgCHpR/Hv3dl8DaMP6GN/wz+/jbt+N57yr1m7oCufw0KgDgZzhtpz/hi+EyfLCKM0CGZWN/DbjhAkYYp6ZD9DDfHyQGkGmsFBigQPpm7w+R3QguJHS3oz8KkjL1t//XVdShDe8FwcAxVL4MEXI4ohj4dsu3df3gKFQDR0d9HqgUkA/kRecfdsLa0In+um8vcisBfnKhhX1o3f+m6YZj0nWB4vHBJrmKwlZMbDqFqc3WFHYpT7Ztesz7oVdz9ZdIOVTUSdHVWlDU8lKpBNzbJtDloByK+AEu45HLZDPS6spX+nBTlkPtgFFjLCV6ssKrUoWS0JZVXJUlxPQ4fHs1VyRk0otOhKkjI3UATbg1DCkW/TVJYD0+MA5K3+Msi/2QZPaxe7B0dR7YviHCUX5hdpWrLvnbQwQa11AqxZTY= X-OriginatorOrg: silabs.com X-MS-Exchange-CrossTenant-Network-Message-Id: 864b8fe5-38eb-4b56-8637-08d7f685d720 X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 May 2020 15:04:59.9009 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 54dbd822-5231-4b20-944d-6f4abcd541fb X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: OnahC/fjdeh1/HSztBFZovG7+WJuB4sUEFrz3VPJRnDh7pmmv0AlmQZqPqUI/NUWNXq98UN+j4XEe30qI79GXA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR11MB1741 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Jérôme Pouiller The field 'num_tx_confs' from the struct hif_cnf_multi_transmit is a __le32. Sparse complains this field is not always correctly accessed: drivers/staging/wfx/hif_rx.c:82:9: warning: restricted __le32 degrades to integer drivers/staging/wfx/hif_rx.c:87:29: warning: restricted __le32 degrades to integer However, the value of num_tx_confs cannot be greater than 15. So, we only have to access to the least significant byte. It is finally easier to declare it as an array of bytes and only access to the first one. Signed-off-by: Jérôme Pouiller --- drivers/staging/wfx/bh.c | 2 +- drivers/staging/wfx/hif_api_cmd.h | 3 ++- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/staging/wfx/bh.c b/drivers/staging/wfx/bh.c index 6c6e29cb7dcf..1cbaf8bb4fa3 100644 --- a/drivers/staging/wfx/bh.c +++ b/drivers/staging/wfx/bh.c @@ -102,7 +102,7 @@ static int rx_helper(struct wfx_dev *wdev, size_t read_len, int *is_cnf) if (!(hif->id & HIF_ID_IS_INDICATION)) { (*is_cnf)++; if (hif->id == HIF_CNF_ID_MULTI_TRANSMIT) - release_count = le32_to_cpu(((struct hif_cnf_multi_transmit *)hif->body)->num_tx_confs); + release_count = ((struct hif_cnf_multi_transmit *)hif->body)->num_tx_confs; else release_count = 1; WARN(wdev->hif.tx_buffers_used < release_count, "corrupted buffer counter"); diff --git a/drivers/staging/wfx/hif_api_cmd.h b/drivers/staging/wfx/hif_api_cmd.h index d76722bff7ee..8c48477e8797 100644 --- a/drivers/staging/wfx/hif_api_cmd.h +++ b/drivers/staging/wfx/hif_api_cmd.h @@ -280,7 +280,8 @@ struct hif_cnf_tx { } __packed; struct hif_cnf_multi_transmit { - __le32 num_tx_confs; + u8 num_tx_confs; + u8 reserved[3]; struct hif_cnf_tx tx_conf_payload[]; } __packed;