From patchwork Mon May 11 15:49:17 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?b?SsOpcsO0bWUgUG91aWxsZXI=?= X-Patchwork-Id: 1287890 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming-netdev@ozlabs.org Delivered-To: patchwork-incoming-netdev@ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org (client-ip=23.128.96.18; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=silabs.com Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=silabs.onmicrosoft.com header.i=@silabs.onmicrosoft.com header.a=rsa-sha256 header.s=selector2-silabs-onmicrosoft-com header.b=flBbnpcc; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by ozlabs.org (Postfix) with ESMTP id 49LQQv0y6Wz9sTS for ; Tue, 12 May 2020 01:51:35 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730539AbgEKPuC (ORCPT ); Mon, 11 May 2020 11:50:02 -0400 Received: from mail-mw2nam12on2062.outbound.protection.outlook.com ([40.107.244.62]:10442 "EHLO NAM12-MW2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1730489AbgEKPt4 (ORCPT ); Mon, 11 May 2020 11:49:56 -0400 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=M5zQJiSpH9hlmGYuOWqXLa/6Pbpkno6QDK7urHKxs+AHLuLGT8heOJK6Idf0XsrO9bA8f7/BUInAyOuoTGvxvJQsqfQgJgl2oCeFyyLUPRBk2hUayJmbPFqmdWKxqVnqfdD2rzfan3u2ZXoAcCasXGmpytakj+JqHIc43HSNxuwIWMcuuWcp1F/tmwIcxpHJ1UEb8p8YzCkPFtJYKI7AsLy6fdIE5NpuNcmbmdf77boloRRUL5Ezxvbc7VdAkJ23pGEETKkyRALLNWM1+qdgrW7ZoQ38mYLe4GIQ/O8FaZYXBMT3Iyg51P/GFkCrCATjOInveoka0GsGB2GZkQPBUQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=rPxBtvqIwHnq/ZQoTtQPNlMQH3kPLlBXxz1s9sW4W/0=; b=IA68AMITDxsdWrLpWpPOrPSe7KPH0sV6KCnK4LxOMFp1d+RRXmf7PZjUIcepf9cjE1eVTVe1IuRNM9IJmNYnGeR4Dk5KrYtqLm6Yw+IMbhTCtKDMi+RcLzKGJ5GfmwXycMF+EZV68lyYvwjLVcORz9v7zug1ikWSkdjfVW3RYpCrTljdHXY2+XKu5kReXBgqGt/Ep5ZmtcCHz25VT35eAoCtxOyY7ub3/3ZJK/jWNUs8x/4r+E9CHn0Im65rSUwym34fER0j3HGHRmIsFvbk3B27gCeVQzwb98aFu4XS3t8M6w812NVTWCXZjnPEPqKOr1VOHpA2fu8fcqmsQQwC8A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=silabs.com; dmarc=pass action=none header.from=silabs.com; dkim=pass header.d=silabs.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=silabs.onmicrosoft.com; s=selector2-silabs-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=rPxBtvqIwHnq/ZQoTtQPNlMQH3kPLlBXxz1s9sW4W/0=; b=flBbnpccrZxPTfpAQERR0JATmVAfgOVR3BtVqwGNV5HfOknYHq6r1mJNRVB4q9pbbK2tRluiWZ68Za1Diny/I2OQ/ihf3l7JPudye1t4QAFDyU5rdIXJiRq7VLlXqYmq7Ier5fFPEVNq3HweYC0Lt9FsAaQlaViqUipnGhr9edE= Authentication-Results: driverdev.osuosl.org; dkim=none (message not signed) header.d=none;driverdev.osuosl.org; dmarc=none action=none header.from=silabs.com; Received: from MWHPR11MB1775.namprd11.prod.outlook.com (2603:10b6:300:10e::14) by MWHPR11MB1968.namprd11.prod.outlook.com (2603:10b6:300:113::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2979.26; Mon, 11 May 2020 15:49:53 +0000 Received: from MWHPR11MB1775.namprd11.prod.outlook.com ([fe80::e055:3e6d:ff4:56da]) by MWHPR11MB1775.namprd11.prod.outlook.com ([fe80::e055:3e6d:ff4:56da%5]) with mapi id 15.20.2979.033; Mon, 11 May 2020 15:49:53 +0000 From: Jerome Pouiller To: devel@driverdev.osuosl.org, linux-wireless@vger.kernel.org Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Greg Kroah-Hartman , Kalle Valo , "David S . Miller" , =?utf-8?b?SsOpcsO0bWUgUG91aWxsZXI=?= Subject: [PATCH 04/17] staging: wfx: fix wrong bytes order Date: Mon, 11 May 2020 17:49:17 +0200 Message-Id: <20200511154930.190212-5-Jerome.Pouiller@silabs.com> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20200511154930.190212-1-Jerome.Pouiller@silabs.com> References: <20200511154930.190212-1-Jerome.Pouiller@silabs.com> X-ClientProxiedBy: SN6PR2101CA0026.namprd21.prod.outlook.com (2603:10b6:805:106::36) To MWHPR11MB1775.namprd11.prod.outlook.com (2603:10b6:300:10e::14) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from pc-42.silabs.com (82.67.86.106) by SN6PR2101CA0026.namprd21.prod.outlook.com (2603:10b6:805:106::36) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3021.2 via Frontend Transport; Mon, 11 May 2020 15:49:51 +0000 X-Mailer: git-send-email 2.26.2 X-Originating-IP: [82.67.86.106] X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 6feee6a4-3db7-43bd-aa73-08d7f5c2f1ef X-MS-TrafficTypeDiagnostic: MWHPR11MB1968: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:1227; X-Forefront-PRVS: 04004D94E2 X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: OQdOT36REMq03/301w4IvTlUqBH4NGn6xD0E19PP1NP1PUpZgxP4tMaXa1/tGUcOAbS/UD8EH3GbnN0KIheCPoxlrC9A1ovmyG08OiysDS9EbgU+KO75zsuLU/XCmMoc7CeUi05rKvot9XIYF2ptNalhw/SAqAYjBCxoG1lijIaCJpUA0dxI3ft99ooIsl42Y1LNf841Z4nf8xcoX6tt3iq3Gkqpo/O1oa+0m6fZtfro2VFemkdgkvAme85yFHceaHGft/OH8Q8rObMjEmHOuGJMMAlJ12hcf9fQpOqxqahThOeUkNEfgjSvAxgA4i04SZPwLJmv7Nn9XzD93bsi6lvpJOFCl3S0ch0cb1pbe9JVsabATqvhbu3vHW0/BODuQ0kRxbTJUG7cpgarbjZG/bHTE6DRT/MmFy2QUH/sCYwcZhNK4F/40eTPGesbWPLpAnV1gW8RrISwSgiQIpAF07HGi+MJdgvU4Q7Oc/3FI1ghBmcmwRhibGEw8Y8aU5cVcUUzif+X0lnsQsIO4ywuuA== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MWHPR11MB1775.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFTY:;SFS:(39850400004)(346002)(136003)(396003)(376002)(366004)(33430700001)(186003)(52116002)(86362001)(316002)(5660300002)(7696005)(6486002)(33440700001)(478600001)(54906003)(6666004)(4326008)(107886003)(66574014)(36756003)(16526019)(26005)(8936002)(956004)(2616005)(8676002)(1076003)(66476007)(66946007)(66556008)(4744005)(2906002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData: 3nm5VXezN/ooj0A0VXy8I/NI9Q3ftGFpIthZD0dV43r+UizdDdYKiSiSLRAg4NRtiZMqS9qn7nv6+Dk70FU/n9puqwogyI+01EJOi8RmtnDDGIEFOSgwuKEvLqc8EWcfvtVoTC9c8bfK09kh4D3dDNGiUIfceoB4fha48VWZGCCz95a8qqrpBVAfSMQXFjO3ExkoKg9nu8B9TUEc1UsjrZClvL+nnVZINcDJxYbpx3Ns9JRSyZ5utg3EdWcdnxVQvBdS0EYGqK5K+yDb0GMi6P7RihcbhMTQ1DpFbxDfvXfou8GvHkh1rjRg436SotYFRdvh4zVZ4dhYEjI9ElBuDMn2aUsrWi2FMYwwg6KxoreFTJL35LyTZ5NxNKG4/5R+uh2MTn/YCrarhQv+lLqudCafuN9ogHZzuGzGQBlMDTKD6pRxwaoXAjeybwF/vNlDlMFsfzug2Q+VTOHY3At9rZBkx+JsS+ZZ99zjHVKYLxA= X-OriginatorOrg: silabs.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6feee6a4-3db7-43bd-aa73-08d7f5c2f1ef X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 May 2020 15:49:53.0549 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 54dbd822-5231-4b20-944d-6f4abcd541fb X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: KiHkIxJSJifUMye9Djzi2PcYjncj0lO8eUroWd1mm52QY7mg86mXB5p6PVYzz8+r3x1EpeGnkghy1P8mv4Drmw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR11MB1968 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Jérôme Pouiller The field wakeup_period_max from struct hif_mib_beacon_wake_up_period is a u8. So, assigning it a __le16 produces a nasty bug on big-endian architectures. Signed-off-by: Jérôme Pouiller --- drivers/staging/wfx/hif_tx_mib.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/wfx/hif_tx_mib.c b/drivers/staging/wfx/hif_tx_mib.c index 65381b22437e..567c61d1fe2e 100644 --- a/drivers/staging/wfx/hif_tx_mib.c +++ b/drivers/staging/wfx/hif_tx_mib.c @@ -32,7 +32,7 @@ int hif_set_beacon_wakeup_period(struct wfx_vif *wvif, struct hif_mib_beacon_wake_up_period val = { .wakeup_period_min = dtim_interval, .receive_dtim = 0, - .wakeup_period_max = cpu_to_le16(listen_interval), + .wakeup_period_max = listen_interval, }; if (dtim_interval > 0xFF || listen_interval > 0xFFFF)