Message ID | 20200505132809.17655-1-geert+renesas@glider.be |
---|---|
State | Accepted |
Delegated to: | David Miller |
Headers | show |
Series | [v2] ionic: Use debugfs_create_bool() to export bool | expand |
From: Geert Uytterhoeven <geert+renesas@glider.be> Date: Tue, 5 May 2020 15:28:09 +0200 > Currently bool ionic_cq.done_color is exported using > debugfs_create_u8(), which requires a cast, preventing further compiler > checks. > > Fix this by switching to debugfs_create_bool(), and dropping the cast. > > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> > Acked-by: Shannon Nelson <snelson@pensando.io> Applied, thanks.
diff --git a/drivers/net/ethernet/pensando/ionic/ionic_debugfs.c b/drivers/net/ethernet/pensando/ionic/ionic_debugfs.c index 5f8fc58d42b3d31c..11621ccc1faf0837 100644 --- a/drivers/net/ethernet/pensando/ionic/ionic_debugfs.c +++ b/drivers/net/ethernet/pensando/ionic/ionic_debugfs.c @@ -170,8 +170,7 @@ void ionic_debugfs_add_qcq(struct ionic_lif *lif, struct ionic_qcq *qcq) debugfs_create_x64("base_pa", 0400, cq_dentry, &cq->base_pa); debugfs_create_u32("num_descs", 0400, cq_dentry, &cq->num_descs); debugfs_create_u32("desc_size", 0400, cq_dentry, &cq->desc_size); - debugfs_create_u8("done_color", 0400, cq_dentry, - (u8 *)&cq->done_color); + debugfs_create_bool("done_color", 0400, cq_dentry, &cq->done_color); debugfs_create_file("tail", 0400, cq_dentry, cq, &cq_tail_fops);