| Message ID | 20200505123757.39506-4-Jerome.Pouiller@silabs.com |
|---|---|
| State | Not Applicable |
| Delegated to: | David Miller |
| Headers | show |
| Series | staging: wfx: fix Out-Of-Band IRQ | expand |
On Tue, May 05, 2020 at 02:37:45PM +0200, Jerome Pouiller wrote: > From: Jérôme Pouiller <jerome.pouiller@silabs.com> > > In case of error in wfx_probe(), wdev->hw is freed. Since an error > occurred, wfx_free_common() is called, then wdev->hw is freed again. > > Cc: Michał Mirosław <mirq-linux@rere.qmqm.pl> > Signed-off-by: Jérôme Pouiller <jerome.pouiller@silabs.com> > --- > drivers/staging/wfx/main.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/staging/wfx/main.c b/drivers/staging/wfx/main.c > index ba2e3a6b3549..5d0754b55429 100644 > --- a/drivers/staging/wfx/main.c > +++ b/drivers/staging/wfx/main.c > @@ -469,7 +469,6 @@ int wfx_probe(struct wfx_dev *wdev) > > err2: > ieee80211_unregister_hw(wdev->hw); > - ieee80211_free_hw(wdev->hw); > err1: > wfx_bh_unregister(wdev); > return err; Reviewed-by: Michał Mirosław <mirq-linux@rere.qmqm.pl> Fixes: 4033714d6cbe ("staging: wfx: fix init/remove vs IRQ race")
diff --git a/drivers/staging/wfx/main.c b/drivers/staging/wfx/main.c index ba2e3a6b3549..5d0754b55429 100644 --- a/drivers/staging/wfx/main.c +++ b/drivers/staging/wfx/main.c @@ -469,7 +469,6 @@ int wfx_probe(struct wfx_dev *wdev) err2: ieee80211_unregister_hw(wdev->hw); - ieee80211_free_hw(wdev->hw); err1: wfx_bh_unregister(wdev); return err;