Message ID | 20200505074556.22331-1-yanaijie@huawei.com |
---|---|
State | Accepted |
Delegated to: | David Miller |
Headers | show |
Series | [net-next] net: agere: use true,false for bool variable | expand |
On Tue, 2020-05-05 at 15:45 +0800, Jason Yan wrote: > Fix the following coccicheck warning: > > drivers/net/ethernet/agere/et131x.c:717:3-22: WARNING: Assignment of > 0/1 to bool variable > drivers/net/ethernet/agere/et131x.c:721:1-20: WARNING: Assignment of > 0/1 to bool variable > > Signed-off-by: Jason Yan <yanaijie@huawei.com> Acked-by: Mark Einon <mark.einon@gmail.com>
From: Jason Yan <yanaijie@huawei.com> Date: Tue, 5 May 2020 15:45:56 +0800 > Fix the following coccicheck warning: > > drivers/net/ethernet/agere/et131x.c:717:3-22: WARNING: Assignment of > 0/1 to bool variable > drivers/net/ethernet/agere/et131x.c:721:1-20: WARNING: Assignment of > 0/1 to bool variable > > Signed-off-by: Jason Yan <yanaijie@huawei.com> Applied.
diff --git a/drivers/net/ethernet/agere/et131x.c b/drivers/net/ethernet/agere/et131x.c index 1b19385ad8a9..865892c1f23f 100644 --- a/drivers/net/ethernet/agere/et131x.c +++ b/drivers/net/ethernet/agere/et131x.c @@ -714,11 +714,11 @@ static int et131x_init_eeprom(struct et131x_adapter *adapter) * gather additional information that normally would * come from the eeprom, like MAC Address */ - adapter->has_eeprom = 0; + adapter->has_eeprom = false; return -EIO; } } - adapter->has_eeprom = 1; + adapter->has_eeprom = true; /* Read the EEPROM for information regarding LED behavior. Refer to * et131x_xcvr_init() for its use.
Fix the following coccicheck warning: drivers/net/ethernet/agere/et131x.c:717:3-22: WARNING: Assignment of 0/1 to bool variable drivers/net/ethernet/agere/et131x.c:721:1-20: WARNING: Assignment of 0/1 to bool variable Signed-off-by: Jason Yan <yanaijie@huawei.com> --- drivers/net/ethernet/agere/et131x.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)