diff mbox series

[net-next,2/3] qede: Cache num configured VFs on a PF.

Message ID 20200421145300.16278-3-skalluru@marvell.com
State Changes Requested
Delegated to: David Miller
Headers show
Series [net-next,1/3] qed: Enable device error reporting capability. | expand

Commit Message

Sudarsana Reddy Kalluru April 21, 2020, 2:52 p.m. UTC 
The patch add changes to cache the number of VFs configured on a PF.

Signed-off-by: Sudarsana Reddy Kalluru <skalluru@marvell.com>
Signed-off-by: Ariel Elior <aelior@marvell.com>
Signed-off-by: Igor Russkikh <irusskikh@marvell.com>
---
 drivers/net/ethernet/qlogic/qede/qede.h      |  1 +
 drivers/net/ethernet/qlogic/qede/qede_main.c | 15 +++++++++------
 2 files changed, 10 insertions(+), 6 deletions(-)

Comments

Jakub Kicinski April 21, 2020, 6:30 p.m. UTC | #1 
On Tue, 21 Apr 2020 07:52:59 -0700 Sudarsana Reddy Kalluru wrote:
> The patch add changes to cache the number of VFs configured on a PF.

Please use pci_num_vf() instead.
Sudarsana Reddy Kalluru April 22, 2020, 11:49 a.m. UTC | #2 
> -----Original Message-----
> From: netdev-owner@vger.kernel.org <netdev-owner@vger.kernel.org> On
> Behalf Of Jakub Kicinski
> Sent: Wednesday, April 22, 2020 12:00 AM
> To: Sudarsana Reddy Kalluru <skalluru@marvell.com>
> Cc: davem@davemloft.net; netdev@vger.kernel.org; Ariel Elior
> <aelior@marvell.com>; Igor Russkikh <irusskikh@marvell.com>; Michal
> Kalderon <mkalderon@marvell.com>
> Subject: Re: [PATCH net-next 2/3] qede: Cache num configured VFs on a PF.
> 
> On Tue, 21 Apr 2020 07:52:59 -0700 Sudarsana Reddy Kalluru wrote:
> > The patch add changes to cache the number of VFs configured on a PF.
> 
> Please use pci_num_vf() instead.

Thanks for your review and inputs. Will use pci API and drop the current patch.
diff mbox series

Patch

diff --git a/drivers/net/ethernet/qlogic/qede/qede.h b/drivers/net/ethernet/qlogic/qede/qede.h
index 234c6f3..bf8b8ad 100644
--- a/drivers/net/ethernet/qlogic/qede/qede.h
+++ b/drivers/net/ethernet/qlogic/qede/qede.h
@@ -198,6 +198,7 @@  struct qede_dev {
 	struct net_device		*ndev;
 	struct pci_dev			*pdev;
 
+	int				num_vfs;
 	u32				dp_module;
 	u8				dp_level;
 
diff --git a/drivers/net/ethernet/qlogic/qede/qede_main.c b/drivers/net/ethernet/qlogic/qede/qede_main.c
index 34fa391..9c4d9cd 100644
--- a/drivers/net/ethernet/qlogic/qede/qede_main.c
+++ b/drivers/net/ethernet/qlogic/qede/qede_main.c
@@ -190,12 +190,15 @@  static int qede_sriov_configure(struct pci_dev *pdev, int num_vfs_param)
 	rc = edev->ops->iov->configure(edev->cdev, num_vfs_param);
 
 	/* Enable/Disable Tx switching for PF */
-	if ((rc == num_vfs_param) && netif_running(edev->ndev) &&
-	    !qed_info->b_inter_pf_switch && qed_info->tx_switching) {
-		vport_params->vport_id = 0;
-		vport_params->update_tx_switching_flg = 1;
-		vport_params->tx_switching_flg = num_vfs_param ? 1 : 0;
-		edev->ops->vport_update(edev->cdev, vport_params);
+	if (rc == num_vfs_param) {
+		edev->num_vfs = rc;
+		if (netif_running(edev->ndev) &&
+		    !qed_info->b_inter_pf_switch && qed_info->tx_switching) {
+			vport_params->vport_id = 0;
+			vport_params->update_tx_switching_flg = 1;
+			vport_params->tx_switching_flg = num_vfs_param ? 1 : 0;
+			edev->ops->vport_update(edev->cdev, vport_params);
+		}
 	}
 
 	vfree(vport_params);