diff mbox series

[v2] net: phy: at803x: add support for AR8032 PHY

Message ID 20200417134159.427556-1-mail@david-bauer.net
State Accepted
Delegated to: David Miller
Headers show
Series [v2] net: phy: at803x: add support for AR8032 PHY | expand

Commit Message

David Bauer April 17, 2020, 1:41 p.m. UTC 
This adds support for the Qualcomm Atheros AR8032 Fast Ethernet PHY.

It shares many similarities with the already supported AR8030 PHY but
additionally supports MII connection to the MAC.

Signed-off-by: David Bauer <mail@david-bauer.net>
---
Accidentally sent a very old WIP as v1.

 drivers/net/phy/at803x.c | 17 +++++++++++++++++
 1 file changed, 17 insertions(+)

Comments

Andrew Lunn April 17, 2020, 3:54 p.m. UTC | #1 
On Fri, Apr 17, 2020 at 03:41:59PM +0200, David Bauer wrote:
> This adds support for the Qualcomm Atheros AR8032 Fast Ethernet PHY.
> 
> It shares many similarities with the already supported AR8030 PHY but
> additionally supports MII connection to the MAC.

Hi David

This looks good. However, next time please put in the patch subject
which tree this is for

[PATCH net-next 1/1]

Reviewed-by: Andrew Lunn <andrew@lunn.ch>

    Andrew
David Miller April 18, 2020, 10:46 p.m. UTC | #2 
From: David Bauer <mail@david-bauer.net>
Date: Fri, 17 Apr 2020 15:41:59 +0200

> This adds support for the Qualcomm Atheros AR8032 Fast Ethernet PHY.
> 
> It shares many similarities with the already supported AR8030 PHY but
> additionally supports MII connection to the MAC.
> 
> Signed-off-by: David Bauer <mail@david-bauer.net>

Applied to net-next, thanks.
diff mbox series

Patch

diff --git a/drivers/net/phy/at803x.c b/drivers/net/phy/at803x.c
index 31f731e6df72..31b6edcc1fd1 100644
--- a/drivers/net/phy/at803x.c
+++ b/drivers/net/phy/at803x.c
@@ -106,6 +106,7 @@ 
 #define ATH9331_PHY_ID 0x004dd041
 #define ATH8030_PHY_ID 0x004dd076
 #define ATH8031_PHY_ID 0x004dd074
+#define ATH8032_PHY_ID 0x004dd023
 #define ATH8035_PHY_ID 0x004dd072
 #define AT803X_PHY_ID_MASK			0xffffffef
 
@@ -762,6 +763,21 @@  static struct phy_driver at803x_driver[] = {
 	.aneg_done		= at803x_aneg_done,
 	.ack_interrupt		= &at803x_ack_interrupt,
 	.config_intr		= &at803x_config_intr,
+}, {
+	/* Qualcomm Atheros AR8032 */
+	PHY_ID_MATCH_EXACT(ATH8032_PHY_ID),
+	.name			= "Qualcomm Atheros AR8032",
+	.probe			= at803x_probe,
+	.remove			= at803x_remove,
+	.config_init		= at803x_config_init,
+	.link_change_notify	= at803x_link_change_notify,
+	.set_wol		= at803x_set_wol,
+	.get_wol		= at803x_get_wol,
+	.suspend		= at803x_suspend,
+	.resume			= at803x_resume,
+	/* PHY_BASIC_FEATURES */
+	.ack_interrupt		= at803x_ack_interrupt,
+	.config_intr		= at803x_config_intr,
 }, {
 	/* ATHEROS AR9331 */
 	PHY_ID_MATCH_EXACT(ATH9331_PHY_ID),
@@ -778,6 +794,7 @@  module_phy_driver(at803x_driver);
 static struct mdio_device_id __maybe_unused atheros_tbl[] = {
 	{ ATH8030_PHY_ID, AT803X_PHY_ID_MASK },
 	{ ATH8031_PHY_ID, AT803X_PHY_ID_MASK },
+	{ PHY_ID_MATCH_EXACT(ATH8032_PHY_ID) },
 	{ ATH8035_PHY_ID, AT803X_PHY_ID_MASK },
 	{ PHY_ID_MATCH_EXACT(ATH9331_PHY_ID) },
 	{ }