From patchwork Wed Apr 15 16:11:34 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?b?SsOpcsO0bWUgUG91aWxsZXI=?= X-Patchwork-Id: 1271291 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming-netdev@ozlabs.org Delivered-To: patchwork-incoming-netdev@ozlabs.org Authentication-Results: ozlabs.org; spf=none (no SPF record) smtp.mailfrom=vger.kernel.org (client-ip=23.128.96.18; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=silabs.com Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=silabs.onmicrosoft.com header.i=@silabs.onmicrosoft.com header.a=rsa-sha256 header.s=selector2-silabs-onmicrosoft-com header.b=HtL7udRE; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by ozlabs.org (Postfix) with ESMTP id 492S7T47kRz9s71 for ; Thu, 16 Apr 2020 02:12:53 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2410285AbgDOQMw (ORCPT ); Wed, 15 Apr 2020 12:12:52 -0400 Received: from mail-eopbgr700062.outbound.protection.outlook.com ([40.107.70.62]:8193 "EHLO NAM04-SN1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1415220AbgDOQMr (ORCPT ); Wed, 15 Apr 2020 12:12:47 -0400 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=JD2e5sQ6FZHVCwIMlv9V7X2CjTTpGbUQTDzAHJn+0NJ+mgwwBxzUQtQFU1Yj2BsvDtIQKfiQ2QQ7kiBNZ6yjjzFkZn32BMeZxjEJ3E/0DupTuKRYYfjmd4dBNmVlOfuYWcoy7sDlCxa0sukVw/nK+Xrq86T1n6fMU6PpFX/c4IPXBI+pwt8vla8E+mi/A5v7UBXm1ah7cG/TYqKAf6lIMkMGdVlG2dgan4vpKlXyUqlJHccnfx6tmONEZ1oDjdLgiUNFGXuoKZ1TiYTEAu/0W7ZxZGqH899b1LK3diINNhGnhSx9/IM9G2dgVeWnw7xrOwGmhu3neSVynqa1OxO86A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=E6OX1W7onu9BwtX+0JhnJiNxhM6fJv+4nlkSvTirURM=; b=FWAcTugUrYNhPiVXEwlAOrjxyPHPiw0zmVQxGvUKbXre9AcOYaZB/yUETB7XqlxYq/GWoSet1afIvdUk5jcrgIQfpS4V9/CcObAB/0ehbo+NU9PCi/hDrG9FdPunxl9S57acBMKotkAe0bYwWb7Yzmbf1wCs2C7IzKEYqmtLNEcIn38qLrCzUf6Qxz1mLwQwsSTyuULltcxEJrMbwLz2GHV3MDYDwOm4rwVb3GEeVQYG+BC3/7n0v8HT3fduxFigzHhUUaKemNGwgR4Eg3quX0U2N4YwMakpnyDAoX4v13zsUNja04JqQUut22nDZFVtv32Pml9A7XVVsjMqNN1ruA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=silabs.com; dmarc=pass action=none header.from=silabs.com; dkim=pass header.d=silabs.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=silabs.onmicrosoft.com; s=selector2-silabs-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=E6OX1W7onu9BwtX+0JhnJiNxhM6fJv+4nlkSvTirURM=; b=HtL7udRELjlxcqDbahkSTJwMi2StRzrdEyRPBki7GcbwB2y9ey5Q8BeEcuLDhfTF68hW5FL3ZE7xPjZdaUZxUBatYyp8yHZmPiGwRS5EbIIHDwS22rmgWf3mA8KqfcnXpGan2y3LgWKRZLmIwDxaTaypDNsrsh7LU6265+l1VQE= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Jerome.Pouiller@silabs.com; Received: from MWHPR11MB1775.namprd11.prod.outlook.com (2603:10b6:300:10e::14) by MWHPR11MB1408.namprd11.prod.outlook.com (2603:10b6:300:24::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2921.25; Wed, 15 Apr 2020 16:12:30 +0000 Received: from MWHPR11MB1775.namprd11.prod.outlook.com ([fe80::81d5:b62b:3770:ffbe]) by MWHPR11MB1775.namprd11.prod.outlook.com ([fe80::81d5:b62b:3770:ffbe%10]) with mapi id 15.20.2921.024; Wed, 15 Apr 2020 16:12:30 +0000 From: Jerome Pouiller To: devel@driverdev.osuosl.org, linux-wireless@vger.kernel.org Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Greg Kroah-Hartman , Kalle Valo , "David S . Miller" , =?utf-8?b?SsOpcsO0bWUgUG91aWxsZXI=?= Subject: [PATCH 07/20] staging: wfx: disabling beacon filtering after hif_reset() is useless Date: Wed, 15 Apr 2020 18:11:34 +0200 Message-Id: <20200415161147.69738-8-Jerome.Pouiller@silabs.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200415161147.69738-1-Jerome.Pouiller@silabs.com> References: <20200415161147.69738-1-Jerome.Pouiller@silabs.com> X-ClientProxiedBy: PR1PR01CA0027.eurprd01.prod.exchangelabs.com (2603:10a6:102::40) To MWHPR11MB1775.namprd11.prod.outlook.com (2603:10b6:300:10e::14) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from pc-42.home (2a01:e35:2435:66a0:544b:f17b:7ae8:fb7) by PR1PR01CA0027.eurprd01.prod.exchangelabs.com (2603:10a6:102::40) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2921.25 via Frontend Transport; Wed, 15 Apr 2020 16:12:27 +0000 X-Mailer: git-send-email 2.25.1 X-Originating-IP: [2a01:e35:2435:66a0:544b:f17b:7ae8:fb7] X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 38d0e700-0f87-4b41-c488-08d7e157cbdd X-MS-TrafficTypeDiagnostic: MWHPR11MB1408: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:130; X-Forefront-PRVS: 0374433C81 X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MWHPR11MB1775.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFTY:;SFS:(10009020)(136003)(396003)(376002)(346002)(39850400004)(366004)(8886007)(8936002)(4744005)(5660300002)(2906002)(6666004)(86362001)(8676002)(478600001)(81156014)(66574012)(1076003)(4326008)(52116002)(316002)(54906003)(107886003)(186003)(16526019)(66556008)(66476007)(36756003)(2616005)(6512007)(6486002)(6506007)(66946007);DIR:OUT;SFP:1101; Received-SPF: None (protection.outlook.com: silabs.com does not designate permitted sender hosts) X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: yGPm8TjpBbUcG+aKRVUuL1uxSMNnyYxSGuUpZ1ej+qW4hHqkNzhXvUkpXx84A62lm96teulsadV3AowZsk9z767TmoXo7IzzMb+790l1rb+G3G28Fi2gqEx8hKnp4KlM28YlMnA8GSGNFMMG0NJeGTjYQIN7V3lq+Gn6JKXRHqh7wrP6JgCDtlTpAfAwoAgDXZGnmmWhSh6etZkyeWh+e7h3iw3gRylnxfN4r+8Cv9PqOVJiM5FyXfbpa2F2hy3KxGGmuqNlv7fNaWIuFF2BlZfkQtCoklyp8xfQhpG81iD4DMhDPO0hy4aVIZgdpoD6mPODvhL3mWpptvMHyyGgR/2cmExXBoXhF+X85ef2lbKqos7qeOLtAo2LotIFekhRB1fTaJBTlMYW6+Xv64VDhZKVfjAwMs6+tyk2ZxrXLntiKyHaJWKMQu8WDxTucNWE X-MS-Exchange-AntiSpam-MessageData: N9Ms3ULfz4yoIvIAK5RFOLy8qu2jY9/TJNypSxnA64b5LJcPSSVC1YqWyi94k1SCq3+CA6Tz44eCqlV1Dy5JhsAE96sEx8uIbqlcmylz20/OfgQaxBokgURsRYNlw7/+mA5glZX+wIlWfItEGThHV8QZTHF6FAGQcalzQdv2gQxnumFawfmTpuPNQJzqB4BhNKonrarRQjMDweTLXvqXuA== X-OriginatorOrg: silabs.com X-MS-Exchange-CrossTenant-Network-Message-Id: 38d0e700-0f87-4b41-c488-08d7e157cbdd X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Apr 2020 16:12:29.9415 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 54dbd822-5231-4b20-944d-6f4abcd541fb X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: vlS1e7g0WZ6AFgoMf2vCU1QLfdWwIzK486drw2FJ6Mk4k+coP1SK1Z5XXibuQGVzNrCD/r5420+ZqCTcsdlEdA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR11MB1408 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Jérôme Pouiller After hif_reset(), device stop to receive any RF data. So, it is useless to disable beacon filtering. In add, if necessary, mac80211 will call wfx_configure_filter(). Signed-off-by: Jérôme Pouiller --- drivers/staging/wfx/sta.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/staging/wfx/sta.c b/drivers/staging/wfx/sta.c index c8a23146cae0..7c8ebd76114e 100644 --- a/drivers/staging/wfx/sta.c +++ b/drivers/staging/wfx/sta.c @@ -419,8 +419,6 @@ static void wfx_do_unjoin(struct wfx_vif *wvif) cancel_work_sync(&wvif->event_handler_work); wfx_cqm_bssloss_sm(wvif, 0, 0, 0); - wvif->disable_beacon_filter = false; - wfx_update_filtering(wvif); memset(&wvif->bss_params, 0, sizeof(wvif->bss_params)); wfx_tx_unlock(wvif->wdev); }