diff mbox series

net: dsa: ksz: Select KSZ protocol tag

Message ID 20200331093651.23365-1-codrin.ciubotariu@microchip.com
State Accepted
Delegated to: David Miller
Headers show
Series net: dsa: ksz: Select KSZ protocol tag | expand

Commit Message

Codrin Ciubotariu March 31, 2020, 9:36 a.m. UTC
KSZ protocol tag is needed by the KSZ DSA drivers.

Fixes: 0b9f9dfbfab4 ("dsa: Allow tag drivers to be built as modules")
Tested-by: Cristian Birsan <cristian.birsan@microchip.com>
Signed-off-by: Codrin Ciubotariu <codrin.ciubotariu@microchip.com>
---

Patch was tested on a 9477-like switch, but the 8795 variant seems to be
in the same situation.
I am not very sure about the Fixes tag, but it seems to be the one since
it removes the dependency between old NET_DSA_TAG_KSZ9477 and
NET_DSA_TAG_KSZ.

 drivers/net/dsa/microchip/Kconfig | 1 +
 1 file changed, 1 insertion(+)

Comments

Andrew Lunn March 31, 2020, 1:01 p.m. UTC | #1
On Tue, Mar 31, 2020 at 12:36:51PM +0300, Codrin Ciubotariu wrote:
> KSZ protocol tag is needed by the KSZ DSA drivers.
> 
> Fixes: 0b9f9dfbfab4 ("dsa: Allow tag drivers to be built as modules")
> Tested-by: Cristian Birsan <cristian.birsan@microchip.com>
> Signed-off-by: Codrin Ciubotariu <codrin.ciubotariu@microchip.com>

Reviewed-by: Andrew Lunn <andrew@lunn.ch>

    Andrew
Florian Fainelli March 31, 2020, 3:57 p.m. UTC | #2
On 3/31/2020 2:36 AM, Codrin Ciubotariu wrote:
> KSZ protocol tag is needed by the KSZ DSA drivers.
> 
> Fixes: 0b9f9dfbfab4 ("dsa: Allow tag drivers to be built as modules")
> Tested-by: Cristian Birsan <cristian.birsan@microchip.com>
> Signed-off-by: Codrin Ciubotariu <codrin.ciubotariu@microchip.com>

Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
David Miller March 31, 2020, 5:04 p.m. UTC | #3
From: Codrin Ciubotariu <codrin.ciubotariu@microchip.com>
Date: Tue, 31 Mar 2020 12:36:51 +0300

> KSZ protocol tag is needed by the KSZ DSA drivers.
> 
> Fixes: 0b9f9dfbfab4 ("dsa: Allow tag drivers to be built as modules")
> Tested-by: Cristian Birsan <cristian.birsan@microchip.com>
> Signed-off-by: Codrin Ciubotariu <codrin.ciubotariu@microchip.com>

Applied, thanks.
diff mbox series

Patch

diff --git a/drivers/net/dsa/microchip/Kconfig b/drivers/net/dsa/microchip/Kconfig
index 1d7870c6df3c..4ec6a47b7f72 100644
--- a/drivers/net/dsa/microchip/Kconfig
+++ b/drivers/net/dsa/microchip/Kconfig
@@ -1,5 +1,6 @@ 
 # SPDX-License-Identifier: GPL-2.0-only
 config NET_DSA_MICROCHIP_KSZ_COMMON
+	select NET_DSA_TAG_KSZ
 	tristate
 
 menuconfig NET_DSA_MICROCHIP_KSZ9477