From patchwork Tue Mar 10 10:13:52 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?b?SsOpcsO0bWUgUG91aWxsZXI=?= X-Patchwork-Id: 1252073 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming-netdev@ozlabs.org Delivered-To: patchwork-incoming-netdev@ozlabs.org Authentication-Results: ozlabs.org; spf=none (no SPF record) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=silabs.com Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=silabs.onmicrosoft.com header.i=@silabs.onmicrosoft.com header.a=rsa-sha256 header.s=selector2-silabs-onmicrosoft-com header.b=OifI80rw; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 48c9ts1L1xz9sRY for ; Tue, 10 Mar 2020 21:14:45 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726514AbgCJKOT (ORCPT ); Tue, 10 Mar 2020 06:14:19 -0400 Received: from mail-bn8nam12on2076.outbound.protection.outlook.com ([40.107.237.76]:6032 "EHLO NAM12-BN8-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726316AbgCJKOR (ORCPT ); Tue, 10 Mar 2020 06:14:17 -0400 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Hv1lWLJ5JG8fqa/KY1otiFKA915NDh6VwnJNX55EkJs9EcGnrIH8HT7nQDPsJlY2eHFQ9aundXCwn6ntRXkGWhV5Y55D4fjKLnVC6VTNwlGWi3S9RerLgJsSMOWZl8yXtsL5GGV6pxtT5rZlWEUusXrx3gmxxQoV1/KBfc8xhQOQ31gPGH3qKqDq/a6ik/U5neEF2jI+eSMvSpP2E6Rf17Jqg+VSBl1oaqytgR4hqUYi53BrdPuGubuR+5R1Rx7KCLVrrXLiR2DCh7v1YTAIavX86I697k92btDZEbX7br1X4wPayU3CVYc43wkfv9u0FqtEgGa/cMvMhJHP6DMOkQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=rY0qJf+PC3z1CAdSUCmy7DUXCKeTQ6KLeudf/6A3J7A=; b=QJfDzbFSz/QD8eXz+JQyz+OqF6pAOo5OEjfHTYZWX+YIFXHjo+/fiKsilpLb/GpeuVoG8V8Pjimo4l+hFEVVGCaYxgOKn1iWuuw+Qv+W9upnwCDzYEABRSjgRsJBo+OPO2CjRYqO1AUc4R+AbBYhrtkQV3hbtrg1bKBTY7Njc6uCqHAcoK3M9xCa6z7EXVkiy3WSuNu4KkGBGqn6z5D2rvsP5mFhhmqwT2+pyUha8FNcmpoKXIMIX6E0TlHpEZxqmBRLSTwggxGyd6JcHKYPpAkqQkfhC8qjXwR+jjyJVBqCK0uM/PRCH2oVBKZPlRUV9lYRGQ3ZWfG0turQnWovvg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=silabs.com; dmarc=pass action=none header.from=silabs.com; dkim=pass header.d=silabs.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=silabs.onmicrosoft.com; s=selector2-silabs-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=rY0qJf+PC3z1CAdSUCmy7DUXCKeTQ6KLeudf/6A3J7A=; b=OifI80rwFr48Ju+XyjKL1fEMCV4S7tzNe5OWRM+gAQZ6ZS1ZDMQWV1wwoEDWVHqCXY/ozEkpkVX5oCWg4bbNmz/VZC6NRO9hcW8lkC6v8m66TeCmz6MBLxyMHRH7Rj4a30gDCREw89in7850UYxNUW/dnRqd+/SqULMVOeUoPA0= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Jerome.Pouiller@silabs.com; Received: from MN2PR11MB4063.namprd11.prod.outlook.com (2603:10b6:208:13f::22) by MN2PR11MB3615.namprd11.prod.outlook.com (2603:10b6:208:ec::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2793.17; Tue, 10 Mar 2020 10:14:14 +0000 Received: from MN2PR11MB4063.namprd11.prod.outlook.com ([fe80::ade4:5702:1c8b:a2b3]) by MN2PR11MB4063.namprd11.prod.outlook.com ([fe80::ade4:5702:1c8b:a2b3%7]) with mapi id 15.20.2793.013; Tue, 10 Mar 2020 10:14:14 +0000 From: Jerome Pouiller To: devel@driverdev.osuosl.org, linux-wireless@vger.kernel.org Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Greg Kroah-Hartman , Kalle Valo , "David S . Miller" , =?utf-8?b?SsOpcsO0bWUgUG91aWxsZXI=?= Subject: [PATCH 1/5] staging: wfx: fix warning about freeing in-use mutex during device unregister Date: Tue, 10 Mar 2020 11:13:52 +0100 Message-Id: <20200310101356.182818-2-Jerome.Pouiller@silabs.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200310101356.182818-1-Jerome.Pouiller@silabs.com> References: <20200310101356.182818-1-Jerome.Pouiller@silabs.com> X-ClientProxiedBy: PR0P264CA0180.FRAP264.PROD.OUTLOOK.COM (2603:10a6:100:1c::24) To MN2PR11MB4063.namprd11.prod.outlook.com (2603:10b6:208:13f::22) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from pc-42.silabs.com (37.71.187.125) by PR0P264CA0180.FRAP264.PROD.OUTLOOK.COM (2603:10a6:100:1c::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2793.14 via Frontend Transport; Tue, 10 Mar 2020 10:14:13 +0000 X-Mailer: git-send-email 2.25.1 X-Originating-IP: [37.71.187.125] X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: f6741a84-bd41-4207-70ae-08d7c4dbc906 X-MS-TrafficTypeDiagnostic: MN2PR11MB3615: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:5236; X-Forefront-PRVS: 033857D0BD X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(39850400004)(136003)(366004)(376002)(396003)(346002)(189003)(199004)(6666004)(52116002)(5660300002)(2616005)(86362001)(316002)(956004)(36756003)(478600001)(4744005)(7696005)(8936002)(54906003)(4326008)(16526019)(186003)(26005)(6486002)(66574012)(66946007)(8676002)(1076003)(81166006)(2906002)(66476007)(81156014)(66556008)(107886003); DIR:OUT; SFP:1101; SCL:1; SRVR:MN2PR11MB3615; H:MN2PR11MB4063.namprd11.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; Received-SPF: None (protection.outlook.com: silabs.com does not designate permitted sender hosts) X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: DXCkY/6SGnZvNxSZcByR6mQ9EyLmW+Y1nHTtWBJlZFEFxbBbHwT0cxbAlhBOP7Zlh+g+T8yHBxJuvaMZuPvuUel6O8CNtkkupWhyRERrqI9wknpmTjHQbqaAAG5KH+wDQRl+UnydpZas09bpQ6ZbPWg9EPzPeeCYLNVMD50HxxUMPRhvAhCwmpCPziO7OqAuZB5aYG0Ws/lTDOqHqwvqC7PJS+gNpFEgJmaBv7JUjSUMwEMNSjMMvrOeyXsb+PGezGnoC3PYqRLWtd3DdrowzTcp+Wh4vpbrTb6xsNXH6PFTA3ue9+HtsC1U5rY8l7i05QZhEuq66yfZWP+8q5tTmwg0YPngn/TfgksNectziyu+8cU2lbpLHTr0shBecVKvQWKBF7W0X91llBw4CSN9/3jrdy9FZYhr5tRt4t36ygjqrgNiqpucH/BNEqPFoeEY X-MS-Exchange-AntiSpam-MessageData: vjfCw9P9gqXx04nMUb0gD+L8XpbYerJQIUSmxB+NS4e9yHGbbM1fcsCn/slsT8TpOITv1WZ1ZH9ixXmI14GlqPfsowRAlVTfgRD82RqjWjluGg2XA603HxxzlIN6ylQyJAjYCUvmGavQycMYGEHyfw== X-OriginatorOrg: silabs.com X-MS-Exchange-CrossTenant-Network-Message-Id: f6741a84-bd41-4207-70ae-08d7c4dbc906 X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Mar 2020 10:14:14.8407 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 54dbd822-5231-4b20-944d-6f4abcd541fb X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: ksikP+gNt/SL2Bqr7DpgTBdBWBxGlEAUknsoyP5do7HYvW2d5yQJ9cpXf89H3NrScSVYn2ECOU9fwjjKprv9DQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR11MB3615 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Jérôme Pouiller After hif_shutdown(), communication with the chip is no more possible. It the only request that never reply. Therefore, hif_cmd.lock is never unlocked. hif_shutdown() unlock itself hif_cmd.lock to avoid a potential warning during disposal of device. hif_cmd.key_renew_lock should also been unlocked for the same reason. Signed-off-by: Jérôme Pouiller --- drivers/staging/wfx/hif_tx.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/staging/wfx/hif_tx.c b/drivers/staging/wfx/hif_tx.c index 2428363371fa..7b732c531a74 100644 --- a/drivers/staging/wfx/hif_tx.c +++ b/drivers/staging/wfx/hif_tx.c @@ -140,6 +140,7 @@ int hif_shutdown(struct wfx_dev *wdev) else control_reg_write(wdev, 0); mutex_unlock(&wdev->hif_cmd.lock); + mutex_unlock(&wdev->hif_cmd.key_renew_lock); kfree(hif); return ret; }