From patchwork Thu Mar 5 22:01:27 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: KP Singh X-Patchwork-Id: 1249901 X-Patchwork-Delegate: bpf@iogearbox.net Return-Path: X-Original-To: incoming-bpf@patchwork.ozlabs.org Delivered-To: patchwork-incoming-bpf@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (no SPF record) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=bpf-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=chromium.org header.i=@chromium.org header.a=rsa-sha256 header.s=google header.b=OyN0As3W; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 48YPpq00MSz9sPF for ; Fri, 6 Mar 2020 09:01:38 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726243AbgCEWBi (ORCPT ); Thu, 5 Mar 2020 17:01:38 -0500 Received: from mail-wr1-f65.google.com ([209.85.221.65]:35784 "EHLO mail-wr1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726145AbgCEWBi (ORCPT ); Thu, 5 Mar 2020 17:01:38 -0500 Received: by mail-wr1-f65.google.com with SMTP id r7so29128wro.2 for ; Thu, 05 Mar 2020 14:01:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=QRs769N8QUo0slXGjoV/bE6quT349p8P4cDyvi5+xSs=; b=OyN0As3WtsQyPWrtZ0mTiBeTZecUOCo749mffQpTDmTx69lKJuE4osS24tJYR/gpHX 9VrzXIzE920xZDE0WeBQEVk4jHfPgbL+L8RNeX1VBPd6m95OUXVDG4faYkaORxj/wR5E oXvLlM71z+RvpZVtk0IWK8zhjSZ6NIBdrlVwA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=QRs769N8QUo0slXGjoV/bE6quT349p8P4cDyvi5+xSs=; b=EStZSU62BHmYUld9Lo+hNWgIZ/YoVfey4Kb1M+/WMcDmlmhPS8aQezmnBJyRHXK2kV gvqDQhU6lJO/1aka3xJSG4zaU3p2weUxpAx2TPHFHCm4jU1NARUW5zM9fbNCKmhygHWs DHCw/2ZSPmtFXUmLWNAsGJVaw1U8H02uFMKx+TJdOdT+F7rCPaT9jfBB1x9KUkb4Bw2T f97Zu50Qtn/Tv9cmbpmCcqWpVe+vmNuODjz+nLYnAk+ym9RuUqZ80vqIx0I9NWK4V1LQ GRnVvVTJzQpvYExxN4ETO0iFmG1QqYr0r6A/XEaRCG6ERoND5WYdFjDV4z7KXZ3kZ0mL dRmg== X-Gm-Message-State: ANhLgQ3+MxGSaMlcmTxaxe/034ZHbv6VIdAWWZ3NJuv3YX6k0FRHjNEm nFbK31O5vlpLPtH/CMBSEsD44A== X-Google-Smtp-Source: ADFU+vuNWeddf1HH7nZX+stJXAplqB1550B+DJXHvxhEuJ8KddsSUGbg7If5vezjuGur7ZvPeojLkw== X-Received: by 2002:adf:d4d2:: with SMTP id w18mr66826wrk.180.1583445696430; Thu, 05 Mar 2020 14:01:36 -0800 (PST) Received: from kpsingh-kernel.localdomain (77-56-209-237.dclient.hispeed.ch. [77.56.209.237]) by smtp.gmail.com with ESMTPSA id x9sm5002641wrx.0.2020.03.05.14.01.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 05 Mar 2020 14:01:35 -0800 (PST) From: KP Singh To: linux-security-module@vger.kernel.org, linux-next@vger.kernel.org, bpf@vger.kernel.org Cc: Alexei Starovoitov , Daniel Borkmann , Randy Dunlap , Stephen Rothwell , Florent Revest , Brendan Jackman Subject: [PATCH bpf-next] bpf: Fix bpf_prog_test_run_tracing for !CONFIG_NET Date: Thu, 5 Mar 2020 23:01:27 +0100 Message-Id: <20200305220127.29109-1-kpsingh@chromium.org> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 Sender: bpf-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: bpf@vger.kernel.org From: KP Singh test_run.o is not built when CONFIG_NET is not set and bpf_prog_test_run_tracing being referenced in bpf_trace.o causes the linker error: ld: kernel/trace/bpf_trace.o:(.rodata+0x38): undefined reference to `bpf_prog_test_run_tracing' Add a __weak function in bpf_trace.c to handle this. Fixes: da00d2f117a0 ("bpf: Add test ops for BPF_PROG_TYPE_TRACING") Signed-off-by: KP Singh Reported-by: Randy Dunlap Acked-by: Randy Dunlap # build-tested --- kernel/trace/bpf_trace.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/kernel/trace/bpf_trace.c b/kernel/trace/bpf_trace.c index 363e0a2c75cf..6a490d8ce9de 100644 --- a/kernel/trace/bpf_trace.c +++ b/kernel/trace/bpf_trace.c @@ -1252,6 +1252,13 @@ static bool tracing_prog_is_valid_access(int off, int size, return btf_ctx_access(off, size, type, prog, info); } +int __weak bpf_prog_test_run_tracing(struct bpf_prog *prog, + const union bpf_attr *kattr, + union bpf_attr __user *uattr) +{ + return -ENOTSUPP; +} + const struct bpf_verifier_ops raw_tracepoint_verifier_ops = { .get_func_proto = raw_tp_prog_func_proto, .is_valid_access = raw_tp_prog_is_valid_access,