| Message ID | 20200212101916.27085-1-yangbo.lu@nxp.com |
|---|---|
| State | Rejected |
| Delegated to: | David Miller |
| Headers | show |
| Series | [v2] ptp_qoriq: add initialization message | expand |
On Wed, Feb 12, 2020 at 06:19:16PM +0800, Yangbo Lu wrote: > - The ptp_qoriq driver users don't have to install an ethtool to > check the PTP clock index for using. Or don't have to check which > /sys/class/ptp/ptpX is PTP QorIQ clock. You just stated the reason why your new pr_info() is more spam in the kernel log. So, NAK on this patch. Sorry, Richard
From: Yangbo Lu <yangbo.lu@nxp.com> Date: Wed, 12 Feb 2020 18:19:16 +0800 > Current ptp_qoriq driver prints only warning or error messages. > It may be loaded successfully without any messages. > Although this is fine, it would be convenient to have an oneline > initialization log showing success and PTP clock index. > The goods are, > - The ptp_qoriq driver users may know whether this driver is loaded > successfully, or not, or not loaded from the booting log. > - The ptp_qoriq driver users don't have to install an ethtool to > check the PTP clock index for using. Or don't have to check which > /sys/class/ptp/ptpX is PTP QorIQ clock. > > Signed-off-by: Yangbo Lu <yangbo.lu@nxp.com> > --- > Changes for v2: > - Added more in commit message. I explained yesterday why your change is inappropriate and why I won't be applying your patch. It is not appropriate to send the same patch again with a different commit message. What might be appropriate is replying to my email and explaining your side of the argument and why you think it is appropriate. You must engage with other developers and discuss your change here on the list if you want us to consider it still. Thank you.
diff --git a/drivers/ptp/ptp_qoriq.c b/drivers/ptp/ptp_qoriq.c index b27c46e..66e7d57 100644 --- a/drivers/ptp/ptp_qoriq.c +++ b/drivers/ptp/ptp_qoriq.c @@ -541,6 +541,8 @@ int ptp_qoriq_init(struct ptp_qoriq *ptp_qoriq, void __iomem *base, ptp_qoriq->phc_index = ptp_clock_index(ptp_qoriq->clock); ptp_qoriq_create_debugfs(ptp_qoriq); + + pr_info("new PTP clock ptp%d\n", ptp_qoriq->phc_index); return 0; } EXPORT_SYMBOL_GPL(ptp_qoriq_init);
Current ptp_qoriq driver prints only warning or error messages. It may be loaded successfully without any messages. Although this is fine, it would be convenient to have an oneline initialization log showing success and PTP clock index. The goods are, - The ptp_qoriq driver users may know whether this driver is loaded successfully, or not, or not loaded from the booting log. - The ptp_qoriq driver users don't have to install an ethtool to check the PTP clock index for using. Or don't have to check which /sys/class/ptp/ptpX is PTP QorIQ clock. Signed-off-by: Yangbo Lu <yangbo.lu@nxp.com> --- Changes for v2: - Added more in commit message. --- drivers/ptp/ptp_qoriq.c | 2 ++ 1 file changed, 2 insertions(+)