From patchwork Tue Feb 11 15:00:28 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Jason A. Donenfeld" X-Patchwork-Id: 1236325 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming-netdev@ozlabs.org Delivered-To: patchwork-incoming-netdev@ozlabs.org Authentication-Results: ozlabs.org; spf=none (no SPF record) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=pass (p=none dis=none) header.from=zx2c4.com Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=zx2c4.com header.i=@zx2c4.com header.a=rsa-sha1 header.s=mail header.b=v8KFWqsG; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 48H5Z95qRDz9sP7 for ; Wed, 12 Feb 2020 02:01:05 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730285AbgBKPBE (ORCPT ); Tue, 11 Feb 2020 10:01:04 -0500 Received: from frisell.zx2c4.com ([192.95.5.64]:34135 "EHLO frisell.zx2c4.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728073AbgBKPBE (ORCPT ); Tue, 11 Feb 2020 10:01:04 -0500 Received: by frisell.zx2c4.com (ZX2C4 Mail Server) with ESMTP id fd2ff95a; Tue, 11 Feb 2020 14:59:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=zx2c4.com; h=from:to:cc :subject:date:message-id:in-reply-to:references:mime-version :content-transfer-encoding; s=mail; bh=NgYNluWNYqWNVHMj35wM6xWxZ C8=; b=v8KFWqsG11SdrabGPR4/nCpLE+sunMJ+WWqTY7MuLRQARDkGNdaBVpP89 2aABUldklrgfWICX1HZwygd2/bp/eFoWy8XC33Zcat3WwyEJbOl77g2e9ODjUHQn P/S3w4DB5N7ldLFDeKCgljfKMJ0TCyfZHXsrzdwTkFoX0G/7QWZjhfBSavFXXBUU NLs1xMTUfnuBdxAlP/0k+zhtMG00FgRJvkLhBrKZeRAJ4OVXp7zBXT19FvWKAqSK sQrVPyKUvN3TVnZlO+HseKULGosU15VMkjpbD5TNRSi3jVyROb466NoYiHh/zbMH yOIzOEE7+FquKnBu7wIIT5JUmC81w== Received: by frisell.zx2c4.com (ZX2C4 Mail Server) with ESMTPSA id a45e62b6 (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256:NO); Tue, 11 Feb 2020 14:59:18 +0000 (UTC) From: "Jason A. Donenfeld" To: netdev@vger.kernel.org, davem@davemloft.net Cc: "Jason A. Donenfeld" , Sathya Perla , Ajit Khaparde , Sriharsha Basavapatna , Somnath Kotur Subject: [PATCH v3 net 9/9] benet: remove skb_share_check from xmit path Date: Tue, 11 Feb 2020 16:00:28 +0100 Message-Id: <20200211150028.688073-10-Jason@zx2c4.com> In-Reply-To: <20200211150028.688073-1-Jason@zx2c4.com> References: <20200210141423.173790-2-Jason@zx2c4.com> <20200211150028.688073-1-Jason@zx2c4.com> MIME-Version: 1.0 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org This is an impossible condition to reach; an skb in ndo_start_xmit won't be shared by definition. Signed-off-by: Jason A. Donenfeld Cc: Sathya Perla Cc: Ajit Khaparde Cc: Sriharsha Basavapatna Cc: Somnath Kotur Link: https://lore.kernel.org/netdev/CAHmME9pk8HEFRq_mBeatNbwXTx7UEfiQ_HG_+Lyz7E+80GmbSA@mail.gmail.com/ --- drivers/net/ethernet/emulex/benet/be_main.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/drivers/net/ethernet/emulex/benet/be_main.c b/drivers/net/ethernet/emulex/benet/be_main.c index 56f59db6ebf2..8b797adb3065 100644 --- a/drivers/net/ethernet/emulex/benet/be_main.c +++ b/drivers/net/ethernet/emulex/benet/be_main.c @@ -1048,10 +1048,6 @@ static struct sk_buff *be_insert_vlan_in_pkt(struct be_adapter *adapter, bool insert_vlan = false; u16 vlan_tag = 0; - skb = skb_share_check(skb, GFP_ATOMIC); - if (unlikely(!skb)) - return skb; - if (skb_vlan_tag_present(skb)) { vlan_tag = be_get_tx_vlan_tag(adapter, skb); insert_vlan = true;