From patchwork Tue Jan 21 15:04:31 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Chris Down X-Patchwork-Id: 1226621 X-Patchwork-Delegate: bpf@iogearbox.net Return-Path: X-Original-To: incoming-bpf@patchwork.ozlabs.org Delivered-To: patchwork-incoming-bpf@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (no SPF record) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=bpf-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=pass (p=none dis=none) header.from=chrisdown.name Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=chrisdown.name header.i=@chrisdown.name header.a=rsa-sha256 header.s=google header.b=lqbjIQov; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 482Bdw4xn9z9sRl for ; Wed, 22 Jan 2020 02:04:36 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726968AbgAUPEf (ORCPT ); Tue, 21 Jan 2020 10:04:35 -0500 Received: from mail-wr1-f65.google.com ([209.85.221.65]:33778 "EHLO mail-wr1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727817AbgAUPEe (ORCPT ); Tue, 21 Jan 2020 10:04:34 -0500 Received: by mail-wr1-f65.google.com with SMTP id b6so3623309wrq.0 for ; Tue, 21 Jan 2020 07:04:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chrisdown.name; s=google; h=date:from:to:cc:subject:message-id:mime-version:content-disposition; bh=3fX8yqVdokeUbIrwEfgnVCmcXTtAwRGxuX8ZNd4rp/U=; b=lqbjIQovQBhxj+xtgVpB8uPL58iOhyecjOyhwTyWj62vfntLi4PpGJ6VfGKjJ2QUnK JMumsdiQl5V6T7LB2vFENkf8ojE07zTSr/3BJxxB/9O7BC4rZwYKSzfyCvx7JknD3GMV Ea2K+iKl2ejNEzovb915Aw97aYSA1UGVo51PM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:mime-version :content-disposition; bh=3fX8yqVdokeUbIrwEfgnVCmcXTtAwRGxuX8ZNd4rp/U=; b=UPxv1KahUgrp4imipsxbvHN0RIJ3Rk/tFBAdS2DYwjy86rKCWyIgAEWN3e5P7B8qDU JnfeMd5XseuE2zXREP4/zhaMObOM9U8kw6waAjoAhBLM0aMqT+RkN+HdTjMJpbW9Y6rN gjbBNcyPvmP4PNVV/g5WftYHjaToTdxJEqTs4VwMnKFVKXB2Ufcco9y5SfWxpsXAcqj4 LAgh34rN98dZxIak/jXqw5m+E/kXb71KpG90EvISpZfmtWdyVGFwV7KkGraMyLL+UQF1 YkGBQ9n1fZSoMfWkR5OgYg10efcW0JTbJrb84v20P5gbzXa5JPokS51jD9KE6ENdiQ4/ urOw== X-Gm-Message-State: APjAAAXP7WFc2JzTdnwT9GzZTYwHUCGsfF/sVSU4VhVcHLQV6oQMrHCc YH0/6JrcYBP+41/4ZmkY8po1JMVjYQ4= X-Google-Smtp-Source: APXvYqw/n/eK5Xu7u+qMpNfuL8mmr6BDT1kDRYsC9l5O4JsvXRyvkzv097K0+46FPQDNAoOyCpapCg== X-Received: by 2002:a5d:4d8d:: with SMTP id b13mr5816499wru.6.1579619072431; Tue, 21 Jan 2020 07:04:32 -0800 (PST) Received: from localhost ([2620:10d:c092:180::1:db6c]) by smtp.gmail.com with ESMTPSA id s15sm49352115wrp.4.2020.01.21.07.04.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 21 Jan 2020 07:04:31 -0800 (PST) Date: Tue, 21 Jan 2020 15:04:31 +0000 From: Chris Down To: bpf@vger.kernel.org, netdev@vger.kernel.org Cc: Stanislav Fomichev , Andrii Nakryiko , John Fastabend , linux-kernel@vger.kernel.org, kernel-team@fb.com Subject: [PATCH] bpf: btf: Always output invariant hit in pahole DWARF to BTF transform Message-ID: <20200121150431.GA240246@chrisdown.name> MIME-Version: 1.0 Content-Disposition: inline Sender: bpf-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: bpf@vger.kernel.org When trying to compile with CONFIG_DEBUG_INFO_BTF enabled, I got this error: % make -s Failed to generate BTF for vmlinux Try to disable CONFIG_DEBUG_INFO_BTF make[3]: *** [vmlinux] Error 1 Compiling again without -s shows the true error (that pahole is missing), but since this is fatal, we should show the error unconditionally on stderr as well, not silence it using the `info` function. With this patch: % make -s BTF: .tmp_vmlinux.btf: pahole (pahole) is not available Failed to generate BTF for vmlinux Try to disable CONFIG_DEBUG_INFO_BTF make[3]: *** [vmlinux] Error 1 Signed-off-by: Chris Down Cc: Stanislav Fomichev Cc: Andrii Nakryiko Cc: John Fastabend Cc: linux-kernel@vger.kernel.org Cc: netdev@vger.kernel.org Cc: bpf@vger.kernel.org Cc: kernel-team@fb.com --- scripts/link-vmlinux.sh | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/scripts/link-vmlinux.sh b/scripts/link-vmlinux.sh index c287ad9b3a67..c8e9f49903a0 100755 --- a/scripts/link-vmlinux.sh +++ b/scripts/link-vmlinux.sh @@ -108,13 +108,15 @@ gen_btf() local bin_arch if ! [ -x "$(command -v ${PAHOLE})" ]; then - info "BTF" "${1}: pahole (${PAHOLE}) is not available" + printf 'BTF: %s: pahole (%s) is not available\n' \ + "${1}" "${PAHOLE}" >&2 return 1 fi pahole_ver=$(${PAHOLE} --version | sed -E 's/v([0-9]+)\.([0-9]+)/\1\2/') if [ "${pahole_ver}" -lt "113" ]; then - info "BTF" "${1}: pahole version $(${PAHOLE} --version) is too old, need at least v1.13" + printf 'BTF: %s: pahole version %s is too old, need at least v1.13\n' \ + "${1}" "$(${PAHOLE} --version)" >&2 return 1 fi