From patchwork Mon Dec 16 17:03:35 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?b?SsOpcsO0bWUgUG91aWxsZXI=?= X-Patchwork-Id: 1210606 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming-netdev@ozlabs.org Delivered-To: patchwork-incoming-netdev@ozlabs.org Authentication-Results: ozlabs.org; spf=none (no SPF record) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=silabs.com Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=silabs.onmicrosoft.com header.i=@silabs.onmicrosoft.com header.b="iyNqZyfI"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 47c7071jNWz9sRM for ; Tue, 17 Dec 2019 04:03:51 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726911AbfLPRDt (ORCPT ); Mon, 16 Dec 2019 12:03:49 -0500 Received: from mail-eopbgr680072.outbound.protection.outlook.com ([40.107.68.72]:26598 "EHLO NAM04-BN3-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726846AbfLPRDr (ORCPT ); Mon, 16 Dec 2019 12:03:47 -0500 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=fMy5Kwz7WbiU08aQaAjivS3qDn8K1bDa04LuAzV9IkEaLPHZphGs4mLCjeiniPdflhsl2CO8fCO/iUFvY8PodmArerlqwGs2mPTFXjgRW51EJkrtn4bUL4i2ELKLkx6CqtN/Rl76fRRXgyYJm65YkqQ82PikYqoK1tebJZcj15akkVUR625FPizXp32v0qe7j7SLl5Ylaz1KkYzaNKjk1OBRjcE5KWGYuYLIBTiDySG7XS64C3fqPPa78G6avrbS4DF7gAYQsFslDb63Vh742Cd+NMnrHaUlzfwjgrUc5T9mUT/zdgwscO0pnq4xkkjTSeEgVMoEcKRscVXTaqxHUA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=zhG1Ok86Jz3EuuS9CpzO4QG8Lt5Nei24lU15Lc8Q7AI=; b=ftN+eP2dfFuNumq+NOVCao8sMuoHTO+Js0ygM9hunG7Zg+/n2CsmiaKMqLwz/HGESdUMnJAZOMSDv2UjJcC8QZj5uR5qu5V3ab4bFCs5TnVz86w8Mko/0LIn6PlT54Xhz0Dz5dW9KSxj160k8OwTQBAvcSiLd1neJIFP1tNKDAiOfGDuWwgq/e4cFRdEstQLKK8Oz/i/ImThe07cprujguovek6HONgOsxrZj5FrjXiCHO19HkkObs/P4P7QsHQeu4GCb7jwrz8bLUqCxFeewfTTn5i586ST9xf8Uh3goYUkBN59vWs0pXg9j/vN95lJEDraRwmyn7XffY+nxEiBMQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=silabs.com; dmarc=pass action=none header.from=silabs.com; dkim=pass header.d=silabs.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=silabs.onmicrosoft.com; s=selector2-silabs-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=zhG1Ok86Jz3EuuS9CpzO4QG8Lt5Nei24lU15Lc8Q7AI=; b=iyNqZyfIGJXNYi2CctDdIFgECJH0M0mp05N/hXjINmdruKjA8A4URxtJ9Y8QSxBMYb7SHz3Tj2ZFn0CH0PVvdSklIOVY2G5I/V6VdXhagj0RoNDEuXa1B9yzCQ/amTwWpuNxM0uRji5bB9w6U9gUIwhdE6uvlqtSp2+JaJ69ZaA= Received: from MN2PR11MB4063.namprd11.prod.outlook.com (10.255.180.22) by MN2PR11MB3838.namprd11.prod.outlook.com (20.178.252.202) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2538.19; Mon, 16 Dec 2019 17:03:38 +0000 Received: from MN2PR11MB4063.namprd11.prod.outlook.com ([fe80::f46c:e5b4:2a85:f0bf]) by MN2PR11MB4063.namprd11.prod.outlook.com ([fe80::f46c:e5b4:2a85:f0bf%4]) with mapi id 15.20.2538.019; Mon, 16 Dec 2019 17:03:38 +0000 From: =?utf-8?b?SsOpcsO0bWUgUG91aWxsZXI=?= To: "devel@driverdev.osuosl.org" , "linux-wireless@vger.kernel.org" CC: "netdev@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Greg Kroah-Hartman , Kalle Valo , "David S . Miller" , =?utf-8?b?SsOpcsO0bWUgUG91?= =?utf-8?q?iller?= Subject: [PATCH 04/55] staging: wfx: use boolean appropriately Thread-Topic: [PATCH 04/55] staging: wfx: use boolean appropriately Thread-Index: AQHVtDLApmJeO27A5kGs7sP8uS+xRA== Date: Mon, 16 Dec 2019 17:03:35 +0000 Message-ID: <20191216170302.29543-5-Jerome.Pouiller@silabs.com> References: <20191216170302.29543-1-Jerome.Pouiller@silabs.com> In-Reply-To: <20191216170302.29543-1-Jerome.Pouiller@silabs.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=Jerome.Pouiller@silabs.com; x-originating-ip: [37.71.187.125] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 826dd7f4-b721-4bd2-b5e9-08d78249e56d x-ms-traffictypediagnostic: MN2PR11MB3838: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:247; x-forefront-prvs: 02530BD3AA x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(376002)(346002)(136003)(39860400002)(396003)(366004)(189003)(199004)(85202003)(8936002)(81166006)(8676002)(54906003)(110136005)(316002)(85182001)(6506007)(186003)(2906002)(5660300002)(6512007)(26005)(107886003)(81156014)(36756003)(4326008)(6666004)(2616005)(76116006)(91956017)(64756008)(66556008)(66476007)(66946007)(71200400001)(86362001)(66446008)(6486002)(478600001)(1076003)(66574012); DIR:OUT; SFP:1101; SCL:1; SRVR:MN2PR11MB3838; H:MN2PR11MB4063.namprd11.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: silabs.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: Hc5/q5nU4S0FwYijpi5kpn4ImjY5z3onue916600j6nb5PNJJkMLbB/JkgjScZIttYnhEgzDXQ//5/EawKR3wkQf038NKu5TsRE9rF03ErvJ89a9L7ecFSTYS1rZEFAUI7LR52KYju3xURR7BtLFchkzUzeSTeMUpAIuTbYf2EC+4At/IGG7BdkUCpR7XNdnI4qH0Typx5An6/CYRbYG+rbv3OrYAsPC7jvcfWumWukyLfDmJzzngszUQTjonxV5wWDZ1AeMcb/D4ra+f5Hr39jYdlrbTtGSo+DY1rWa0svVtetseSxWmXppQNSrbPVZ/xlC6Oy1leIR9IyX0T++WnxhlCu266lsBzv/qnD9caIWhTIF8bwEplnl1O6ehugQUQ0x1YBUvIIhrm9jB6FEY3F8U1D6ixz/KlBpvM+nVaN1NvjRwA5cn2DQK5jtTq1j Content-ID: <03CB32629AA9584A82B036BB41B003B6@namprd11.prod.outlook.com> MIME-Version: 1.0 X-OriginatorOrg: silabs.com X-MS-Exchange-CrossTenant-Network-Message-Id: 826dd7f4-b721-4bd2-b5e9-08d78249e56d X-MS-Exchange-CrossTenant-originalarrivaltime: 16 Dec 2019 17:03:35.1182 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 54dbd822-5231-4b20-944d-6f4abcd541fb X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: axiULtux7Cxj2Naa8xaUGA8yg8ATSTYx0NxplhSapI2iNTxLGJRBbOCGzpp934GmrVMROstenQc5ICOMdQoTGQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR11MB3838 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Jérôme Pouiller The field 'uploaded' is used as a boolean, so call it a boolean. Signed-off-by: Jérôme Pouiller --- drivers/staging/wfx/data_tx.c | 4 ++-- drivers/staging/wfx/data_tx.h | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/wfx/data_tx.c b/drivers/staging/wfx/data_tx.c index df3aca03b50b..b726dd5e59f3 100644 --- a/drivers/staging/wfx/data_tx.c +++ b/drivers/staging/wfx/data_tx.c @@ -184,7 +184,7 @@ static int wfx_tx_policy_get(struct wfx_vif *wvif, */ entry = list_entry(cache->free.prev, struct tx_policy, link); memcpy(entry->rates, wanted.rates, sizeof(entry->rates)); - entry->uploaded = 0; + entry->uploaded = false; entry->usage_count = 0; idx = entry - cache->cache; } @@ -241,7 +241,7 @@ static int wfx_tx_policy_upload(struct wfx_vif *wvif) dst->terminate = 1; dst->count_init = 1; memcpy(&dst->rates, src->rates, sizeof(src->rates)); - src->uploaded = 1; + src->uploaded = true; arg->num_tx_rate_policies++; } } diff --git a/drivers/staging/wfx/data_tx.h b/drivers/staging/wfx/data_tx.h index f63e5d8cf929..0fc388db62e0 100644 --- a/drivers/staging/wfx/data_tx.h +++ b/drivers/staging/wfx/data_tx.h @@ -41,7 +41,7 @@ struct tx_policy { struct list_head link; int usage_count; u8 rates[12]; - u8 uploaded; + bool uploaded; }; struct tx_policy_cache {