From patchwork Mon Dec 16 17:03:34 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?b?SsOpcsO0bWUgUG91aWxsZXI=?= X-Patchwork-Id: 1210671 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming-netdev@ozlabs.org Delivered-To: patchwork-incoming-netdev@ozlabs.org Authentication-Results: ozlabs.org; spf=none (no SPF record) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=silabs.com Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=silabs.onmicrosoft.com header.i=@silabs.onmicrosoft.com header.b="h5NiVSfQ"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 47c77k0Fywz9sPn for ; Tue, 17 Dec 2019 04:10:26 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727764AbfLPRKZ (ORCPT ); Mon, 16 Dec 2019 12:10:25 -0500 Received: from mail-eopbgr750081.outbound.protection.outlook.com ([40.107.75.81]:59109 "EHLO NAM02-BL2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726734AbfLPRDq (ORCPT ); Mon, 16 Dec 2019 12:03:46 -0500 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=E2ttkfxMVIUJ1EZ9QeR/59JY6ZplWNXLRNT8k68//3dYia7p+IQGDAwMFrnTYcIJbqzYUDO7bjLBM1A549oq+hzRIB0Lz1Xj6scjLFHaTafuK2ozvH2wJZ+nktjt/VKPAtLBQjKRSteZTT6Wvl4XRA7detgPK8dhdq1oocGmqswlLCzPJ/lM617f8hJfhQLiN9s/SM06Fl9UXrAMOKYkVvoGwz6mmGH+tmfh8h4zqn2v785pYiyIl281aK5ktUCrSxe2HUb/F9j5tcN7+KzBFR8HaDv94V31VTDGbyRsy5OBqrDqkHlz+ktTMDWxNAYlrxoWomTWyaNbzfwvY81YLg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Ok6tosLI3CrLoEK8kYwUvELZAFlrlOzOv19vPj4z7Bk=; b=Xgj7slbuj7UUtgcNbeJycA/8gRJJ/YEd9MbXn0qhQIbMHqUq2qcccNpREtzCNMzSc1ZKABy9SWmJm1qV0v0Sn05pt40erBsMCY6byrZpp6RnSxOItq4zUf7kwQRvp2J7AjkjW0lK7Ecd0jgY1kcmC74HrSyXeT3T8bQuSButBx1/MYjLDPumMGNoINo9xqzEChHoghJhy2WuvPmujA9F9Z53lxjfG6U2njLEBrnugBaWQuQoK4fJP8cp3tStZnrNop8z1fEQ+cewO1co+U/Pz+zw1LjCIlCKOzcOXMaXNApWDUf3UgMuWvHzYb2tM27Z2HeoWuhh1fZjiIKZQPS2MA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=silabs.com; dmarc=pass action=none header.from=silabs.com; dkim=pass header.d=silabs.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=silabs.onmicrosoft.com; s=selector2-silabs-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Ok6tosLI3CrLoEK8kYwUvELZAFlrlOzOv19vPj4z7Bk=; b=h5NiVSfQWly3VivN186Hmqhjz/yE7ZkJk5r0qKbmwsPjZ2dMsCQ6MWh/EJBlQUIS/x8x+6ZmRoFwePAlX1mXUNkrswDg8eDEY0+agqpc0g4iLLjRIsBSY3uvYUoTHu75bvD9oPcu0nqTsj/EtDeD9Esn9OB4s1GtzsYjp8AGMxY= Received: from MN2PR11MB4063.namprd11.prod.outlook.com (10.255.180.22) by MN2PR11MB3838.namprd11.prod.outlook.com (20.178.252.202) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2538.19; Mon, 16 Dec 2019 17:03:35 +0000 Received: from MN2PR11MB4063.namprd11.prod.outlook.com ([fe80::f46c:e5b4:2a85:f0bf]) by MN2PR11MB4063.namprd11.prod.outlook.com ([fe80::f46c:e5b4:2a85:f0bf%4]) with mapi id 15.20.2538.019; Mon, 16 Dec 2019 17:03:35 +0000 From: =?utf-8?b?SsOpcsO0bWUgUG91aWxsZXI=?= To: "devel@driverdev.osuosl.org" , "linux-wireless@vger.kernel.org" CC: "netdev@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Greg Kroah-Hartman , Kalle Valo , "David S . Miller" , =?utf-8?b?SsOpcsO0bWUgUG91?= =?utf-8?q?iller?= Subject: [PATCH 03/55] staging: wfx: fix counter overflow Thread-Topic: [PATCH 03/55] staging: wfx: fix counter overflow Thread-Index: AQHVtDLAm4rb7my/j0+AmTYMmsYTQw== Date: Mon, 16 Dec 2019 17:03:34 +0000 Message-ID: <20191216170302.29543-4-Jerome.Pouiller@silabs.com> References: <20191216170302.29543-1-Jerome.Pouiller@silabs.com> In-Reply-To: <20191216170302.29543-1-Jerome.Pouiller@silabs.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=Jerome.Pouiller@silabs.com; x-originating-ip: [37.71.187.125] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 0d9b0a57-79ae-420b-a4df-08d78249e33e x-ms-traffictypediagnostic: MN2PR11MB3838: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:510; x-forefront-prvs: 02530BD3AA x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(376002)(346002)(136003)(39860400002)(396003)(366004)(189003)(199004)(85202003)(8936002)(4744005)(81166006)(8676002)(54906003)(110136005)(316002)(85182001)(6506007)(186003)(2906002)(5660300002)(6512007)(26005)(107886003)(81156014)(36756003)(4326008)(2616005)(76116006)(91956017)(64756008)(66556008)(66476007)(66946007)(71200400001)(86362001)(66446008)(6486002)(478600001)(1076003)(66574012); DIR:OUT; SFP:1101; SCL:1; SRVR:MN2PR11MB3838; H:MN2PR11MB4063.namprd11.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: silabs.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: MGQZg5gu5mTiJrUeUF7daVammFcxi95GTd5hXNFCwcsxWFg/7FHbrKBo8VwaP6+Ou0kp3pflmKyJQlQpHAU7YKgVBab+42m7Qy5WyOj0IUXFXOhwYqIX+oTPmS30b49WgwgpIlxuPusVcrIEhj8cBcaX0eA7f4dieSUcXzHdF5ZcrDhXAYz1rkaAeXyJjXn+w94Kpfrm66wBAHZk1ieOiJGW3P3+LrZhBeiBjh5cIA7d4pahuJEpnGUgghlra1/x/frljfuLVz8qKwWirQT3M7N7qlGGTmYBDQNglfxlYUEXByFVj7iVhV99VgE+NYGn0cIwsS6pnlZaSy0u0e+eogDjEf6HpIqVpFOfXt0N9FXCjQ7pQt8OJ7vehDKNwJ0nlZ72xDtCdBfitTAL4EfKQ08FQG8bE3M0xZar+rn53Sa6ZCLVtNMg/oE560AcPb/1 Content-ID: <9AF0E0E9B9F7324D9E65B98E35F9400B@namprd11.prod.outlook.com> MIME-Version: 1.0 X-OriginatorOrg: silabs.com X-MS-Exchange-CrossTenant-Network-Message-Id: 0d9b0a57-79ae-420b-a4df-08d78249e33e X-MS-Exchange-CrossTenant-originalarrivaltime: 16 Dec 2019 17:03:34.6495 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 54dbd822-5231-4b20-944d-6f4abcd541fb X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: lAJ2XKdKMhKKAPlLbL6SFtSmdTVUaD2d/TBN+joDXQaM8acZomqVGt+ylVSGgEn4bhxXzTkz+54XTDmn6bX9yA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR11MB3838 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Jérôme Pouiller Some weird behaviors were observed when connection is really good and packets are small. It appears that sometime, number of packets in queues can exceed 255 and generate an overflow in field usage_count. Signed-off-by: Jérôme Pouiller --- drivers/staging/wfx/data_tx.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/wfx/data_tx.h b/drivers/staging/wfx/data_tx.h index a0f9ae69baf5..f63e5d8cf929 100644 --- a/drivers/staging/wfx/data_tx.h +++ b/drivers/staging/wfx/data_tx.h @@ -39,8 +39,8 @@ struct wfx_link_entry { struct tx_policy { struct list_head link; + int usage_count; u8 rates[12]; - u8 usage_count; u8 uploaded; };