From patchwork Mon Dec 16 17:03:51 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?b?SsOpcsO0bWUgUG91aWxsZXI=?= X-Patchwork-Id: 1210639 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming-netdev@ozlabs.org Delivered-To: patchwork-incoming-netdev@ozlabs.org Authentication-Results: ozlabs.org; spf=none (no SPF record) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=silabs.com Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=silabs.onmicrosoft.com header.i=@silabs.onmicrosoft.com header.b="FKqqYOdj"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 47c73Z1tsxz9sRX for ; Tue, 17 Dec 2019 04:06:50 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727742AbfLPRGs (ORCPT ); Mon, 16 Dec 2019 12:06:48 -0500 Received: from mail-dm6nam11on2042.outbound.protection.outlook.com ([40.107.223.42]:6255 "EHLO NAM11-DM6-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1727710AbfLPRGq (ORCPT ); Mon, 16 Dec 2019 12:06:46 -0500 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=BtPfbZHATLY9xb0Og9WkfbYWnWoIgF794RQE/8VUuH9peczml0EuYl9rRuQP+FYJ6J+XQzIQJH1iPnqNEtaQcMqmSJujfwIsTqPMMES9DUDNbvCiu6VdcVVPw4tRCcHHA5vMEJXTWZNJ+ImRDtpaDg9FdAdskQT2hExkAJIp23tlctInSwGZPKw8ORF1ZDxzU7otfPAwiiEiZL5jMnUoukKtFKqpi/8jmWIuYxliVtUpmQzcKfGlaeo2X8IV78jbUbgijcsDgB5kcdXBc4INZhPE7/3rsfK1NVBZ2ZnBjPFhfr/h06G85alQfa3BbtcZOOFUEw5w6VKUBbygnWTkXg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=mg+EntRAaAxWAlnA413NWq07DoMrRslmbbQ7DN8oNAE=; b=H7hhg4a3tX579wu2fkgHrGJIyBaIpDoMtNmZzslBhMdEGVn5GHnVmyMH2SBwZ7QkKETyQtEgomBXfHk/lC9c+Vz7lFxQ3iuG/aoeKZXweyuKGw0NyQ+YFGiDPHAEah7hVxFMpEiVxNCXrhlRHaQ48nmchnBg9Eb9DgMjfxDKiOo1LQa2ttxwNArwRsp8H4VWTYhO8wALZLxCSkeoyOFz6DbkqrAA8TcxX09u+GRlJKez0mNFCGOfyxw60CMeIyoplUkWHQqHQT3O5C4ERFmpI/mM1eTEqEFwdB9YPOQzoOjbTnlH2nAFNbOBp3i7lG5gl/7a20l8txNnHiDlClLDEw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=silabs.com; dmarc=pass action=none header.from=silabs.com; dkim=pass header.d=silabs.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=silabs.onmicrosoft.com; s=selector2-silabs-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=mg+EntRAaAxWAlnA413NWq07DoMrRslmbbQ7DN8oNAE=; b=FKqqYOdjg3USL51RA4L1hOfUPHja0qmzTsfl1Pdr2hOotqMNZc4JgjxCsPtZLdhxjSSupo3UaDDyc857N1lLUOjqEzLwyCZidlwu9jvYZo9Iz7XCS7pn7d/0ua4tq05DUG/t8QIyQNqN9LjezXUuV+Om8hziKofgllPcBnr8ndE= Received: from MN2PR11MB4063.namprd11.prod.outlook.com (10.255.180.22) by MN2PR11MB4445.namprd11.prod.outlook.com (52.135.37.87) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2538.18; Mon, 16 Dec 2019 17:06:39 +0000 Received: from MN2PR11MB4063.namprd11.prod.outlook.com ([fe80::f46c:e5b4:2a85:f0bf]) by MN2PR11MB4063.namprd11.prod.outlook.com ([fe80::f46c:e5b4:2a85:f0bf%4]) with mapi id 15.20.2538.019; Mon, 16 Dec 2019 17:06:39 +0000 From: =?utf-8?b?SsOpcsO0bWUgUG91aWxsZXI=?= To: "devel@driverdev.osuosl.org" , "linux-wireless@vger.kernel.org" CC: "netdev@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Greg Kroah-Hartman , Kalle Valo , "David S . Miller" , =?utf-8?b?SsOpcsO0bWUgUG91?= =?utf-8?q?iller?= Subject: [PATCH 35/55] staging: wfx: do not try to save call to hif_set_pm() Thread-Topic: [PATCH 35/55] staging: wfx: do not try to save call to hif_set_pm() Thread-Index: AQHVtDLK00XcshD/qkmDyYms/X/Dcw== Date: Mon, 16 Dec 2019 17:03:51 +0000 Message-ID: <20191216170302.29543-36-Jerome.Pouiller@silabs.com> References: <20191216170302.29543-1-Jerome.Pouiller@silabs.com> In-Reply-To: <20191216170302.29543-1-Jerome.Pouiller@silabs.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=Jerome.Pouiller@silabs.com; x-originating-ip: [37.71.187.125] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 4ba0e33a-007b-4530-1885-08d7824a510b x-ms-traffictypediagnostic: MN2PR11MB4445: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:2803; x-forefront-prvs: 02530BD3AA x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(376002)(346002)(366004)(39850400004)(396003)(136003)(189003)(199004)(110136005)(6486002)(107886003)(36756003)(186003)(316002)(66946007)(54906003)(5660300002)(66574012)(66446008)(66556008)(85182001)(66476007)(76116006)(91956017)(64756008)(2616005)(6506007)(85202003)(2906002)(26005)(71200400001)(6512007)(4326008)(8936002)(81166006)(1076003)(478600001)(86362001)(81156014)(6666004)(8676002); DIR:OUT; SFP:1101; SCL:1; SRVR:MN2PR11MB4445; H:MN2PR11MB4063.namprd11.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: silabs.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: DK+Y5VrN8wSFbtDliiSGmAY0pNrQ0ZrafIHZ/aO83n+rTO9mE4lzuRu8F47y0cJAp8M39zY2qIfdKvFIY/AP3D2LXkX0RMgwghSmz8d2LQ9biBb2/IvZNO6I6ArDpzT4vYZXubi679bYMNHag7XWw/2eVRHuirIGRxTxIVRTig9o1XkJieASzhowPfLdHPeUqO8ebk6A0ic4Z5I6l2Am05CQKC9R56xASDqCX7LXh5sGqRHbEh2spXD6sYfei/lVbFNz2zMpt9Nm4MI68f6nmwVkj0a9Xon7cMVUN4lxEWxXlUplG/Fqhw1lVbFwT3szLSl+kQl/g34vPTe5HA60Wlqc04r1KvEUpQIesXDZsTTAcXvQZbKn9h3cHWLIem6VT6nNw/kpMgA6mdmE1jBISvM9j1D8+mEKN5qHU1soydSSmcUuX/36GaM4yAp4Py29 Content-ID: MIME-Version: 1.0 X-OriginatorOrg: silabs.com X-MS-Exchange-CrossTenant-Network-Message-Id: 4ba0e33a-007b-4530-1885-08d7824a510b X-MS-Exchange-CrossTenant-originalarrivaltime: 16 Dec 2019 17:03:51.6797 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 54dbd822-5231-4b20-944d-6f4abcd541fb X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: HGoRiWSqCyg/vBUuZqhhYfe7n/cBlspKDbkOttUwz5acfJtxmldc1xY54I7a0xrghOIGDD1097FbWeyQuEGtlQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR11MB4445 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Jérôme Pouiller Current code try to not exchange data with device if it is not necessary. However, it seems that the additional code does not provide any gain. So, we prefer to keep a simpler code. Signed-off-by: Jérôme Pouiller --- drivers/staging/wfx/sta.c | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/drivers/staging/wfx/sta.c b/drivers/staging/wfx/sta.c index c57135f77572..dcb4693ec980 100644 --- a/drivers/staging/wfx/sta.c +++ b/drivers/staging/wfx/sta.c @@ -371,14 +371,11 @@ int wfx_conf_tx(struct ieee80211_hw *hw, struct ieee80211_vif *vif, struct wfx_dev *wdev = hw->priv; struct wfx_vif *wvif = (struct wfx_vif *) vif->drv_priv; int ret = 0; - /* To prevent re-applying PM request OID again and again*/ - u16 old_uapsd_flags, new_uapsd_flags; struct hif_req_edca_queue_params *edca; mutex_lock(&wdev->conf_mutex); if (queue < hw->queues) { - old_uapsd_flags = *((u16 *) &wvif->uapsd_info); edca = &wvif->edca.params[queue]; wvif->edca.uapsd_enable[queue] = params->uapsd; @@ -395,10 +392,8 @@ int wfx_conf_tx(struct ieee80211_hw *hw, struct ieee80211_vif *vif, if (wvif->vif->type == NL80211_IFTYPE_STATION) { ret = wfx_set_uapsd_param(wvif, &wvif->edca); - new_uapsd_flags = *((u16 *) &wvif->uapsd_info); if (!ret && wvif->setbssparams_done && - wvif->state == WFX_STATE_STA && - old_uapsd_flags != new_uapsd_flags) + wvif->state == WFX_STATE_STA) ret = wfx_update_pm(wvif); } } else {