From patchwork Mon Dec 16 17:03:50 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?b?SsOpcsO0bWUgUG91aWxsZXI=?= X-Patchwork-Id: 1210664 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming-netdev@ozlabs.org Delivered-To: patchwork-incoming-netdev@ozlabs.org Authentication-Results: ozlabs.org; spf=none (no SPF record) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=silabs.com Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=silabs.onmicrosoft.com header.i=@silabs.onmicrosoft.com header.b="nzECACEE"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 47c7740r0Yz9sRM for ; Tue, 17 Dec 2019 04:09:52 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727667AbfLPRJs (ORCPT ); Mon, 16 Dec 2019 12:09:48 -0500 Received: from mail-dm6nam11on2042.outbound.protection.outlook.com ([40.107.223.42]:6255 "EHLO NAM11-DM6-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726881AbfLPRGp (ORCPT ); Mon, 16 Dec 2019 12:06:45 -0500 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Q7Jkk8fOac6emFW9UsrxRyKxlK+tw2aO46quI+GMrEFpBztov1HGXAlEnYDEh6zzU9Wf+WW+zz6hs1m/mfGB02U1k2zkrhnvmD4IeBW3sgWimUeNbo0K6zyAyp39snCW2mtG8PKAnUt2UUwkmpuQmh9/PEmZYFJjhPxsVcfzR3vyam9Xg5ohbVtDsqZRP7Tbv8La0P0bGrSjLr5yBV8LiFz+DRkqGT0mzgj2HBYNyaVGfiH0GRL7ZqKvcUTt6dbKxERAoO0CfOdrzIld0oM9FPvzvLdGNBFjebgoLQvpDF1ptpt8y2xQb7atpZ1/FoATQazNwu6Aps6bbnMFPl2RzA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=t1ljpM1unF8pSnWFQGxia0iPUr2iLGMrzAbRzsCu2sY=; b=aHzBD3KhyRfkgxYbm7qu1N01erM/QOuJbKwh0wdJ2zIxD03GfIEZlCs//fw9L2aJSKsVJv8VzlxVWjFQvaEGwA7dknvYzhIBD+BsLc0DgAxyegfJKL71aRGenFd8HoSZv7+9m5kbVpKVNTAnHDC16FM45z49s2Fis+GvGJawQrqt4KKBhYpqzeVhnVICYnS4jeoo4iIM1MFuMf+CO5PqKBJxAGcXbJFU7bL80BljUCeSDWYf1lF1fd9303/7loM87TIVAcnO23utUWahcj/FdUnyIPuSsZyHE7rXaiQ5inEkglq/nTE2zKumnkfB3s8w/X7Xuv+ZpgITt0n/gY82AA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=silabs.com; dmarc=pass action=none header.from=silabs.com; dkim=pass header.d=silabs.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=silabs.onmicrosoft.com; s=selector2-silabs-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=t1ljpM1unF8pSnWFQGxia0iPUr2iLGMrzAbRzsCu2sY=; b=nzECACEEHRKKX3BKENjFo215CKf/CCMzQ1og9Zm4gIUdmstDrQdkOU14JPCdtnYHBPlCqlqWYwrKwtTypiPuCovRfPz7KxRhsJJRJdUgHxL/tDhRAjzXLAMh6Eym245bhXuVlQnw9Fz3JpZWlgm405BmWIBZ7EcZPSf68Q8fgZ0= Received: from MN2PR11MB4063.namprd11.prod.outlook.com (10.255.180.22) by MN2PR11MB4445.namprd11.prod.outlook.com (52.135.37.87) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2538.18; Mon, 16 Dec 2019 17:06:38 +0000 Received: from MN2PR11MB4063.namprd11.prod.outlook.com ([fe80::f46c:e5b4:2a85:f0bf]) by MN2PR11MB4063.namprd11.prod.outlook.com ([fe80::f46c:e5b4:2a85:f0bf%4]) with mapi id 15.20.2538.019; Mon, 16 Dec 2019 17:06:38 +0000 From: =?utf-8?b?SsOpcsO0bWUgUG91aWxsZXI=?= To: "devel@driverdev.osuosl.org" , "linux-wireless@vger.kernel.org" CC: "netdev@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Greg Kroah-Hartman , Kalle Valo , "David S . Miller" , =?utf-8?b?SsOpcsO0bWUgUG91?= =?utf-8?q?iller?= Subject: [PATCH 33/55] staging: wfx: remove redundant test while calling wfx_update_pm() Thread-Topic: [PATCH 33/55] staging: wfx: remove redundant test while calling wfx_update_pm() Thread-Index: AQHVtDLKeTmrGzcKVku43BbSIkPl/A== Date: Mon, 16 Dec 2019 17:03:50 +0000 Message-ID: <20191216170302.29543-34-Jerome.Pouiller@silabs.com> References: <20191216170302.29543-1-Jerome.Pouiller@silabs.com> In-Reply-To: <20191216170302.29543-1-Jerome.Pouiller@silabs.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=Jerome.Pouiller@silabs.com; x-originating-ip: [37.71.187.125] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: ca11c705-3617-4e3e-64c2-08d7824a506f x-ms-traffictypediagnostic: MN2PR11MB4445: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:785; x-forefront-prvs: 02530BD3AA x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(376002)(346002)(366004)(39850400004)(396003)(136003)(189003)(199004)(110136005)(6486002)(107886003)(4744005)(36756003)(186003)(316002)(66946007)(54906003)(5660300002)(66574012)(66446008)(66556008)(85182001)(66476007)(76116006)(91956017)(64756008)(2616005)(6506007)(85202003)(2906002)(26005)(71200400001)(6512007)(4326008)(8936002)(81166006)(1076003)(478600001)(86362001)(81156014)(6666004)(8676002); DIR:OUT; SFP:1101; SCL:1; SRVR:MN2PR11MB4445; H:MN2PR11MB4063.namprd11.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: silabs.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: OrdWclfDfqw4u3rbUmdLMPP3VgYTWLB1e5SmnYo3knnCUcrlDRM3Ddc393XV0KDad08hGUGdmdEpVO4VLaRMBomJbUSwCSCFzLXzZ4X9G0yxP0uSBzjzHILGGdOzjbV25ii43XwCp5h748BdUR6zJkuzAFO0ek8ykVZYu+OpWbgtG5pkZE4+Kl7nt1fN0DCkzDOY24JapiGuoJu4XoLxmW31px55eoSnyeGM5snK/BRZYjOvw6vUR3/tMFiWKmbsM5MXh/GXEDtHg1LVVE6sioNbGSoIqKHeWxlBAdNNuzu22tKI4tQV6kKHO3emOdbDLaeYM8ILxIcHrHRTS1k8G6Olsrf50veG5EdYI9o3DWXOk3XyvR04sFeoF1ubcSGoos9+vkSwOh9X4wlK4ERdFNRVrYYP2Tj/39d6q3ua1AKvdUimyoxfndZVeOtqZao9 Content-ID: <813A3A13B00BF342BC66A1233D7BA452@namprd11.prod.outlook.com> MIME-Version: 1.0 X-OriginatorOrg: silabs.com X-MS-Exchange-CrossTenant-Network-Message-Id: ca11c705-3617-4e3e-64c2-08d7824a506f X-MS-Exchange-CrossTenant-originalarrivaltime: 16 Dec 2019 17:03:50.8152 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 54dbd822-5231-4b20-944d-6f4abcd541fb X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: cuDryLZEwlPKIgSIrq7LPxYz1wiUm7Po4R3ajeY2Jo2iROlWZbEgz5uM6MlQT3waTkYIyePzWcJ4mrXyIcF2VQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR11MB4445 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Jérôme Pouiller Condition about wvif->state and wvif->bss_params.aid is already checked at beginning of wfx_update_pm(). Signed-off-by: Jérôme Pouiller --- drivers/staging/wfx/sta.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/staging/wfx/sta.c b/drivers/staging/wfx/sta.c index ee1b15950389..91fa4d8aa37d 100644 --- a/drivers/staging/wfx/sta.c +++ b/drivers/staging/wfx/sta.c @@ -1448,8 +1448,7 @@ int wfx_config(struct ieee80211_hw *hw, u32 changed) 2, 255); } } - if (wvif->state == WFX_STATE_STA && wvif->bss_params.aid) - wfx_update_pm(wvif); + wfx_update_pm(wvif); } wvif = wdev_to_wvif(wdev, 0); }