From patchwork Mon Dec 16 17:03:40 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?b?SsOpcsO0bWUgUG91aWxsZXI=?= X-Patchwork-Id: 1210621 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming-netdev@ozlabs.org Delivered-To: patchwork-incoming-netdev@ozlabs.org Authentication-Results: ozlabs.org; spf=none (no SPF record) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=silabs.com Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=silabs.onmicrosoft.com header.i=@silabs.onmicrosoft.com header.b="C5puRMO5"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 47c71T6TpMz9sRc for ; Tue, 17 Dec 2019 04:05:01 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727102AbfLPRD6 (ORCPT ); Mon, 16 Dec 2019 12:03:58 -0500 Received: from mail-eopbgr700045.outbound.protection.outlook.com ([40.107.70.45]:49121 "EHLO NAM04-SN1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726977AbfLPRDz (ORCPT ); Mon, 16 Dec 2019 12:03:55 -0500 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=klxwH+Z/9Jg9N/X3BD03cHvtUg1/ruHUBZ/4wRQdtv192tdpUmmxced0hEvFKCKFSNQWMRPUkwstInLC1jrD+1A9IVHXEF+cP8gesSAKjf1sfjdVsmphEG9emWiaQQXJVCPH9Sv8OcfjF37d3JJCy4rDHynvJFOMJF0XbBcN00siL/pZ+RorDZmG1xhhNFPMYnomgSOhqwrGaOcJbygBdNYDSnARCvw9i+8ALVk5+gnT0KouPCgSKsDVUeFHfD9ns6WRsz9yO04SftUFjLqXfSZCXucRrtP8Yxp4AQknKlEZ1KXouAkHKwY8MBX1MucxBhPPcaquAtzDqO3X7gmaRg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=67bz19hvec/sWmsh3LHft/L/nxeL7H9xihEyTUIhq+M=; b=WL24UlQz5D8Xaithxa7+eVQL7G+qDd96pmUkWFhUPLxy2F18L9ZulXJ/+x8+EVP3og/bHG8azchPEWgQYNHQg9owfFLk0p2Y/DMXSGGqc8/OboC1L3socy4y3zPern4mRnF+Tdyp9RVn9K7T4CURX10nkKPXNysBOmdsvk4dfzZkvSeQ/QSpSFnGhnPXa4A7/cA0YnyHsq9IUXJD0zvtF+ils6bcSqYbXw4tibv8GUlS/sHZGhilsbDRda6+lJIe+nZ4BIvsKq6VCs+ue6o/kPqDPYknl/GUQeFsElgoLwvhsfBqjob2A6g2WmvDsDKZ98W6Ufh5CyAFTff9XASdjA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=silabs.com; dmarc=pass action=none header.from=silabs.com; dkim=pass header.d=silabs.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=silabs.onmicrosoft.com; s=selector2-silabs-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=67bz19hvec/sWmsh3LHft/L/nxeL7H9xihEyTUIhq+M=; b=C5puRMO52l63SbzkxMhy0wXkF3Kju+vY8sgj3cWShie41xccAr6mc3td/3eRlO7I1HLrEis5j9xho1OJEAjav/EvT2C/eMgIN4OXAXw7G2IQ9vsWND4BcHaODdpL4W1WidaWzEsA/9Wuis+iIZdid1DbwucSgmrsRm8Va4xSBJ8= Received: from MN2PR11MB4063.namprd11.prod.outlook.com (10.255.180.22) by MN2PR11MB4351.namprd11.prod.outlook.com (52.135.39.159) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2538.19; Mon, 16 Dec 2019 17:03:48 +0000 Received: from MN2PR11MB4063.namprd11.prod.outlook.com ([fe80::f46c:e5b4:2a85:f0bf]) by MN2PR11MB4063.namprd11.prod.outlook.com ([fe80::f46c:e5b4:2a85:f0bf%4]) with mapi id 15.20.2538.019; Mon, 16 Dec 2019 17:03:48 +0000 From: =?utf-8?b?SsOpcsO0bWUgUG91aWxsZXI=?= To: "devel@driverdev.osuosl.org" , "linux-wireless@vger.kernel.org" CC: "netdev@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Greg Kroah-Hartman , Kalle Valo , "David S . Miller" , =?utf-8?b?SsOpcsO0bWUgUG91?= =?utf-8?q?iller?= Subject: [PATCH 14/55] staging: wfx: improve error message on unexpected confirmation Thread-Topic: [PATCH 14/55] staging: wfx: improve error message on unexpected confirmation Thread-Index: AQHVtDLE+xoe8CLn00OEKD99LLG3EA== Date: Mon, 16 Dec 2019 17:03:40 +0000 Message-ID: <20191216170302.29543-15-Jerome.Pouiller@silabs.com> References: <20191216170302.29543-1-Jerome.Pouiller@silabs.com> In-Reply-To: <20191216170302.29543-1-Jerome.Pouiller@silabs.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=Jerome.Pouiller@silabs.com; x-originating-ip: [37.71.187.125] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 88ede603-5a32-4c51-e3cf-08d78249eb4e x-ms-traffictypediagnostic: MN2PR11MB4351: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:1728; x-forefront-prvs: 02530BD3AA x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(136003)(366004)(376002)(346002)(396003)(39860400002)(199004)(189003)(66556008)(66446008)(64756008)(66476007)(76116006)(85202003)(91956017)(66946007)(4744005)(54906003)(107886003)(4326008)(478600001)(110136005)(71200400001)(6512007)(81156014)(8676002)(81166006)(186003)(36756003)(2906002)(85182001)(6666004)(66574012)(15650500001)(1076003)(316002)(6506007)(5660300002)(86362001)(26005)(2616005)(6486002)(8936002); DIR:OUT; SFP:1101; SCL:1; SRVR:MN2PR11MB4351; H:MN2PR11MB4063.namprd11.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: silabs.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: hG17I1SL6uZ3tOCXdHzH9t/jmSLl4518c22l9FaEn4AMsIazS7TDP/NgylNgUtRMG3r089LTFJ8SU3br3NSp794HVS67YNfSm4DIjxzIS/WsVVtIJrLdvOTSHXOmEZkzHyx4QWYOnWxTFEi1B0gLEYl8VjM505SaihzVy+yD7QCYpR7i9lGEm8WnZb6cBTvtCWGJI55iMzs1vHulWacpx2nqSp61YKmFqqcM7tRV+DFIVPwmifSXfhRwum/xV34/Nat8ASvfj0e4Ew97GzKDcVcSYADKlXANylbmf8TkfF31hfEHbWFk3gWW2iubLe+GnAnOxO142eORPE1f/BbuhUPiiNFmMvOunAb0tlV/GZqouZBHkqxVSKcqKkBnsti1AoWG/BCB5nUz3AD/gZEfdFx2Sg8NTh48H/9V5IV+GNISBW/bKke7RVPwXYaGTMzm Content-ID: <3C738A4F8126AA46857EE80D794F98BA@namprd11.prod.outlook.com> MIME-Version: 1.0 X-OriginatorOrg: silabs.com X-MS-Exchange-CrossTenant-Network-Message-Id: 88ede603-5a32-4c51-e3cf-08d78249eb4e X-MS-Exchange-CrossTenant-originalarrivaltime: 16 Dec 2019 17:03:40.9369 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 54dbd822-5231-4b20-944d-6f4abcd541fb X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: vYr2C1bXivClXvKubH35gJW17viAAb47zK+QfDwxcX2uu9G6iZtPTEHmHIR6qv5xUQ9+8MCFlDAhg6DSobHZ4A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR11MB4351 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Jérôme Pouiller When driver receives an unexpected answer from the device, it shows "unsupported HIF ID". That message does not represent the real error. Signed-off-by: Jérôme Pouiller --- drivers/staging/wfx/hif_rx.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/drivers/staging/wfx/hif_rx.c b/drivers/staging/wfx/hif_rx.c index 820de216be0c..1494ad5a507b 100644 --- a/drivers/staging/wfx/hif_rx.c +++ b/drivers/staging/wfx/hif_rx.c @@ -358,7 +358,12 @@ void wfx_handle_rx(struct wfx_dev *wdev, struct sk_buff *skb) goto free; } } - dev_err(wdev->dev, "unsupported HIF ID %02x\n", hif_id); + if (hif_id & 0x80) + dev_err(wdev->dev, "unsupported HIF indication: ID %02x\n", + hif_id); + else + dev_err(wdev->dev, "unexpected HIF confirmation: ID %02x\n", + hif_id); free: dev_kfree_skb(skb); }