diff mbox series

[net] net/core: Populate VF index in struct ifla_vf_guid

Message ID 20191203154337.42422-1-leon@kernel.org
State Accepted
Delegated to: David Miller
Headers show
Series [net] net/core: Populate VF index in struct ifla_vf_guid | expand

Commit Message

Leon Romanovsky Dec. 3, 2019, 3:43 p.m. UTC 
From: Danit Goldberg <danitg@mellanox.com>

In addition to filling the node_guid and port_guid attributes,
there is a need to populate VF index too, otherwise users of netlink
interface will see same VF index for all VFs.

Fixes: 30aad41721e0 ("net/core: Add support for getting VF GUIDs")
Signed-off-by: Danit Goldberg <danitg@mellanox.com>
Signed-off-by: Leon Romanovsky <leonro@mellanox.com>
---
 net/core/rtnetlink.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

--
2.20.1

Comments

David Miller Dec. 3, 2019, 7:25 p.m. UTC | #1 
From: Leon Romanovsky <leon@kernel.org>
Date: Tue,  3 Dec 2019 17:43:36 +0200

> From: Danit Goldberg <danitg@mellanox.com>
> 
> In addition to filling the node_guid and port_guid attributes,
> there is a need to populate VF index too, otherwise users of netlink
> interface will see same VF index for all VFs.
> 
> Fixes: 30aad41721e0 ("net/core: Add support for getting VF GUIDs")
> Signed-off-by: Danit Goldberg <danitg@mellanox.com>
> Signed-off-by: Leon Romanovsky <leonro@mellanox.com>

Applied, thank you.
diff mbox series

Patch

diff --git a/net/core/rtnetlink.c b/net/core/rtnetlink.c
index 93791dad3e31..af3a4f7ce3dc 100644
--- a/net/core/rtnetlink.c
+++ b/net/core/rtnetlink.c
@@ -1236,7 +1236,9 @@  static noinline_for_stack int rtnl_fill_vfinfo(struct sk_buff *skb,
 		vf_spoofchk.vf =
 		vf_linkstate.vf =
 		vf_rss_query_en.vf =
-		vf_trust.vf = ivi.vf;
+		vf_trust.vf =
+		node_guid.vf =
+		port_guid.vf = ivi.vf;

 	memcpy(vf_mac.mac, ivi.mac, sizeof(ivi.mac));
 	memcpy(vf_broadcast.broadcast, dev->broadcast, dev->addr_len);