Message ID | 20191121155503.52019-5-r.schwebel@pengutronix.de |
---|---|
State | Changes Requested |
Delegated to: | David Miller |
Headers | show |
Series | [1/5] docs: networking: nfc: change headlines to sphinx syntax | expand |
On Thu, 21 Nov 2019 16:55:03 +0100 Robert Schwebel <r.schwebel@pengutronix.de> wrote: > Now that the sphinx syntax has been fixed, change the document from txt > to rst and add it to the index. > > Signed-off-by: Robert Schwebel <r.schwebel@pengutronix.de> > --- > Documentation/networking/{nfc.txt => nfc.rst} | 0 > 1 file changed, 0 insertions(+), 0 deletions(-) > rename Documentation/networking/{nfc.txt => nfc.rst} (100%) > > diff --git a/Documentation/networking/nfc.txt b/Documentation/networking/nfc.rst > similarity index 100% > rename from Documentation/networking/nfc.txt > rename to Documentation/networking/nfc.rst It looks like you didn't actually add it to index.rst? In general the changes look good. I'd do it all in one patch, but that's up to Dave (who I assume will pick this up). Thanks, jon
From: Robert Schwebel <r.schwebel@pengutronix.de> Date: Thu, 21 Nov 2019 16:55:03 +0100 > Now that the sphinx syntax has been fixed, change the document from txt > to rst and add it to the index. > > Signed-off-by: Robert Schwebel <r.schwebel@pengutronix.de> As Jon mentioned, you aren't actually adding it to the index in this patch yet the commit message says that you did. Please fix that, repsin this series, and provide a proper "[PATCH 0/5] ..." cover letter this time. Thank you.
On Thu, Nov 21, 2019 at 10:10:27AM -0700, Jonathan Corbet wrote: > > Now that the sphinx syntax has been fixed, change the document from txt > > to rst and add it to the index. > > > > [...] > > > > diff --git a/Documentation/networking/nfc.txt b/Documentation/networking/nfc.rst > > similarity index 100% > > rename from Documentation/networking/nfc.txt > > rename to Documentation/networking/nfc.rst > > It looks like you didn't actually add it to index.rst? Whoops, that got lost, will change. rsc
On Thu, Nov 21, 2019 at 03:06:07PM -0800, David Miller wrote: > From: Robert Schwebel <r.schwebel@pengutronix.de> > Date: Thu, 21 Nov 2019 16:55:03 +0100 > > > Now that the sphinx syntax has been fixed, change the document from txt > > to rst and add it to the index. > > > > Signed-off-by: Robert Schwebel <r.schwebel@pengutronix.de> > > As Jon mentioned, you aren't actually adding it to the index in this > patch yet the commit message says that you did. The index doesn't seem to be particularly ordered, so I'll just add it to the end, ok? > Please fix that, repsin this series, and provide a proper "[PATCH 0/5] > ..." cover letter this time. Will do, thanks. rsc
diff --git a/Documentation/networking/nfc.txt b/Documentation/networking/nfc.rst
similarity index 100%
rename from Documentation/networking/nfc.txt
rename to Documentation/networking/nfc.rst
Now that the sphinx syntax has been fixed, change the document from txt to rst and add it to the index. Signed-off-by: Robert Schwebel <r.schwebel@pengutronix.de> --- Documentation/networking/{nfc.txt => nfc.rst} | 0 1 file changed, 0 insertions(+), 0 deletions(-) rename Documentation/networking/{nfc.txt => nfc.rst} (100%)