Message ID | 20191120155634.43936-1-sgarzare@redhat.com |
---|---|
State | Accepted |
Delegated to: | David Miller |
Headers | show |
Series | [net-next] vsock/vmci: make vmci_vsock_cb_host_called static | expand |
From: Stefano Garzarella <sgarzare@redhat.com> Date: Wed, 20 Nov 2019 16:56:34 +0100 > From: Mao Wenan <maowenan@huawei.com> > > When using make C=2 drivers/misc/vmw_vmci/vmci_driver.o > to compile, below warning can be seen: > drivers/misc/vmw_vmci/vmci_driver.c:33:6: warning: > symbol 'vmci_vsock_cb_host_called' was not declared. Should it be static? > > This patch make symbol vmci_vsock_cb_host_called static. > > Fixes: b1bba80a4376 ("vsock/vmci: register vmci_transport only when VMCI guest/host are active") > Reported-by: Hulk Robot <hulkci@huawei.com> > Signed-off-by: Mao Wenan <maowenan@huawei.com> > Reported-by: kbuild test robot <lkp@intel.com> > Signed-off-by: Stefano Garzarella <sgarzare@redhat.com> > --- > Hi Dave, > do you think it could go through net-next since it solves a problem > introduced by "vsock: add multi-transports support" series? > > Adding R-b from "kbuild test robot" that found the same issue. Applied to net-next.
diff --git a/drivers/misc/vmw_vmci/vmci_driver.c b/drivers/misc/vmw_vmci/vmci_driver.c index 95fed4664a2d..cbb706dabede 100644 --- a/drivers/misc/vmw_vmci/vmci_driver.c +++ b/drivers/misc/vmw_vmci/vmci_driver.c @@ -30,7 +30,7 @@ static bool vmci_host_personality_initialized; static DEFINE_MUTEX(vmci_vsock_mutex); /* protects vmci_vsock_transport_cb */ static vmci_vsock_cb vmci_vsock_transport_cb; -bool vmci_vsock_cb_host_called; +static bool vmci_vsock_cb_host_called; /* * vmci_get_context_id() - Gets the current context ID.