| Message ID | 20191031074931.20715-1-yuval.shaia@oracle.com |
|---|---|
| State | Changes Requested |
| Delegated to: | David Miller |
| Headers | show |
| Series | mlx4_core: fix wrong comment about the reason of subtract one from the max_cqes | expand |
On 10/31/2019 9:49 AM, Yuval Shaia wrote: > From: Dotan Barak <dotanb@dev.mellanox.co.il> > > Signed-off-by: Dotan Barak <dotanb@dev.mellanox.co.il> > Signed-off-by: Eli Cohen <eli@mellanox.co.il> > Signed-off-by: Vladimir Sokolovsky <vlad@mellanox.com> > Signed-off-by: Yuval Shaia <yuval.shaia@oracle.com> > --- > drivers/net/ethernet/mellanox/mlx4/main.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/net/ethernet/mellanox/mlx4/main.c b/drivers/net/ethernet/mellanox/mlx4/main.c > index fce9b3a24347..dcf6b4628c58 100644 > --- a/drivers/net/ethernet/mellanox/mlx4/main.c > +++ b/drivers/net/ethernet/mellanox/mlx4/main.c > @@ -514,8 +514,7 @@ static int mlx4_dev_cap(struct mlx4_dev *dev, struct mlx4_dev_cap *dev_cap) > dev->caps.max_rq_desc_sz = dev_cap->max_rq_desc_sz; > /* > * Subtract 1 from the limit because we need to allocate a > - * spare CQE so the HCA HW can tell the difference between an > - * empty CQ and a full CQ. > + * spare CQE to enable resizing the CQ > */ Please use a dot at EOL. This is not clear enough, especially without a commit message. > dev->caps.max_cqes = dev_cap->max_cq_sz - 1; > dev->caps.reserved_cqs = dev_cap->reserved_cqs; >
diff --git a/drivers/net/ethernet/mellanox/mlx4/main.c b/drivers/net/ethernet/mellanox/mlx4/main.c index fce9b3a24347..dcf6b4628c58 100644 --- a/drivers/net/ethernet/mellanox/mlx4/main.c +++ b/drivers/net/ethernet/mellanox/mlx4/main.c @@ -514,8 +514,7 @@ static int mlx4_dev_cap(struct mlx4_dev *dev, struct mlx4_dev_cap *dev_cap) dev->caps.max_rq_desc_sz = dev_cap->max_rq_desc_sz; /* * Subtract 1 from the limit because we need to allocate a - * spare CQE so the HCA HW can tell the difference between an - * empty CQ and a full CQ. + * spare CQE to enable resizing the CQ */ dev->caps.max_cqes = dev_cap->max_cq_sz - 1; dev->caps.reserved_cqs = dev_cap->reserved_cqs;