| Message ID | 20191001142151.1206987-1-arnd@arndb.de |
|---|---|
| State | Accepted |
| Delegated to: | David Miller |
| Headers | show |
| Series | ionic: select CONFIG_NET_DEVLINK | expand |
On 10/1/19 7:21 AM, Arnd Bergmann wrote: > When no other driver selects the devlink library code, ionic > produces a link failure: > > drivers/net/ethernet/pensando/ionic/ionic_devlink.o: In function `ionic_devlink_alloc': > ionic_devlink.c:(.text+0xd): undefined reference to `devlink_alloc' > drivers/net/ethernet/pensando/ionic/ionic_devlink.o: In function `ionic_devlink_register': > ionic_devlink.c:(.text+0x71): undefined reference to `devlink_register' > > Add the same 'select' statement that the other drivers use here. > > Fixes: fbfb8031533c ("ionic: Add hardware init and device commands") > Signed-off-by: Arnd Bergmann <arnd@arndb.de> > --- > drivers/net/ethernet/pensando/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/net/ethernet/pensando/Kconfig b/drivers/net/ethernet/pensando/Kconfig > index bd0583e409df..d25b88f53de4 100644 > --- a/drivers/net/ethernet/pensando/Kconfig > +++ b/drivers/net/ethernet/pensando/Kconfig > @@ -20,6 +20,7 @@ if NET_VENDOR_PENSANDO > config IONIC > tristate "Pensando Ethernet IONIC Support" > depends on 64BIT && PCI > + select NET_DEVLINK > help > This enables the support for the Pensando family of Ethernet > adapters. More specific information on this driver can be Thanks! Acked-by: Shannon Nelson <snelson@pensando.io>
From: Arnd Bergmann <arnd@arndb.de> Date: Tue, 1 Oct 2019 16:21:40 +0200 > When no other driver selects the devlink library code, ionic > produces a link failure: > > drivers/net/ethernet/pensando/ionic/ionic_devlink.o: In function `ionic_devlink_alloc': > ionic_devlink.c:(.text+0xd): undefined reference to `devlink_alloc' > drivers/net/ethernet/pensando/ionic/ionic_devlink.o: In function `ionic_devlink_register': > ionic_devlink.c:(.text+0x71): undefined reference to `devlink_register' > > Add the same 'select' statement that the other drivers use here. > > Fixes: fbfb8031533c ("ionic: Add hardware init and device commands") > Signed-off-by: Arnd Bergmann <arnd@arndb.de> Applied, thanks.
diff --git a/drivers/net/ethernet/pensando/Kconfig b/drivers/net/ethernet/pensando/Kconfig index bd0583e409df..d25b88f53de4 100644 --- a/drivers/net/ethernet/pensando/Kconfig +++ b/drivers/net/ethernet/pensando/Kconfig @@ -20,6 +20,7 @@ if NET_VENDOR_PENSANDO config IONIC tristate "Pensando Ethernet IONIC Support" depends on 64BIT && PCI + select NET_DEVLINK help This enables the support for the Pensando family of Ethernet adapters. More specific information on this driver can be
When no other driver selects the devlink library code, ionic produces a link failure: drivers/net/ethernet/pensando/ionic/ionic_devlink.o: In function `ionic_devlink_alloc': ionic_devlink.c:(.text+0xd): undefined reference to `devlink_alloc' drivers/net/ethernet/pensando/ionic/ionic_devlink.o: In function `ionic_devlink_register': ionic_devlink.c:(.text+0x71): undefined reference to `devlink_register' Add the same 'select' statement that the other drivers use here. Fixes: fbfb8031533c ("ionic: Add hardware init and device commands") Signed-off-by: Arnd Bergmann <arnd@arndb.de> --- drivers/net/ethernet/pensando/Kconfig | 1 + 1 file changed, 1 insertion(+)