| Message ID | 20190820003718.GA16620@toolchain |
|---|---|
| State | Awaiting Upstream |
| Delegated to: | David Miller |
| Headers | show |
| Series | ipvs: change type of delta and previous_delta in ip_vs_seq. | expand |
Hello, Cc list trimmed... On Tue, 20 Aug 2019, zhang kai wrote: > In NAT forwarding mode, Applications may decrease the size of packets, > and TCP sequences will get smaller, so both of variables will be negetive > values in this case. As long as nobody cares about their sign, the type should not matter. You can not solve all signed/unsigned mismatches with such small patch. Or you are seeing some problem, may be in debug? > > Signed-off-by: zhang kai <zhangkaiheb@126.com> > --- > include/net/ip_vs.h | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/include/net/ip_vs.h b/include/net/ip_vs.h > index 3759167f91f5..de7e75063c7c 100644 > --- a/include/net/ip_vs.h > +++ b/include/net/ip_vs.h > @@ -346,8 +346,8 @@ enum ip_vs_sctp_states { > */ > struct ip_vs_seq { > __u32 init_seq; /* Add delta from this seq */ > - __u32 delta; /* Delta in sequence numbers */ > - __u32 previous_delta; /* Delta in sequence numbers > + __s32 delta; /* Delta in sequence numbers */ > + __s32 previous_delta; /* Delta in sequence numbers > * before last resized pkt */ > }; > > -- > 2.17.1 Regards -- Julian Anastasov <ja@ssi.bg>
diff --git a/include/net/ip_vs.h b/include/net/ip_vs.h index 3759167f91f5..de7e75063c7c 100644 --- a/include/net/ip_vs.h +++ b/include/net/ip_vs.h @@ -346,8 +346,8 @@ enum ip_vs_sctp_states { */ struct ip_vs_seq { __u32 init_seq; /* Add delta from this seq */ - __u32 delta; /* Delta in sequence numbers */ - __u32 previous_delta; /* Delta in sequence numbers + __s32 delta; /* Delta in sequence numbers */ + __s32 previous_delta; /* Delta in sequence numbers * before last resized pkt */ };
In NAT forwarding mode, Applications may decrease the size of packets, and TCP sequences will get smaller, so both of variables will be negetive values in this case. Signed-off-by: zhang kai <zhangkaiheb@126.com> --- include/net/ip_vs.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)