| Message ID | 20190704033745.1758-1-yuehaibing@huawei.com |
|---|---|
| State | Accepted |
| Delegated to: | David Miller |
| Headers | show |
| Series | [v3,net-next] net: socionext: remove set but not used variable 'pkts' | expand |
From: YueHaibing <yuehaibing@huawei.com> Date: Thu, 4 Jul 2019 03:37:45 +0000 > Fixes gcc '-Wunused-but-set-variable' warning: > > drivers/net/ethernet/socionext/netsec.c: In function 'netsec_clean_tx_dring': > drivers/net/ethernet/socionext/netsec.c:637:15: warning: > variable 'pkts' set but not used [-Wunused-but-set-variable] > > It is not used since commit ba2b232108d3 ("net: netsec: add XDP support") > > Signed-off-by: YueHaibing <yuehaibing@huawei.com> > Acked-by: Ilias Apalodimas <ilias.apalodimas@linaro.org> Applied to net-next.
diff --git a/drivers/net/ethernet/socionext/netsec.c b/drivers/net/ethernet/socionext/netsec.c index 5544a722543f..d8d640b01119 100644 --- a/drivers/net/ethernet/socionext/netsec.c +++ b/drivers/net/ethernet/socionext/netsec.c @@ -634,15 +634,14 @@ static void netsec_set_rx_de(struct netsec_priv *priv, static bool netsec_clean_tx_dring(struct netsec_priv *priv) { struct netsec_desc_ring *dring = &priv->desc_ring[NETSEC_RING_TX]; - unsigned int pkts, bytes; struct netsec_de *entry; int tail = dring->tail; + unsigned int bytes; int cnt = 0; if (dring->is_xdp) spin_lock(&dring->lock); - pkts = 0; bytes = 0; entry = dring->vaddr + DESC_SZ * tail;
Fixes gcc '-Wunused-but-set-variable' warning: drivers/net/ethernet/socionext/netsec.c: In function 'netsec_clean_tx_dring': drivers/net/ethernet/socionext/netsec.c:637:15: warning: variable 'pkts' set but not used [-Wunused-but-set-variable] It is not used since commit ba2b232108d3 ("net: netsec: add XDP support") Signed-off-by: YueHaibing <yuehaibing@huawei.com> Acked-by: Ilias Apalodimas <ilias.apalodimas@linaro.org> --- v3: remove misplaced cc in patch log v2: keep reverse christmas-tree ordering of the local variables --- drivers/net/ethernet/socionext/netsec.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)